From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00,CTE_8BIT_MISMATCH, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 488DBC433EF for ; Sun, 19 Sep 2021 21:14:28 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9CC460FED for ; Sun, 19 Sep 2021 21:14:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D9CC460FED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:49786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mS48p-0006KM-04 for qemu-devel@archiver.kernel.org; Sun, 19 Sep 2021 17:14:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mS47t-0005fW-UE for qemu-devel@nongnu.org; Sun, 19 Sep 2021 17:13:30 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:39647) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mS47r-0003bl-KB for qemu-devel@nongnu.org; Sun, 19 Sep 2021 17:13:28 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 196-20020a1c04cd000000b002fa489ffe1fso14073275wme.4 for ; Sun, 19 Sep 2021 14:13:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=YHB5VQhk1PMYFGgCvOpFfpFfG4iWmxC01HOC5Szh0Ps=; b=av/p4EyDV7MeWpzkk1t0IXCsYtJ7Zqjkm6GV29lJD2/QJblgQnzIrbE7yiX4yeB5xl kWueyc93ALGMB3xkULAeWcZTY1pfY+CoTXptprhyVMeK9k0WpIh6xHf84P5p+d/M+IhW wHlnl2JYY3nKiI/gZoHITcCJF2avb6c5cCRHE0l0ekxIlwhsJdWNSKzYWY0FSRyTkJep QxxRR0N71KBqFpMVruGtruS+QggngCLbjHpeZ4Iqm0QfJFJ6cDjYJ0iRMgzsvoedOxaX 4sO9c/yOdNrEEtxm/DCXBrUySKwvzppb3cQy9kPWquFsdfzQM2A3bQ1zGc29slD/fYWM 8pUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=YHB5VQhk1PMYFGgCvOpFfpFfG4iWmxC01HOC5Szh0Ps=; b=cTj2cArvQCJd2wRXJspfxOOGXDzvxeA+rDy9AF6MlGmywOpmCgyOGtgcOqLzrdnta4 4Cn/hx8Kmiemg1ANwrMaNjVAODrpD8tPIO0uzuAtpT4I2UNflFe5HEyZZVhS8o7tSTLb NX66AW48ybhReh/IqNLUN8rG8ZyEXuu8hHQs3cTzEf8bTt1jl4c0uaSCULT62Im6syHq 9GQ7GALleV4A7nAFoV0lQeP6ck8PszFv6taOdEBYHRXlTeeWWFraSB9LXFCTdzK0udNp /XPJ2XD7BwIFTq/MCs3+RfZChbuI0n+x1DJrIcWlWEa8veBpPoa09ij3dMATnIPYUhyO Wk+A== X-Gm-Message-State: AOAM531rht2mBTi/+49iVaB2PCn0zmDDq07ty28W5d9jO8uYuJLo0lc1 n5l4iYoisp8QgR10w82UrkI= X-Google-Smtp-Source: ABdhPJypg/uI5Qpq6laXhNZchA7zJJqciFRRsTOgHAjvGugrmh3l4Ef5unEZUnU1R3THGA+qPwuRTQ== X-Received: by 2002:a05:600c:3585:: with SMTP id p5mr21585656wmq.88.1632086006271; Sun, 19 Sep 2021 14:13:26 -0700 (PDT) Received: from [192.168.1.36] (14.red-83-35-25.dynamicip.rima-tde.net. [83.35.25.14]) by smtp.gmail.com with ESMTPSA id l26sm17259502wmi.25.2021.09.19.14.13.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Sep 2021 14:13:25 -0700 (PDT) Message-ID: <059d1f48-2011-217a-0bf3-473d5b4b9bb9@amsat.org> Date: Sun, 19 Sep 2021 23:13:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v3 19/20] q800: wire up nubus IRQs Content-Language: en-US To: Mark Cave-Ayland , qemu-devel@nongnu.org, laurent@vivier.eu References: <20210916100554.10963-1-mark.cave-ayland@ilande.co.uk> <20210916100554.10963-20-mark.cave-ayland@ilande.co.uk> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <20210916100554.10963-20-mark.cave-ayland@ilande.co.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x32e.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, CTE_8BIT_MISMATCH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/16/21 12:05, Mark Cave-Ayland wrote: > Nubus IRQs are routed to the CPU through the VIA2 device so wire up the IRQs > using gpios accordingly. > > Signed-off-by: Mark Cave-Ayland > --- > hw/m68k/q800.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/hw/m68k/q800.c b/hw/m68k/q800.c > index e34df1a829..fbc45a301f 100644 > --- a/hw/m68k/q800.c > +++ b/hw/m68k/q800.c > @@ -396,6 +396,11 @@ static void q800_init(MachineState *machine) > sysbus_mmio_map(SYS_BUS_DEVICE(dev), 0, 9 * NUBUS_SUPER_SLOT_SIZE); > sysbus_mmio_map(SYS_BUS_DEVICE(dev), 1, NUBUS_SLOT_BASE + > 9 * NUBUS_SLOT_SIZE); > + for (i = 0; i < VIA2_NUBUS_IRQ_NB; i++) { > + qdev_connect_gpio_out(dev, 9 + i, > + qdev_get_gpio_in_named(via2_dev, "nubus-irq", > + VIA2_NUBUS_IRQ_9 + i)); > + } Hopefully Laurent can double-check the definition values. Otherwise for the qdev API usage: Reviewed-by: Philippe Mathieu-Daudé