From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Darbyshire-Bryant Subject: Re: [Cake] [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter Date: Fri, 18 May 2018 11:18:54 +0000 Message-ID: <05E1D675-B73B-4409-8991-EB89D5538EAB@darbyshire-bryant.me.uk> References: <152650253056.25701.10138252969621361651.stgit@alrua-kau> <152650254614.25701.1377066681230937234.stgit@alrua-kau> <87in7my196.fsf@toke.dk> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Apple-Mail=_85DA4C9B-DB0E-4AA0-9A6A-C9F0B52FF138"; protocol="application/pgp-signature"; micalg=pgp-sha256 Cc: =?utf-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Cake List , Linux Kernel Network Developers , Eric Dumazet To: Cong Wang Return-path: Received: from mail-eopbgr30076.outbound.protection.outlook.com ([40.107.3.76]:38317 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752319AbeERLS5 (ORCPT ); Fri, 18 May 2018 07:18:57 -0400 In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: --Apple-Mail=_85DA4C9B-DB0E-4AA0-9A6A-C9F0B52FF138 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 18 May 2018, at 05:27, Cong Wang wrote: >=20 > On Thu, May 17, 2018 at 4:23 AM, Toke H=C3=B8iland-J=C3=B8rgensen = wrote: >> Eric Dumazet writes: >>=20 >>> On 05/16/2018 01:29 PM, Toke H=C3=B8iland-J=C3=B8rgensen wrote: >>>> The ACK filter is an optional feature of CAKE which is designed to = improve >>>> performance on links with very asymmetrical rate limits. On such = links >>>> (which are unfortunately quite prevalent, especially for DSL and = cable >>>> subscribers), the downstream throughput can be limited by the = number of >>>> ACKs capable of being transmitted in the *upstream* direction. >>>>=20 >>>=20 >>> ... >>>=20 >>>>=20 >>>> Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen >>>> --- >>>> net/sched/sch_cake.c | 260 = ++++++++++++++++++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 258 insertions(+), 2 deletions(-) >>>>=20 >>>>=20 >>>=20 >>> I have decided to implement ACK compression in TCP stack itself. >>=20 >> Awesome! Will look forward to seeing that! >=20 > +1 >=20 > It is really odd to put into a TC qdisc, TCP stack is a much better > place. Speaking as a user of cake=E2=80=99s ack filtering, although it may be = an odd place, it is incredibly useful in my linux based home router = middle box that usefully extracts extra usable bandwidth from my = asymmetric link. And whilst ack compression/reduction/filtering call it = what you will, will come to the linux TCP stack, as yet other OS stacks = are less enlightened and benefit from the router=E2=80=99s = tweaking/meddling/interference. --Apple-Mail=_85DA4C9B-DB0E-4AA0-9A6A-C9F0B52FF138 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEASyssijGxT6XdZEjs6I4m53iM0oFAlr+tp0ACgkQs6I4m53i M0rpFBAAifIOEgUT+MX2pri6kZLXBmTShoY1sbBVAhuG1KBf0sDMAhqE3xcGysur VpReLV4ZKDsLPu5U8dI9O8K4H9YJFgqH4bn5COi5MhOxmRGZb5+D6C9Wf0//d8dK WPRqK5xam0TzUAx169i0u+jKrf5WsvMhOFSGcsyc3CDQrZR1mohAjw7MP1/8Q1d1 zsp0mQ4DK1Kha9Lyni0UDTCSJaVHPBbUKcxLLcuhGlHpQhGWPaQJ4hPmzZa//rOW 0tRyFXOcycISaHrtQqoH4SFf43OuPomhRFRuk7cpG9xtngpWOP8+81LMGjd894RI VKu/sBgz6n/G7lEf9XaE68ELwdMZhIODyspA8/4O59DoLyABToh/bLhNQKusuMjr xbbvh36ry1IxJ61xs10daU3vmQfgq+PUYK+tw+tdLr+msfaaJ3tUAoSrPqC0I5lS J58y4/L0YTXwrAnI/njM5zEOg9BTLo7Q4K+0TJUHCfORXUmgqhXFh3ZLhGCmI1Ph DmNbPZSpiTekEnu08AgI2v4T8g5icpTVOmk6HaevbqqCdsVw3YncZgAMkPSD6szz THWqxsLp01u/N09HrrDzAZMefmC4KuhozFDe28+nINql2ix5Ac2rZNQAih7pSC7s QCVkf3NsVM+vaxRwpk8xuIJojylMq4R2KItLoEFtbvYAs6gk5eI= =QSiD -----END PGP SIGNATURE----- --Apple-Mail=_85DA4C9B-DB0E-4AA0-9A6A-C9F0B52FF138--