From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 15/16] KVM: introduce a KVM_DESTROY_DEVICE ioctl Date: Fri, 15 Mar 2019 18:57:00 +0100 Message-ID: <05a98b0a-edc3-a129-34ac-8ecc644f4a1e@redhat.com> References: <20190222112840.25000-1-clg@kaod.org> <20190222112840.25000-16-clg@kaod.org> <20190225041507.GS7668@umbus.fritz.box> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , David Gibson Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: kvm.vger.kernel.org On 13/03/19 09:02, Cédric Le Goater wrote: > The 'destroy' method is currently used to destroy all devices when the > VM is destroyed after the vCPUs have been freed. > > This new KVM ioctl exposes the same KVM device method. It acts as a > software reset of the VM to 'destroy' selected devices when necessary > and perform the required cleanups on the vCPUs. Called with the > kvm->lock. > > The 'destroy' method could be improved by returning an error code. > > Signed-off-by: Cédric Le Goater Looks good to me. Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Date: Fri, 15 Mar 2019 17:57:00 +0000 Subject: Re: [PATCH v2 15/16] KVM: introduce a KVM_DESTROY_DEVICE ioctl Message-Id: <05a98b0a-edc3-a129-34ac-8ecc644f4a1e@redhat.com> List-Id: References: <20190222112840.25000-1-clg@kaod.org> <20190222112840.25000-16-clg@kaod.org> <20190225041507.GS7668@umbus.fritz.box> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , David Gibson Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org On 13/03/19 09:02, C=E9dric Le Goater wrote: > The 'destroy' method is currently used to destroy all devices when the > VM is destroyed after the vCPUs have been freed. >=20 > This new KVM ioctl exposes the same KVM device method. It acts as a > software reset of the VM to 'destroy' selected devices when necessary > and perform the required cleanups on the vCPUs. Called with the > kvm->lock. >=20 > The 'destroy' method could be improved by returning an error code. >=20 > Signed-off-by: C=E9dric Le Goater Looks good to me. Paolo