All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene@kernel.org>
To: "'Olof Johansson'" <olof@lixom.net>,
	"'Javier Martinez Canillas'" <javier@dowhile0.org>
Cc: "'Krzysztof Kozlowski'" <k.kozlowski@samsung.com>,
	arm@kernel.org, "'Arnd Bergmann'" <arnd@arndb.de>,
	"'Kevin Hilman'" <khilman@linaro.org>,
	"'Doug Anderson'" <dianders@chromium.org>,
	"'Kukjin Kim'" <kgene@kernel.org>,
	linux-samsung-soc@vger.kernel.org,
	"'Linux Kernel'" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/9] ARM: multi_v7_defconfig: Enable max77802 regulator, rtc and clock drivers
Date: Sat, 25 Jul 2015 11:01:34 +0900	[thread overview]
Message-ID: <05ac01d0c67d$d581a740$8084f5c0$@kernel.org> (raw)
In-Reply-To: <CAOesGMjBgbsPZujB=kQgv-pUuFs3Qvufz1_1TsDVA0dYzs1Cdw@mail.gmail.com>

Olof Johansson wrote:
> 
> Hi,
> 
Hi,

> On Fri, Jul 17, 2015 at 11:47 AM, Javier Martinez Canillas
> <javier@dowhile0.org> wrote:
> > Hello Olof,
> >
> > On Fri, Jul 17, 2015 at 6:49 PM, Olof Johansson <olof@lixom.net> wrote:
> >> On Thu, Jul 16, 2015 at 09:42:47AM +0900, Krzysztof Kozlowski wrote:
> >>> On 16.07.2015 00:38, Javier Martinez Canillas wrote:
> >>> > Hello,
> >>> >
> >>> > On Thu, May 14, 2015 at 5:40 PM, Javier Martinez Canillas
> >>> > <javier.martinez@collabora.co.uk> wrote:
> >>> >> The Maxim max77802 Power Management IC is used on many Exynos machines.
> >>> >> Besides a bunch of regulators, this chip has a Real-Time-Clock (RTC)
> >>> >> and 2-channel 32kHz clock outputs.
> >>> >>
> >>> >> Enable the kernel config options to have the drivers for these devices
> >>> >> built as a module.
> >>> >>
> >>> >> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> >>> >> ---
> >>> >>  arch/arm/configs/multi_v7_defconfig | 3 +++
> >>> >>  1 file changed, 3 insertions(+)
> >>> >>
> >>> >> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> >>> >> index 2349584b6e08..080120fe5580 100644
> >>> >> --- a/arch/arm/configs/multi_v7_defconfig
> >>> >> +++ b/arch/arm/configs/multi_v7_defconfig
> >>> >> @@ -373,6 +373,7 @@ CONFIG_POWER_RESET_SYSCON=y
> >>> >>  CONFIG_REGULATOR_MAX8907=y
> >>> >>  CONFIG_REGULATOR_MAX8973=y
> >>> >>  CONFIG_REGULATOR_MAX77686=y
> >>> >> +CONFIG_REGULATOR_MAX77802=m
> >>> >
> >>> > I noticed that the version that landed in 4.2-rc1 as commit
> >>> > f3caa529c6f5 ("ARM: multi_v7_defconfig: Enable max77802 regulator, rtc
> >>> > and clock drivers") doesn't include this symbol. I guess it was caused
> >>> > by a wrong resolved conflict? I'll post a patch to enable the
> >>> > regulator again.
> >>>
> >>> As you can see in mentioned mainline commit Kukjin removed it manually:
> >>> [kgene@kernel.org: removing useless REGULATOR_MAX77802 config]
> >>>
> >>> I wonder why?
> >>
> >> Seems odd. exynos_defconfig still enables it.
> >>
It has been removed when I did 'make savedefconfig' at that time maybe because
of dependency with other configs...

> > Yeah since it is needed for at least the Exynos5420 Peach Pit and
> > Exynos5800 Peach Pi Chromebooks that use this PMIC.
> >
> >> Javier or Krzysztof, please send an incremental fix to enable and I'll pick
> >> it up as a fix.
> >>
> >
> > I already posted an incremental patch [0] and Krzysztof is pushing it
> > through Kukjin for 4.3 [1].
> >
Yes. I'll send it out to arm-soc in this weekend.

> > I guess that's OK and there is no need to add it as a fix for the 4.2
> > -rc cycle since this is not really a regression. I mean, the max77802
> > regulator driver was never enabled for multi_v7_defconfig before.
> 
> Yeah, I came across those emails a little further down. :-) It's all
> good, we'll see it come in later.
> 
Thanks,
Kukjin


  reply	other threads:[~2015-07-25  2:01 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14 15:40 [PATCH 0/9] multi_v7_defconfig: Enable options for Exynos Chromebooks Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 1/9] ARM: multi_v7_defconfig: Enable support for Samsung S3C64XX SPI Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 2/9] ARM: multi_v7_defconfig: Enable max77802 regulator, rtc and clock drivers Javier Martinez Canillas
2015-07-15 15:38   ` Javier Martinez Canillas
2015-07-15 15:38     ` Javier Martinez Canillas
2015-07-16  0:42     ` Krzysztof Kozlowski
2015-07-16  0:42       ` Krzysztof Kozlowski
2015-07-16  5:30       ` Javier Martinez Canillas
2015-07-16  5:30         ` Javier Martinez Canillas
2015-07-17 16:49       ` Olof Johansson
2015-07-17 16:49         ` Olof Johansson
2015-07-17 18:47         ` Javier Martinez Canillas
2015-07-17 18:47           ` Javier Martinez Canillas
2015-07-17 18:49           ` Olof Johansson
2015-07-17 18:49             ` Olof Johansson
2015-07-25  2:01             ` Kukjin Kim [this message]
2015-05-14 15:40 ` [PATCH 3/9] ARM: multi_v7_defconfig: Enable Exynos USB PHY drivers support Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 4/9] ARM: multi_v7_defconfig: Enable support for missing ChromeOS EC drivers Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 5/9] ARM: multi_v7_defconfig: Enable Samsung PWM support Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 6/9] ARM: multi_v7_defconfig: Enable Samsung S3C SoC RTC Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 7/9] ARM: multi_v7_defconfig: Enable options for Exynos display support Javier Martinez Canillas
2015-05-15  0:36   ` Krzysztof Kozlowski
2015-05-15  0:58     ` Javier Martinez Canillas
2015-05-15  0:58       ` Javier Martinez Canillas
2015-05-15  1:08       ` Krzysztof Kozlowski
2015-05-15  1:08         ` Krzysztof Kozlowski
2015-05-14 15:40 ` [PATCH 8/9] ARM: multi_v7_defconfig: Enable GPIO-based I2C arbitration support Javier Martinez Canillas
2015-05-14 15:40 ` [PATCH 9/9] ARM: multi_v7_defconfig: Enable Cypress APA I2C Trackpad support Javier Martinez Canillas
2015-05-15  0:18 ` [PATCH 0/9] multi_v7_defconfig: Enable options for Exynos Chromebooks Krzysztof Kozlowski
2015-05-15  0:33   ` Javier Martinez Canillas
2015-05-15  0:33     ` Javier Martinez Canillas
2015-05-15 11:37 ` Arnd Bergmann
2015-05-15 12:00   ` Krzysztof Kozlowski
2015-05-16  3:25     ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='05ac01d0c67d$d581a740$8084f5c0$@kernel.org' \
    --to=kgene@kernel.org \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=dianders@chromium.org \
    --cc=javier@dowhile0.org \
    --cc=k.kozlowski@samsung.com \
    --cc=khilman@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=olof@lixom.net \
    --subject='RE: [PATCH 2/9] ARM: multi_v7_defconfig: Enable max77802 regulator, rtc and clock drivers' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.