All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [PATCH 1/2] lib: print_freq() should output kHz not KHz
Date: Fri, 9 Oct 2020 06:12:57 +0200	[thread overview]
Message-ID: <05b7ae8a-6bd8-6d6f-33b6-ae02af22103d@denx.de> (raw)
In-Reply-To: <20201008202324.51012-2-xypron.glpk@gmx.de>

On 08.10.20 22:23, Heinrich Schuchardt wrote:
> In the International System of Units (SI) the prefix kilo is abbreviated as
> 'k' not 'K'. 'K' is the symbol for Kelvin.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   include/display_options.h | 2 +-
>   lib/display_options.c     | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/display_options.h b/include/display_options.h
> index a0dabca2b8..049688e39e 100644
> --- a/include/display_options.h
> +++ b/include/display_options.h
> @@ -24,7 +24,7 @@ void print_size(uint64_t size, const char *suffix);
>   /**
>    * print_freq() - Print a frequency with a suffix
>    *
> - * Print frequencies as "x.xx GHz", "xxx KHz", etc as needed; allow for
> + * Print frequencies as "x.xx GHz", "xxx kHz", etc as needed; allow for
>    * optional trailing string (like "\n")
>    *
>    * @freq:	Frequency to print in Hz
> diff --git a/lib/display_options.c b/lib/display_options.c
> index ea9977cc18..b2025eeb5c 100644
> --- a/lib/display_options.c
> +++ b/lib/display_options.c
> @@ -54,7 +54,7 @@ void print_freq(uint64_t freq, const char *s)
>   {
>   	unsigned long m = 0;
>   	uint32_t f;
> -	static const char names[] = {'G', 'M', 'K'};
> +	static const char names[] = {'G', 'M', 'k'};
>   	unsigned long d = 1e9;
>   	char c = 0;
>   	unsigned int i;
> --
> 2.28.0
> 


Viele Gr??e,
Stefan

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de

  reply	other threads:[~2020-10-09  4:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-08 20:23 [PATCH 0/2] lib: print_freq() should output kHz not KHz Heinrich Schuchardt
2020-10-08 20:23 ` [PATCH 1/2] " Heinrich Schuchardt
2020-10-09  4:12   ` Stefan Roese [this message]
2020-10-23  0:29   ` Tom Rini
2020-10-08 20:23 ` [PATCH 2/2] test: unit tests for print_freq(), print_size() Heinrich Schuchardt
2020-10-09  1:23   ` Sean Anderson
2020-10-22 13:56   ` Tom Rini
2020-10-22 19:45 [PATCH 0/2] lib: print_freq() should output kHz not KHz Heinrich Schuchardt
2020-10-22 19:45 ` [PATCH 1/2] " Heinrich Schuchardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05b7ae8a-6bd8-6d6f-33b6-ae02af22103d@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.