From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64847C4338F for ; Tue, 17 Aug 2021 16:50:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 491D960FD9 for ; Tue, 17 Aug 2021 16:50:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230481AbhHQQv0 (ORCPT ); Tue, 17 Aug 2021 12:51:26 -0400 Received: from mxout04.lancloud.ru ([45.84.86.114]:42202 "EHLO mxout04.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231436AbhHQQv0 (ORCPT ); Tue, 17 Aug 2021 12:51:26 -0400 X-Greylist: delayed 548 seconds by postgrey-1.27 at vger.kernel.org; Tue, 17 Aug 2021 12:51:25 EDT Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout04.lancloud.ru C46BC20CEA3B Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH v6 3/3] arm64: dts: renesas: r9a07g044: Add USB2.0 device support To: Biju Das , Rob Herring CC: Geert Uytterhoeven , Magnus Damm , "linux-renesas-soc@vger.kernel.org" , "devicetree@vger.kernel.org" , Chris Paterson , Biju Das , Prabhakar Mahadev Lad References: <20210812151808.7916-1-biju.das.jz@bp.renesas.com> <20210812151808.7916-4-biju.das.jz@bp.renesas.com> <2f5f8999-260d-e9c0-731e-df644b528b61@gmail.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <05bdd9e8-e68f-c8b4-a7d9-a83f2ca97a58@omp.ru> Date: Tue, 17 Aug 2021 19:41:41 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 8/17/21 2:12 PM, Biju Das wrote: [...] >>>> Add USB2.0 device support to RZ/G2L SoC DT. >>>> >>>> Signed-off-by: Biju Das >>>> Reviewed-by: Lad Prabhakar >>>> Reviewed-by: Geert Uytterhoeven >>> [...] >>>> diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi >>> b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi >>>> index de78c921af22..2f313c2a81c7 100644 >>>> --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi >>>> +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi >>>> @@ -391,6 +391,25 @@ >>>> power-domains = <&cpg>; >>>> status = "disabled"; >>>> }; >>>> + >>>> + hsusb: usb@11c60000 { >>>> + compatible = "renesas,usbhs-r9a07g044", >>>> + "renesas,rza2-usbhs"; >>>> + reg = <0 0x11c60000 0 0x10000>; >>>> + interrupts = , >>>> + , >>>> + , >>>> + ; >>> >>> Don't we need to specify "interrupt-names" when there a more than 1 >>> interrupts? >> >> This dtsi changes, as per binding documentation [1]. As you see, >> "interrupt-names" is optional. > > For now I will go with current dt changes. > > Later I will create incremental patches for dt-binding with optional "interrupt-names", > "clock-names" and "reset names" for all the SoC's supported by this binding doc. > > After that, will send an incremental patch with adding optional properties in all SoC dtsi. > > Does it make sense? I had the impression that the "*-names" prop was mandatory for a "*" prop having 2 values or mores. If it's now allowed to be optional, don't bother with that at all. > Regards, > Biju MBR, Sergei