From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E53D8C433E0 for ; Thu, 28 Jan 2021 09:49:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9161264D9D for ; Thu, 28 Jan 2021 09:49:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231972AbhA1Jsz (ORCPT ); Thu, 28 Jan 2021 04:48:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:56194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232085AbhA1JrC (ORCPT ); Thu, 28 Jan 2021 04:47:02 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D853664DD1; Thu, 28 Jan 2021 09:46:21 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1l53sZ-00Aa8x-JG; Thu, 28 Jan 2021 09:46:19 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 28 Jan 2021 09:46:19 +0000 From: Marc Zyngier To: Suzuki K Poulose Cc: Anshuman Khandual , linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, mathieu.poirier@linaro.org, mike.leach@linaro.org, lcherian@marvell.com, linux-kernel@vger.kernel.org, Will Deacon , Catalin Marinas , Mark Rutland Subject: Re: [PATCH V3 10/14] arm64: nvhe: Allow TRBE access at EL1 In-Reply-To: References: <1611737738-1493-1-git-send-email-anshuman.khandual@arm.com> <1611737738-1493-11-git-send-email-anshuman.khandual@arm.com> <12b1572e2568d4936f0458649065fe64@kernel.org> User-Agent: Roundcube Webmail/1.4.10 Message-ID: <05c4cde3da791e7effd6196a197f5c98@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: suzuki.poulose@arm.com, anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, mathieu.poirier@linaro.org, mike.leach@linaro.org, lcherian@marvell.com, linux-kernel@vger.kernel.org, will@kernel.org, catalin.marinas@arm.com, mark.rutland@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-01-28 09:34, Suzuki K Poulose wrote: > On 1/27/21 9:58 AM, Marc Zyngier wrote: >> On 2021-01-27 08:55, Anshuman Khandual wrote: >>> From: Suzuki K Poulose >>> >>> When the kernel is booted at EL2 in a nvhe configuration, >>> enable the TRBE access to the EL1. The EL1 still can't trace >>> EL2, unless EL2 permits explicitly via TRFCR_EL2.E2TRE. >>> >>> Cc: Will Deacon >>> Cc: Catalin Marinas >>> Cc: Marc Zyngier >>> Cc: Mark Rutland >>> cc: Anshuman Khandual >>> Signed-off-by: Suzuki K Poulose >>> Signed-off-by: Anshuman Khandual >> >> Acked-by: Marc Zyngier >> >> One comment below, though: >> >>> --- >>>  arch/arm64/include/asm/el2_setup.h | 19 +++++++++++++++++++ >>>  arch/arm64/include/asm/kvm_arm.h   |  2 ++ >>>  2 files changed, 21 insertions(+) >>> >>> diff --git a/arch/arm64/include/asm/el2_setup.h >>> b/arch/arm64/include/asm/el2_setup.h >>> index a7f5a1b..05ecce9 100644 >>> --- a/arch/arm64/include/asm/el2_setup.h >>> +++ b/arch/arm64/include/asm/el2_setup.h >>> @@ -72,6 +72,25 @@ >>>  .endif >>> >>>  3: >>> + >>> +.ifeqs    "\mode", "nvhe" >>> +    /* >>> +     * If the Trace Buffer is available, allow >>> +     * the EL1 to own it. Note that EL1 cannot >>> +     * trace the EL2, as it is prevented by >>> +     * TRFCR_EL2.E2TRE == 0. >>> +     */ >>> +    ubfx    x0, x1, #ID_AA64DFR0_TRBE_SHIFT, #4 >>> +    cbz    x0, 1f >>> + >>> +    mrs_s    x0, SYS_TRBIDR_EL1 >>> +    and    x0, x0, TRBIDR_PROG >>> +    cbnz    x0, 1f >>> +    mov    x0, #(MDCR_EL2_E2TB_EL1_OWN << MDCR_EL2_E2TB_SHIFT) >>> +    orr    x2, x2, x0 >>> +.endif >>> + >>> +1: >> >> Note that this will (badly) conflict with the late-VHE patches[1], >> where this code path has been reworked. > > Thanks for the heads up. We will need to see how things get merged. > Ideally this patch and the previous one (TRBE definitions could go > via the arm64 tree / kvm tree), in which case we could rebase these > two patches on the respective tree. I think the current plan of action is to go via the arm64 tree, given that there is nothing really KVM specific there. I'll respin the series one last (hopefully!) time on Monday. Let me know if you need a hand with the rebasing. Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FA8CC433E0 for ; Thu, 28 Jan 2021 09:47:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBE1F64D9D for ; Thu, 28 Jan 2021 09:47:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBE1F64D9D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BqKpusWLnC/Smysu9B+mM2C3elCBrIpdW0MfSZD2rHs=; b=Xs2J+YX7PlT/6apr7sefnGYX1 bP4MtZyskch1+7SHx1ULLUonRYkYNGUKJ4LS69/Wgg1+4p+ahaqCp6VB31b1qwtdabc6gh4DYDXM0 YZuULGa6av913h6Zfc1SRG2Nps74KVTrGaHEZ5gImJpWsp7hqkp838984ngve3v/islMjeNclmbbP MqhjzJqoHF/YeooXwAuW+DREtzkUwpuCOHMys1nWp6eUKWviujW6O47pmWUrtQYhPpUFeDE40cHld AF/CUzkWul8X6DsV3WYrrFM3QTzFgTTObn8knDB2vN4swQWNevnunWZO02rvjsVJZ7+P6lg1RrK4O 0xUwVVOhA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l53sf-0005yi-Ps; Thu, 28 Jan 2021 09:46:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l53sd-0005yD-AB for linux-arm-kernel@lists.infradead.org; Thu, 28 Jan 2021 09:46:24 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D853664DD1; Thu, 28 Jan 2021 09:46:21 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1l53sZ-00Aa8x-JG; Thu, 28 Jan 2021 09:46:19 +0000 MIME-Version: 1.0 Date: Thu, 28 Jan 2021 09:46:19 +0000 From: Marc Zyngier To: Suzuki K Poulose Subject: Re: [PATCH V3 10/14] arm64: nvhe: Allow TRBE access at EL1 In-Reply-To: References: <1611737738-1493-1-git-send-email-anshuman.khandual@arm.com> <1611737738-1493-11-git-send-email-anshuman.khandual@arm.com> <12b1572e2568d4936f0458649065fe64@kernel.org> User-Agent: Roundcube Webmail/1.4.10 Message-ID: <05c4cde3da791e7effd6196a197f5c98@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: suzuki.poulose@arm.com, anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org, mathieu.poirier@linaro.org, mike.leach@linaro.org, lcherian@marvell.com, linux-kernel@vger.kernel.org, will@kernel.org, catalin.marinas@arm.com, mark.rutland@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210128_044623_572646_E23201CF X-CRM114-Status: GOOD ( 17.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , mathieu.poirier@linaro.org, Anshuman Khandual , Catalin Marinas , coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will Deacon , lcherian@marvell.com, mike.leach@linaro.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMS0wMS0yOCAwOTozNCwgU3V6dWtpIEsgUG91bG9zZSB3cm90ZToKPiBPbiAxLzI3LzIx IDk6NTggQU0sIE1hcmMgWnluZ2llciB3cm90ZToKPj4gT24gMjAyMS0wMS0yNyAwODo1NSwgQW5z aHVtYW4gS2hhbmR1YWwgd3JvdGU6Cj4+PiBGcm9tOiBTdXp1a2kgSyBQb3Vsb3NlIDxzdXp1a2ku cG91bG9zZUBhcm0uY29tPgo+Pj4gCj4+PiBXaGVuIHRoZSBrZXJuZWwgaXMgYm9vdGVkIGF0IEVM MiBpbiBhIG52aGUgY29uZmlndXJhdGlvbiwKPj4+IGVuYWJsZSB0aGUgVFJCRSBhY2Nlc3MgdG8g dGhlIEVMMS4gVGhlIEVMMSBzdGlsbCBjYW4ndCB0cmFjZQo+Pj4gRUwyLCB1bmxlc3MgRUwyIHBl cm1pdHMgZXhwbGljaXRseSB2aWEgVFJGQ1JfRUwyLkUyVFJFLgo+Pj4gCj4+PiBDYzogV2lsbCBE ZWFjb24gPHdpbGxAa2VybmVsLm9yZz4KPj4+IENjOiBDYXRhbGluIE1hcmluYXMgPGNhdGFsaW4u bWFyaW5hc0Bhcm0uY29tPgo+Pj4gQ2M6IE1hcmMgWnluZ2llciA8bWF6QGtlcm5lbC5vcmc+Cj4+ PiBDYzogTWFyayBSdXRsYW5kIDxtYXJrLnJ1dGxhbmRAYXJtLmNvbT4KPj4+IGNjOiBBbnNodW1h biBLaGFuZHVhbCA8YW5zaHVtYW4ua2hhbmR1YWxAYXJtLmNvbT4KPj4+IFNpZ25lZC1vZmYtYnk6 IFN1enVraSBLIFBvdWxvc2UgPHN1enVraS5wb3Vsb3NlQGFybS5jb20+Cj4+PiBTaWduZWQtb2Zm LWJ5OiBBbnNodW1hbiBLaGFuZHVhbCA8YW5zaHVtYW4ua2hhbmR1YWxAYXJtLmNvbT4KPj4gCj4+ IEFja2VkLWJ5OiBNYXJjIFp5bmdpZXIgPG1hekBrZXJuZWwub3JnPgo+PiAKPj4gT25lIGNvbW1l bnQgYmVsb3csIHRob3VnaDoKPj4gCj4+PiAtLS0KPj4+IMKgYXJjaC9hcm02NC9pbmNsdWRlL2Fz bS9lbDJfc2V0dXAuaCB8IDE5ICsrKysrKysrKysrKysrKysrKysKPj4+IMKgYXJjaC9hcm02NC9p bmNsdWRlL2FzbS9rdm1fYXJtLmjCoMKgIHzCoCAyICsrCj4+PiDCoDIgZmlsZXMgY2hhbmdlZCwg MjEgaW5zZXJ0aW9ucygrKQo+Pj4gCj4+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9pbmNsdWRl L2FzbS9lbDJfc2V0dXAuaAo+Pj4gYi9hcmNoL2FybTY0L2luY2x1ZGUvYXNtL2VsMl9zZXR1cC5o Cj4+PiBpbmRleCBhN2Y1YTFiLi4wNWVjY2U5IDEwMDY0NAo+Pj4gLS0tIGEvYXJjaC9hcm02NC9p bmNsdWRlL2FzbS9lbDJfc2V0dXAuaAo+Pj4gKysrIGIvYXJjaC9hcm02NC9pbmNsdWRlL2FzbS9l bDJfc2V0dXAuaAo+Pj4gQEAgLTcyLDYgKzcyLDI1IEBACj4+PiDCoC5lbmRpZgo+Pj4gCj4+PiDC oDM6Cj4+PiArCj4+PiArLmlmZXFzwqDCoMKgICJcbW9kZSIsICJudmhlIgo+Pj4gK8KgwqDCoCAv Kgo+Pj4gK8KgwqDCoMKgICogSWYgdGhlIFRyYWNlIEJ1ZmZlciBpcyBhdmFpbGFibGUsIGFsbG93 Cj4+PiArwqDCoMKgwqAgKiB0aGUgRUwxIHRvIG93biBpdC4gTm90ZSB0aGF0IEVMMSBjYW5ub3QK Pj4+ICvCoMKgwqDCoCAqIHRyYWNlIHRoZSBFTDIsIGFzIGl0IGlzIHByZXZlbnRlZCBieQo+Pj4g K8KgwqDCoMKgICogVFJGQ1JfRUwyLkUyVFJFID09IDAuCj4+PiArwqDCoMKgwqAgKi8KPj4+ICvC oMKgwqAgdWJmeMKgwqDCoCB4MCwgeDEsICNJRF9BQTY0REZSMF9UUkJFX1NISUZULCAjNAo+Pj4g K8KgwqDCoCBjYnrCoMKgwqAgeDAsIDFmCj4+PiArCj4+PiArwqDCoMKgIG1yc19zwqDCoMKgIHgw LCBTWVNfVFJCSURSX0VMMQo+Pj4gK8KgwqDCoCBhbmTCoMKgwqAgeDAsIHgwLCBUUkJJRFJfUFJP Rwo+Pj4gK8KgwqDCoCBjYm56wqDCoMKgIHgwLCAxZgo+Pj4gK8KgwqDCoCBtb3bCoMKgwqAgeDAs ICMoTURDUl9FTDJfRTJUQl9FTDFfT1dOIDw8IE1EQ1JfRUwyX0UyVEJfU0hJRlQpCj4+PiArwqDC oMKgIG9ycsKgwqDCoCB4MiwgeDIsIHgwCj4+PiArLmVuZGlmCj4+PiArCj4+PiArMToKPj4gCj4+ IE5vdGUgdGhhdCB0aGlzIHdpbGwgKGJhZGx5KSBjb25mbGljdCB3aXRoIHRoZSBsYXRlLVZIRSBw YXRjaGVzWzFdLAo+PiB3aGVyZSB0aGlzIGNvZGUgcGF0aCBoYXMgYmVlbiByZXdvcmtlZC4KPiAK PiBUaGFua3MgZm9yIHRoZSBoZWFkcyB1cC4gV2Ugd2lsbCBuZWVkIHRvIHNlZSBob3cgdGhpbmdz IGdldCBtZXJnZWQuCj4gSWRlYWxseSB0aGlzIHBhdGNoIGFuZCB0aGUgcHJldmlvdXMgb25lIChU UkJFIGRlZmluaXRpb25zIGNvdWxkIGdvCj4gdmlhIHRoZSBhcm02NCB0cmVlIC8ga3ZtIHRyZWUp LCBpbiB3aGljaCBjYXNlIHdlIGNvdWxkIHJlYmFzZSB0aGVzZQo+IHR3byBwYXRjaGVzIG9uIHRo ZSByZXNwZWN0aXZlIHRyZWUuCgpJIHRoaW5rIHRoZSBjdXJyZW50IHBsYW4gb2YgYWN0aW9uIGlz IHRvIGdvIHZpYSB0aGUgYXJtNjQgdHJlZSwKZ2l2ZW4gdGhhdCB0aGVyZSBpcyBub3RoaW5nIHJl YWxseSBLVk0gc3BlY2lmaWMgdGhlcmUuIEknbGwgcmVzcGluCnRoZSBzZXJpZXMgb25lIGxhc3Qg KGhvcGVmdWxseSEpIHRpbWUgb24gTW9uZGF5LiBMZXQgbWUga25vdyBpZgp5b3UgbmVlZCBhIGhh bmQgd2l0aCB0aGUgcmViYXNpbmcuCgpUaGFua3MsCgogICAgICAgICBNLgotLSAKSmF6eiBpcyBu b3QgZGVhZC4gSXQganVzdCBzbWVsbHMgZnVubnkuLi4KCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0Cmxp bnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK