From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752326AbdGDHiP (ORCPT ); Tue, 4 Jul 2017 03:38:15 -0400 Received: from lucky1.263xmail.com ([211.157.147.134]:58409 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751954AbdGDHiN (ORCPT ); Tue, 4 Jul 2017 03:38:13 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: david.wu@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: david.wu@rock-chips.com X-UNIQUE-TAG: <74939f854751cb6fab82ca80bb02e811> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328 To: Boris Brezillon Cc: thierry.reding@gmail.com, heiko@sntech.de, robh+dt@kernel.org, catalin.marinas@arm.com, briannorris@chromium.org, dianders@chromium.org, mark.rutland@arm.com, huangtao@rock-chips.com, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1498739271-27431-1-git-send-email-david.wu@rock-chips.com> <1498739271-27431-5-git-send-email-david.wu@rock-chips.com> <20170703203957.03f3d1db@bbrezillon> From: "David.Wu" Message-ID: <05cccb3d-2b35-1878-6173-9a96adef17ba@rock-chips.com> Date: Tue, 4 Jul 2017 15:37:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170703203957.03f3d1db@bbrezillon> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, ÔÚ 2017/7/4 2:39, Boris Brezillon дµÀ: > Yet another customization. Don't you think we can extract common parts, > expose them as helpers and then have 3 different pwm_ops (with 3 > different ->apply() implementation), one for each IP revision. Sounds reasonable.I will try to implement 3 different apply(). From mboxrd@z Thu Jan 1 00:00:00 1970 From: david.wu@rock-chips.com (David.Wu) Date: Tue, 4 Jul 2017 15:37:54 +0800 Subject: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328 In-Reply-To: <20170703203957.03f3d1db@bbrezillon> References: <1498739271-27431-1-git-send-email-david.wu@rock-chips.com> <1498739271-27431-5-git-send-email-david.wu@rock-chips.com> <20170703203957.03f3d1db@bbrezillon> Message-ID: <05cccb3d-2b35-1878-6173-9a96adef17ba@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Boris, ? 2017/7/4 2:39, Boris Brezillon ??: > Yet another customization. Don't you think we can extract common parts, > expose them as helpers and then have 3 different pwm_ops (with 3 > different ->apply() implementation), one for each IP revision. Sounds reasonable.I will try to implement 3 different apply().