From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A975C433F5 for ; Thu, 3 Mar 2022 21:18:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 55A4483D76; Thu, 3 Mar 2022 22:16:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FypSjM1+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AA1EC83CA3; Thu, 3 Mar 2022 22:16:34 +0100 (CET) Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 19FFD83D6E for ; Thu, 3 Mar 2022 22:16:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=alpernebiyasak@gmail.com Received: by mail-ej1-x630.google.com with SMTP id gb39so13378877ejc.1 for ; Thu, 03 Mar 2022 13:16:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=vhUOagBlJdd3ju57BdLu+S1NoTiS+N+RDD428yYcrYY=; b=FypSjM1+L19YbsWu6eOEYQlgKwSPyTnm8ZGmSPGeDuun/KQZjWPyeBI8DboTAd/n49 3KV24vqn0dpOB2Rn62ayGBe6B5pu81whbKAE9FyMXkoaDNR3EsY7Ks2+TgmGT6+ZY0Cz fBeJWjVDorVd4Q87P7EjuU+gcl6cNBQoGL0pA5qMSW4OFESnUkd6ffZHxmsILIVWnmJh Ycd8d5GXJZgFgG6L+g9EIbfFwW1QFGE72V/SGjZ4hgpnd1oVCVZhAmFviIFMjbxwCEpO ZLuUHgMPSiPf1acvittfdHJKfVc9myi91b0JJ1CSKBqhmh5X8jds8Zr1xJvxtPfGozvl x5hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=vhUOagBlJdd3ju57BdLu+S1NoTiS+N+RDD428yYcrYY=; b=otmOlnO7zEZNzeKaXH4lC/MkxcS+PG77UobVQ9WnUBkCdaPGrkzLlyDpoyBKC9nlUq M7TmNpJLKYI0DsKbjv5l+CdM0wLjQVZekSQs4lg8hRNm8Ub7Ug7UVMz3jtdlqlgfGp7x sczCEoag26/uV4/4QuiKf8siG/HIltTECB9ELoK9lWRdJOyxowPnTXYHFTg6y0kqfcyf TwCOCFBGdRHquou/m1vkn8uDp7353U4jttnhCah6fURS7aBy6M0ovVVBzLjLMcTCkGdY PgYiGtWIE6y4pvrzdBGGLnG2f8xB4OpYm6l1cCFmui8Oj3GOJoVYyemmDGG/1aCkd2cV MX0w== X-Gm-Message-State: AOAM531fOGtQU55UUiQK8zgsAtzPPe5wWM65OhXvstEmFevtFJ0hZO6F iVp/dGdsYEttH7qxuqR5Z78= X-Google-Smtp-Source: ABdhPJyvZ1I8XcpJsmbHgEgjBUtw/BvSspqhU4esmjOGB/OUq5uvBPu0POc3JvRflhrkUSD1qWTPYg== X-Received: by 2002:a17:907:7242:b0:6da:b561:d523 with SMTP id ds2-20020a170907724200b006dab561d523mr322811ejc.118.1646342189736; Thu, 03 Mar 2022 13:16:29 -0800 (PST) Received: from [192.168.0.74] ([178.233.26.119]) by smtp.gmail.com with ESMTPSA id fb21-20020a1709073a1500b006da6eefdf11sm1067758ejc.49.2022.03.03.13.16.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 13:16:29 -0800 (PST) Message-ID: <05d58679-caef-d498-6a37-50f98d64d9ae@gmail.com> Date: Fri, 4 Mar 2022 00:10:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 From: Alper Nebi Yasak Subject: Re: [PATCH v2 15/25] binman: Read the fit entries only once To: Simon Glass Cc: Ivan Mikhaylov , Tom Rini , Philippe Reynes , huang lin , Jeffy Chen , Kever Yang , U-Boot Mailing List References: <20220223230040.159317-1-sjg@chromium.org> <20220223230040.159317-16-sjg@chromium.org> Content-Language: en-US In-Reply-To: <20220223230040.159317-16-sjg@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 24/02/2022 02:00, Simon Glass wrote: > At present the entries are read twice, once by the entry_Section class > and once by the FIT implementation. This is harmless but can be confusing > when debugging. Fix it. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > tools/binman/etype/fit.py | 1 - > 1 file changed, 1 deletion(-) This is actually necessary so that we can use 'self' as the section in Entry.Create(self, ...) when creating /image/* sections, which requires some section-related attributes set by super().ReadNode(). It was one of the things I was planning to fix as well, thanks! Reviewed-by: Alper Nebi Yasak > diff --git a/tools/binman/etype/fit.py b/tools/binman/etype/fit.py > index 2b82955226..7b0c94dfee 100644 > --- a/tools/binman/etype/fit.py > +++ b/tools/binman/etype/fit.py > @@ -185,7 +185,6 @@ class Entry_fit(Entry_section): > self.mkimage = None > > def ReadNode(self): > - self.ReadEntries() > super().ReadNode() The entire function can be removed, but I think some stuff from __init__() actually belongs here so I'm fine with keeping it. > > def _get_operation(self, subnode):