From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752851AbcIUGfJ (ORCPT ); Wed, 21 Sep 2016 02:35:09 -0400 Received: from out0-156.mail.aliyun.com ([140.205.0.156]:32869 "EHLO out0-156.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751736AbcIUGfI (ORCPT ); Wed, 21 Sep 2016 02:35:08 -0400 X-Greylist: delayed 316 seconds by postgrey-1.27 at vger.kernel.org; Wed, 21 Sep 2016 02:35:07 EDT X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R901e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e02c03300;MF=hillf.zj@alibaba-inc.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---.7-8.Kt0_1474439365; Reply-To: "Hillf Danton" From: "Hillf Danton" To: "'Gerald Schaefer'" , "'Andrew Morton'" , "'Naoya Horiguchi'" Cc: , , "'Michal Hocko'" , "'Kirill A . Shutemov'" , "'Vlastimil Babka'" , "'Mike Kravetz'" , "'Aneesh Kumar K . V'" , "'Martin Schwidefsky'" , "'Heiko Carstens'" References: <20160920155354.54403-1-gerald.schaefer@de.ibm.com> <20160920155354.54403-2-gerald.schaefer@de.ibm.com> In-Reply-To: <20160920155354.54403-2-gerald.schaefer@de.ibm.com> Subject: Re: [PATCH 1/1] mm/hugetlb: fix memory offline with hugepage size > memory block size Date: Wed, 21 Sep 2016 14:29:25 +0800 Message-ID: <05d701d213d1$7fb70880$7f251980$@alibaba-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQGdgOGGb3gdWTxMo8wXsJcMytekfQI4fuo9oNrcOwA= Content-Language: zh-cn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -1466,9 +1468,9 @@ void dissolve_free_huge_pages(unsigned long start_pfn, unsigned long end_pfn) > if (!hugepages_supported()) > return; > > - VM_BUG_ON(!IS_ALIGNED(start_pfn, 1 << minimum_order)); Then the relevant comment has to be updated. Hillf > for (pfn = start_pfn; pfn < end_pfn; pfn += 1 << minimum_order) > - dissolve_free_huge_page(pfn_to_page(pfn)); > + if (PageHuge(pfn_to_page(pfn))) > + dissolve_free_huge_page(pfn_to_page(pfn)); > } > > /* > -- > 2.8.4 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f200.google.com (mail-io0-f200.google.com [209.85.223.200]) by kanga.kvack.org (Postfix) with ESMTP id 398146B025E for ; Wed, 21 Sep 2016 02:29:43 -0400 (EDT) Received: by mail-io0-f200.google.com with SMTP id q92so114221387ioi.3 for ; Tue, 20 Sep 2016 23:29:43 -0700 (PDT) Received: from out4439.biz.mail.alibaba.com (out4439.biz.mail.alibaba.com. [47.88.44.39]) by mx.google.com with ESMTP id m125si40133175iof.41.2016.09.20.23.29.41 for ; Tue, 20 Sep 2016 23:29:42 -0700 (PDT) Reply-To: "Hillf Danton" From: "Hillf Danton" References: <20160920155354.54403-1-gerald.schaefer@de.ibm.com> <20160920155354.54403-2-gerald.schaefer@de.ibm.com> In-Reply-To: <20160920155354.54403-2-gerald.schaefer@de.ibm.com> Subject: Re: [PATCH 1/1] mm/hugetlb: fix memory offline with hugepage size > memory block size Date: Wed, 21 Sep 2016 14:29:25 +0800 Message-ID: <05d701d213d1$7fb70880$7f251980$@alibaba-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Language: zh-cn Sender: owner-linux-mm@kvack.org List-ID: To: 'Gerald Schaefer' , 'Andrew Morton' , 'Naoya Horiguchi' Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, 'Michal Hocko' , "'Kirill A . Shutemov'" , 'Vlastimil Babka' , 'Mike Kravetz' , "'Aneesh Kumar K . V'" , 'Martin Schwidefsky' , 'Heiko Carstens' > @@ -1466,9 +1468,9 @@ void dissolve_free_huge_pages(unsigned long start_pfn, unsigned long end_pfn) > if (!hugepages_supported()) > return; > > - VM_BUG_ON(!IS_ALIGNED(start_pfn, 1 << minimum_order)); Then the relevant comment has to be updated. Hillf > for (pfn = start_pfn; pfn < end_pfn; pfn += 1 << minimum_order) > - dissolve_free_huge_page(pfn_to_page(pfn)); > + if (PageHuge(pfn_to_page(pfn))) > + dissolve_free_huge_page(pfn_to_page(pfn)); > } > > /* > -- > 2.8.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org