Re: [meta-virtualization][PATCH 2/2] layer.conf: use go 1.12 version

["Chen Qi" <Qi.Chen@windriver.com>]

On 12/07/2019 02:58 AM, Bruce Ashfield wrote:
> On Fri, Dec 6, 2019 at 9:26 AM Bruce Ashfield via
> Lists.Yoctoproject.Org
> <bruce.ashfield=gmail.com@lists.yoctoproject.org> wrote:
>> On Thu, Dec 5, 2019 at 8:15 PM Chen Qi <Qi.Chen@windriver.com> wrote:
>>> kubernetes could not be built correctly with go 1.13.
>>> Use 1.12 version in layer.conf.
>> We unfortunately can't set the version of GO like this, since it would
>> impact someone that simply includes meta-virt in their layers.
>>
>> I see two options for this:
>>
>>   - create a k8s distro feature and only set the go version when it is
>> enabled .. or we re-use the virtualization distro feature (which is a
>> better idea)
>>   - put the preferred GO version into the meta-virt .inc file that is
>> included when virtualization is in distro features
>>
>> Although, I recall someone saying that the .inc wasn't working
>> properly and isn't actually triggering .. I found the email from Mark
>> hatle that describes the problem. If you check the list archives for
>> the subject:  "[meta-virtualization] conf/layer.conf is broken".
>> You'll find a description of the problem.
>>
>> The fix for that, is to make the .inc work like the one in meta-cube:
>> https://github.com/WindRiver-OpenSourceLabs/meta-overc/blob/wr-10.19-20190121/meta-cube/conf/layer.conf
>>
>> The .inc is the best solution, and this is a good opportunity to fix
>> it (it hasn't been working correctly for some time now). I'll try and
>> make those changes today, and follow up later with the results.
> FYI: I fixed the conditional include and pushed the commit to master
> [conf: fix meta-virt version / config include], so we can now use the
> .inc to set the go version.
>
> Bruce

Thanks! I'll send out V2.

Regards,
Chen Qi

>> Bruce
>>
>>
>>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>>> ---
>>>   conf/layer.conf | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/conf/layer.conf b/conf/layer.conf
>>> index dfca6da..2d008bb 100644
>>> --- a/conf/layer.conf
>>> +++ b/conf/layer.conf
>>> @@ -41,3 +41,7 @@ PREFERRED_PROVIDER_virtual/docker ?= "docker-ce"
>>>   INHERIT += "sanity-meta-virt"
>>>
>>>   require ${@bb.utils.contains('DISTRO_FEATURES', 'virtualization', 'meta-virt-default-versions.inc', '', d)}
>>> +
>>> +# Use go 1.12 to avoid k8s build failure.
>>> +# Remove this after https://github.com/kubernetes/kubernetes/issues/82531 is resolved and k8s is updated to a working version.
>>> +GOVERSION = "1.12%"
>>> --
>>> 2.17.1
>>>
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>> Links: You receive all messages sent to this group.
>>>
>>> View/Reply Online (#4829): https://lists.yoctoproject.org/g/meta-virtualization/message/4829
>>> Mute This Topic: https://lists.yoctoproject.org/mt/67394161/1050810
>>> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
>>> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub  [bruce.ashfield@gmail.com]
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>
>>
>> --
>> - Thou shalt not follow the NULL pointer, for chaos and madness await
>> thee at its end
>> - "Use the force Harry" - Gandalf, Star Trek II
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>>
>> View/Reply Online (#4831): https://lists.yoctoproject.org/g/meta-virtualization/message/4831
>> Mute This Topic: https://lists.yoctoproject.org/mt/67394161/1050810
>> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
>> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub  [bruce.ashfield@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>
>