From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96488C433EF for ; Wed, 2 Mar 2022 16:06:19 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 82F181685; Wed, 2 Mar 2022 17:05:27 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 82F181685 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646237177; bh=mROq2oKbPLLqLkHfwYSfYa/UVZGqxz+JSCJ76WRP+ic=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ZYTBpccIHSsz3w+H/UOe2jTTb4K3cIk0Twn46oy/Ch6MLQP0GNN3Et+VzUyBP45Xi QfyPKqEVl8clHZZpZWDYsJmp4s2YlVhWljQdGljsg3JYYzFmddZ4gx2VmebN6L+h48 tzqBj6iyGOOiVNZ22rR3OnQbPkzKV6tReY8bS0l4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1E5A4F80171; Wed, 2 Mar 2022 17:05:27 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1A59DF801D5; Wed, 2 Mar 2022 17:05:25 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 70A93F80154 for ; Wed, 2 Mar 2022 17:05:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 70A93F80154 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="UPqGmSSr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646237119; x=1677773119; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=mROq2oKbPLLqLkHfwYSfYa/UVZGqxz+JSCJ76WRP+ic=; b=UPqGmSSr6WpAn275Leiak/rZfe+qBwTqq125sF9rKkCBJaP/VWGBCNHQ uSzoEmR/UbO0GNJq9QH1T6PV0Le5pb3GJQ1yuz+mxyCmTUi0Gv1tsKH9U e8NoY9B6PhaMq5iBXY9gPu+HIReU3f1LFZnS5fL+gqP2GYK6abe/rDLeO 84GrZ9cAYCnCCkkmQU0DB1kRcpOmm9WnlQNuqhQhV0nLkz2mrbVEE4oz7 tQP40cK8SMx03jdwRub95Cb5f44Yro7su+Ypj/HNTDmzGrJJBMNbtvj9c Z9xDJeFIHczhgEd4JrGtZ+bIjNn30lsM74m/TgGrxNWXxfVSGmQYZilLm g==; X-IronPort-AV: E=McAfee;i="6200,9189,10274"; a="314155700" X-IronPort-AV: E=Sophos;i="5.90,149,1643702400"; d="scan'208";a="314155700" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2022 08:05:14 -0800 X-IronPort-AV: E=Sophos;i="5.90,149,1643702400"; d="scan'208";a="535440399" Received: from aslawinx-mobl.ger.corp.intel.com (HELO [10.99.241.26]) ([10.99.241.26]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2022 08:05:07 -0800 Message-ID: <05ee9a2c-e7dc-1f75-da7c-39b30464bd08@linux.intel.com> Date: Wed, 2 Mar 2022 17:05:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 7/8] ASoC: Intel: sof_ssp_amp: rename driver and support cs35l41 amplifier Content-Language: en-US To: Pierre-Louis Bossart , alsa-devel@alsa-project.org References: <20220301194903.60859-1-pierre-louis.bossart@linux.intel.com> <20220301194903.60859-8-pierre-louis.bossart@linux.intel.com> <33d27810-a023-f2f7-5218-e406fc7c13e5@linux.intel.com> From: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= In-Reply-To: <33d27810-a023-f2f7-5218-e406fc7c13e5@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: tiwai@suse.de, broonie@kernel.org, Bard Liao , Brent Lu X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 3/2/2022 4:50 PM, Pierre-Louis Bossart wrote: > > > On 3/2/22 8:56 AM, Amadeusz Sławiński wrote: >> On 3/1/2022 8:49 PM, Pierre-Louis Bossart wrote: >>> From: Brent Lu >>> >>> Add support of CS35L41 amplifier to the machine driver, as well as >>> the support of HDMI playback and BT offload DAI Link. >>> >>> Rename the driver to a generic name to support different amplifiers >>> from different vendors. >>> >>> Reviewed-by: Bard Liao >>> Signed-off-by: Brent Lu >>> Signed-off-by: Pierre-Louis Bossart >>> >>> --- >> >> Eh... rename should happen in separate patch, as there seems to be >> some changes done to the file and it is quite hard to review it, when >> whole file is in diff due to being moved. > > that was a conscious decision on my side to keep the patches as is, > first add the initial contribution for the rt1308 amp from our embedded > Linux team, and show how it was extended to support another amplifier > for Chrome. > > Indeed it leads to a bit of a tick-tock patch with the rename but it's > not that bad, is it? The alternative would lead to a much bigger patch > if I squash the whole thing. I think you've misunderstood me, I'm not talking about squashing, but splitting patch 7 into two separate patches - one doing rename and another adding/changing things. I was looking at: + links = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link) * + sof_ssp_amp_card.num_links, GFP_KERNEL); + cpus = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link_component) * + sof_ssp_amp_card.num_links, GFP_KERNEL); and wondered where sof_ssp_amp_card.num_links comes from, and it only shows up 4 times in removed file, but 6 times in added one, which tells me that things changed, but it is hard to see what, when the diff shows whole files being moved instead of things that changed.