From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D272C4361A for ; Tue, 26 Jan 2021 19:22:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 541F322228 for ; Tue, 26 Jan 2021 19:22:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727859AbhAZFqx (ORCPT ); Tue, 26 Jan 2021 00:46:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728948AbhAYQB1 (ORCPT ); Mon, 25 Jan 2021 11:01:27 -0500 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E49CAC06174A; Mon, 25 Jan 2021 08:00:46 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id l12so13361965ljc.3; Mon, 25 Jan 2021 08:00:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JOoMcr6gXPOH11DZhT/CQoFTEMtxIzC/wwQvt5fOQcU=; b=s9ZsLNOMX3/ADc0QvUSgm9Yg1DqXKjdKMs4QAHCWpedsj9oiNKbnVgFXUsLEZ7bCN6 PuK1JwHj/WUsJsEg8X6qiQw/0rB34XxNv74C+j7C9sVEYA0f1B3WiPGgvhoeZA+VtHdE y4bS90Sd/n/Wry31xnp0HN+INJtB7ARvtoP/ECQru3/eADWj2Y7N6ib55ByZ/ugmMvah MrUZhywSbV15i+xANr0NFQptn7RtEugQtZVCbY8HcHjCHAuD4SoFNJklB24Y1jBI8BkT ViLeIB5gGBJFTnE+o6fsMFlc651CMnaaJ6p9jEdQwUyxy0vudynIIYYJIiv7KNBrKlVP 9avQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JOoMcr6gXPOH11DZhT/CQoFTEMtxIzC/wwQvt5fOQcU=; b=NqhywZt3sjk79lUEiFTpgza4vQX5Y5PL0v6bRP6NN4SaieKcJ8fPmg46gu3u4zcBAO eKJlH+lwa6tHGFeuDB/CaiyngHh9DaZlcgKh/29L6YotWZ/d4fOKU1TCr0or1IIuSjQm v2UA/KPtJSvC2fpI3PLRrHM3WGNiZhoC09DgDgM6xYt00CHxqfL2Qj8mb32Gg2qb+Scd 5tFhDi35LK740nWr0qCcKXSc2IvE5HRZ+VPI7vzTsiHHlSym6Au5bNu6HEbfbt9dFeyq ZBaQW/42n+jJ8oHfCPn2J9yo/SU0obuIgK0gbVwj95vkgqvZRZGgqZUfWPHOT43yjqqj 2muw== X-Gm-Message-State: AOAM532G6JsF2PqtuLLBEhVd5ZSNqh3Hl5xUMkQcaHsK1x7IcgwrMFZm 6zvSWRXdAbI5jw7wT/uRwEj/VGAKfvw= X-Google-Smtp-Source: ABdhPJwuUl9XnI7wh5L2vZA9lC5YKKyuJ3rqG7nMeiXnigRzAbpYaNeFI51XmmRdCEu4EEaYw8iHug== X-Received: by 2002:a2e:9bce:: with SMTP id w14mr510036ljj.120.1611590444956; Mon, 25 Jan 2021 08:00:44 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id r21sm831903ljk.1.2021.01.25.08.00.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Jan 2021 08:00:44 -0800 (PST) Subject: Re: [PATCH 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp() To: Viresh Kumar Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Thierry Reding , Jonathan Hunter , linux-pm@vger.kernel.org, Vincent Guittot , Rafael Wysocki , Stephen Boyd , Nishanth Menon , Sibi Sankar , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org References: <3345fd49f7987d022f4f61edb6c44f230f7354c4.1611227342.git.viresh.kumar@linaro.org> <71451eb2-46b2-1ea0-efcc-0811568159a4@gmail.com> <20210122062659.qss3hef4kltfgciu@vireshk-i7> <20210125031402.aqiwhlsozvakehxd@vireshk-i7> From: Dmitry Osipenko Message-ID: <05eee5d4-9c89-e3fd-a716-efd44191231a@gmail.com> Date: Mon, 25 Jan 2021 19:00:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20210125031402.aqiwhlsozvakehxd@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 25.01.2021 06:14, Viresh Kumar пишет: > On 22-01-21, 18:28, Dmitry Osipenko wrote: >> Either way will work, but maybe keeping the dev_pm_opp_set_bw() is a bit >> more straightforward variant for now since it will avoid the code's >> changes and it's probably a bit more obvious variant for the OPP users. > > The problem is it creates unnecessary paths which we need to support. For > example, in case of bandwidth itself we may want to update regulator/pm > domain/required OPPs and this should all be done for everyone. I really do not > want to keep separate paths for such stuff, it makes it hard to maintain.. > Maybe we could add dev_pm_opp_of_add_table_without_clock(), at least that should be a bit nicer from a drivers perspective than having to care about dev_pm_opp_clear_clk(), IMO. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B887CC433DB for ; Mon, 25 Jan 2021 16:02:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77CE8221EB for ; Mon, 25 Jan 2021 16:02:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77CE8221EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aHwGWFqcIRx8RyJk2deTnEk4qNDLXu1PLCqIMVW6ZD8=; b=ac6ihZzYpB7Zd1I9CaPMj6/UA SZUWm6sJLAVAa0eJdvVM8xGOmv1t0L9Ulzo11llSSdP8RnKCO4qriOrxoq6dVih3rQBwTHKm/C84p KpV/QciYNpzpwiI82QpsWZVyStcD3wC4nyXhBK9RcfFZ6ld9aBFxJ8x0Ep/rqeraaWnHp3uIQt5Jk tH0ZPMHda0SqmkGfVyvjrVKuG1MHV9Gp6DQqXeuEWDDvdn2H/fF56JmDuGBusxauUhXjOWdw7PF5c U8kHYbMplzQW7Hf1X9hHrIviEJ+br2mkt20yr2oSmIAxo9e32IeIGA1UYCdadjjSPiXbxN0TMjxri 5EbAetAfg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l44IN-0007m6-5D; Mon, 25 Jan 2021 16:00:51 +0000 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l44IL-0007la-DW for linux-arm-kernel@lists.infradead.org; Mon, 25 Jan 2021 16:00:50 +0000 Received: by mail-lj1-x230.google.com with SMTP id f2so10686284ljp.11 for ; Mon, 25 Jan 2021 08:00:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JOoMcr6gXPOH11DZhT/CQoFTEMtxIzC/wwQvt5fOQcU=; b=s9ZsLNOMX3/ADc0QvUSgm9Yg1DqXKjdKMs4QAHCWpedsj9oiNKbnVgFXUsLEZ7bCN6 PuK1JwHj/WUsJsEg8X6qiQw/0rB34XxNv74C+j7C9sVEYA0f1B3WiPGgvhoeZA+VtHdE y4bS90Sd/n/Wry31xnp0HN+INJtB7ARvtoP/ECQru3/eADWj2Y7N6ib55ByZ/ugmMvah MrUZhywSbV15i+xANr0NFQptn7RtEugQtZVCbY8HcHjCHAuD4SoFNJklB24Y1jBI8BkT ViLeIB5gGBJFTnE+o6fsMFlc651CMnaaJ6p9jEdQwUyxy0vudynIIYYJIiv7KNBrKlVP 9avQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JOoMcr6gXPOH11DZhT/CQoFTEMtxIzC/wwQvt5fOQcU=; b=aCqVePyWtJaXMVX2UtEu//GT44bhmfsCY/Imuekmw0gv3AQ5oBdqgD/9TwNgvFWSoR 8gSbGRsKhCXhFiPVaqiRg2fGo2nNdA4PvTQiEm+1P9JHsO3sDCdCF06B/G11/tAUX8ri jR1NaGAAwtmuMX+UknUjSL0L6jhcZuP33O2PYRSCEunxyn688AW+7aOiZj2piQkEoUXr z7V8t1KPJWS54+MhYyAWuyFjJvnBLPXc8NJISjT+Smi2DsX1wqk0iGADVVD49fBQd0PQ JU9W8kOWy/Hw5A+KzZafiDGDdeB4sQVU/EnAw3mwhNrDyEjqlMILO3Z36JQmxJxpYfHX 2dnQ== X-Gm-Message-State: AOAM5320jmI5aTcirgjdSEx0ismSH+K2nVfI+Z+iEmLaxfoQHOGSvInl obsi3KIircI+C9AtAopPzNY= X-Google-Smtp-Source: ABdhPJwuUl9XnI7wh5L2vZA9lC5YKKyuJ3rqG7nMeiXnigRzAbpYaNeFI51XmmRdCEu4EEaYw8iHug== X-Received: by 2002:a2e:9bce:: with SMTP id w14mr510036ljj.120.1611590444956; Mon, 25 Jan 2021 08:00:44 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id r21sm831903ljk.1.2021.01.25.08.00.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Jan 2021 08:00:44 -0800 (PST) Subject: Re: [PATCH 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp() To: Viresh Kumar References: <3345fd49f7987d022f4f61edb6c44f230f7354c4.1611227342.git.viresh.kumar@linaro.org> <71451eb2-46b2-1ea0-efcc-0811568159a4@gmail.com> <20210122062659.qss3hef4kltfgciu@vireshk-i7> <20210125031402.aqiwhlsozvakehxd@vireshk-i7> From: Dmitry Osipenko Message-ID: <05eee5d4-9c89-e3fd-a716-efd44191231a@gmail.com> Date: Mon, 25 Jan 2021 19:00:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20210125031402.aqiwhlsozvakehxd@vireshk-i7> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210125_110049_467193_A11B89AD X-CRM114-Status: GOOD ( 15.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Vincent Guittot , linux-pm@vger.kernel.org, Stephen Boyd , Rafael Wysocki , linux-kernel@vger.kernel.org, Jonathan Hunter , Chanwoo Choi , Kyungmin Park , MyungJoo Ham , Thierry Reding , Sibi Sankar , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org MjUuMDEuMjAyMSAwNjoxNCwgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gT24gMjItMDEtMjEs IDE4OjI4LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4+IEVpdGhlciB3YXkgd2lsbCB3b3JrLCBi dXQgbWF5YmUga2VlcGluZyB0aGUgZGV2X3BtX29wcF9zZXRfYncoKSBpcyBhIGJpdAo+PiBtb3Jl IHN0cmFpZ2h0Zm9yd2FyZCB2YXJpYW50IGZvciBub3cgc2luY2UgaXQgd2lsbCBhdm9pZCB0aGUg Y29kZSdzCj4+IGNoYW5nZXMgYW5kIGl0J3MgcHJvYmFibHkgYSBiaXQgbW9yZSBvYnZpb3VzIHZh cmlhbnQgZm9yIHRoZSBPUFAgdXNlcnMuCj4gCj4gVGhlIHByb2JsZW0gaXMgaXQgY3JlYXRlcyB1 bm5lY2Vzc2FyeSBwYXRocyB3aGljaCB3ZSBuZWVkIHRvIHN1cHBvcnQuIEZvcgo+IGV4YW1wbGUs IGluIGNhc2Ugb2YgYmFuZHdpZHRoIGl0c2VsZiB3ZSBtYXkgd2FudCB0byB1cGRhdGUgcmVndWxh dG9yL3BtCj4gZG9tYWluL3JlcXVpcmVkIE9QUHMgYW5kIHRoaXMgc2hvdWxkIGFsbCBiZSBkb25l IGZvciBldmVyeW9uZS4gSSByZWFsbHkgZG8gbm90Cj4gd2FudCB0byBrZWVwIHNlcGFyYXRlIHBh dGhzIGZvciBzdWNoIHN0dWZmLCBpdCBtYWtlcyBpdCBoYXJkIHRvIG1haW50YWluLi4KPiAKCk1h eWJlIHdlIGNvdWxkIGFkZCBkZXZfcG1fb3BwX29mX2FkZF90YWJsZV93aXRob3V0X2Nsb2NrKCks IGF0IGxlYXN0CnRoYXQgc2hvdWxkIGJlIGEgYml0IG5pY2VyIGZyb20gYSBkcml2ZXJzIHBlcnNw ZWN0aXZlIHRoYW4gaGF2aW5nIHRvCmNhcmUgYWJvdXQgZGV2X3BtX29wcF9jbGVhcl9jbGsoKSwg SU1PLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo=