From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claudiu.Beznea at microchip.com Date: Tue, 4 Aug 2020 15:25:34 +0000 Subject: [PATCH 01/22] clk: check hw and hw->dev before dereference it In-Reply-To: References: <1596034301-5428-1-git-send-email-claudiu.beznea@microchip.com> <1596034301-5428-2-git-send-email-claudiu.beznea@microchip.com> <178382f5-6dca-e6b5-dac2-1b0da57b4031@microchip.com> Message-ID: <05ef4e85-367d-9426-e5a6-3b4f8dfad687@microchip.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On 04.08.2020 18:08, Simon Glass wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Hi Claudiu, > > On Tue, 4 Aug 2020 at 01:19, wrote: >> >> >> >> On 04.08.2020 05:00, Simon Glass wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>> >>> Hi Claudiu, >>> >>> On Wed, 29 Jul 2020 at 08:51, Claudiu Beznea >>> wrote: >>>> >>>> Check hw and hw->dev before dereference it. >>>> >>>> Signed-off-by: Claudiu Beznea >>>> --- >>>> drivers/clk/clk.c | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>> >>> Why is this needed? It adds to code size and these situations should >>> not occur. Perhaps use assert()? >> >> In my debugging, investigating the issues that patches 03/22, 04/22, 06/22 >> try to address, I reached also this function and checked these pointers. In >> the end the issue was not related to them but I though it might be useful >> to keep these in a patch. I will remove it in the next version. > > IMO we should use assert() to check invariants and catch basic > programming errors. But production testing should make sure that the > software basically works. > > Of course it is nice to have these checks, but they add to code size > which is always a concern. So I think we should rely on assert() to > catch the errors during development, so we are not wasting code > checking for things that we know cannot happen. OK, I'll switch to assert(). Thank you, Claudiu Beznea > > Regards, > Simon >