From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3B63C433EF for ; Mon, 28 Mar 2022 21:00:23 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AFE0283FDA; Mon, 28 Mar 2022 22:58:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=softathome.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com header.b="JfG1khEK"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D14A783F8D; Mon, 28 Mar 2022 22:58:57 +0200 (CEST) Received: from FRA01-PR2-obe.outbound.protection.outlook.com (mail-pr2fra01on0610.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e18::610]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8C83B83FDA for ; Mon, 28 Mar 2022 22:58:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=softathome.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=philippe.reynes@softathome.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZE5k2NzzogzzQyXSsD1rP+LEihqBxXE1/Bp4Yw0Q3gRxJnCWiP9bIQYnKhYOJS2ZThYQCp5VxBnnRplrJsp5ShG4wBJw2feB2EvcJkANGAbt/rYDQwra13TZWNrjHLob6m2+pzywMY+9XW+IkXJ59yRu6ZZ6p5cq1Rza5BjXkvmMBKS1OTymSj2ygqWnza9ZX/3E9A4HKAWBvtwRV6g85VDfRYd3mcl5DlcgvSHRfhmshn4ezqyHRRWFtH5lQYENkz6rBB2xFBuVvgumW0tQru7l+l3T8+pY2UZ6SG6stPU+ATUhnPWfLxIUtZKxrUvCSDun/6bWopZ+hOn3al5JKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U408Z8oLXkLEvs8K3MgIpremZYsrhQ1woCxCRd7Tqr4=; b=HqfeGp4i3ToEb7ZgRn5p6oy2S+bjM5ESmVulCMS2XDv57u4z9sYiQAcJfthxCt0ciWvNl213o+5jwKT5NPlfJNa5JQ9M75BhC+DcI0XrIHL1u6L4lpwbhY7JxE5LFxXVNFZ7UXu9XK3Y6xYFxJsLkl7JmGwOkbIWRi/Dj/sLy38/AsyDTqDccNyZTp9hE4Y6rIRL3aT2BK3TCadUA6NoUJZlRHPY7AGzdNHgwwsitbGpiLab8myRsiDI98WQFCA+dOxysM6S4A9bVm6oxhVWG2TI6JTeielyunNgyNDhoCZWqTThFoeFHb8DWIt980T2gH4lZGBJQzj3aNeDblFAQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=softathome.com; dmarc=pass action=none header.from=softathome.com; dkim=pass header.d=softathome.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=softathome1.onmicrosoft.com; s=selector1-softathome1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U408Z8oLXkLEvs8K3MgIpremZYsrhQ1woCxCRd7Tqr4=; b=JfG1khEKIM84l2utCtK/9IDpf14S9a8Gll4jJu1NHgEoMJKb6t1bzgEzm5laptZ1s5z5Ba6bUOlJVUxS/2f6fwn1pM0WUCn2OkAvQ9xxnBYUJ1+r13w47v/LcxToBb2FyGUn9V3XtPtquhwMMcJaIecsoR7x/cBSqzQaxjNxQ3NMkIgo3ek2vPnnNCt0ko7JHEo6hzsb4yQ3Ep6f4/HOevgXyRvfit90COs/48ilr6JJRWyw2Rv194kCO5bo5HNsijlQrDPbkxhKIhDcEPmzILjCMRyrk9PMAV40qKr7DskuNFozkQ+zNVlvXQ/1VGzhCIvgmLOM924uGOcm2GsymA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=softathome.com; Received: from PR0P264MB2741.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1d0::9) by PR0P264MB1819.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:16f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.17; Mon, 28 Mar 2022 20:58:53 +0000 Received: from PR0P264MB2741.FRAP264.PROD.OUTLOOK.COM ([fe80::edd3:b6cf:44f6:7de5]) by PR0P264MB2741.FRAP264.PROD.OUTLOOK.COM ([fe80::edd3:b6cf:44f6:7de5%5]) with mapi id 15.20.5102.023; Mon, 28 Mar 2022 20:58:53 +0000 Message-ID: <05f0430b-847f-d2c7-6c78-6dd454a62666@softathome.com> Date: Mon, 28 Mar 2022 22:58:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v7 14/16] test: py: vboot: add test for global image signature Content-Language: en-US To: Tom Rini Cc: sjg@chromium.org, rasmus.villemoes@prevas.dk, u-boot@lists.denx.de References: <20220314145745.15249-1-philippe.reynes@softathome.com> <20220314145745.15249-15-philippe.reynes@softathome.com> <20220325171150.GZ2226424@bill-the-cat> <140b14a6-89dd-1399-7606-435a69ce1c3a@softathome.com> <20220325230205.GA2284289@bill-the-cat> From: Philippe REYNES In-Reply-To: <20220325230205.GA2284289@bill-the-cat> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PR3P251CA0010.EURP251.PROD.OUTLOOK.COM (2603:10a6:102:b5::17) To PR0P264MB2741.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:1d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b6ae210c-7bf8-4247-d8cf-08da10fdc425 X-MS-TrafficTypeDiagnostic: PR0P264MB1819:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +iesmR7StLBGfeSQCEF3A7jBoMm8DowRKuDpBaCvNOsoWzP7aYHATgjdQ0oMBNK4X81k8ypQOgq+XfVTttdeGtYg3tGZ26NAwCWv3e0Q84T0bghRlKpHEWJxVHprBjmNOg0vZqalljuK4sNrYtRx2jce/5dwiiWkagKPmLUxFjzeywg6EqJvNm/T9nooldvp5AGzswibGG7MXZhFeLcsF6WUaaDMlLJMKiV3xsrS5b6k+nhwhWZOVe8H58p40wFIvRJlxcxAP+AtT/f5+gwj+I2mM4KKyyVvgzVHtecaXnsRsvVGbVWqlmMOJjo6GK3BP4dQFaFqSSFqI0GniwqqH4vGsthq2+GJAnAHMaLYYhC5c9tz9RuwUaCirp3mBwgx4ptAWQYILRHvm/PctJAVF80pIDFoH/gD0M577yI4gWhQavnXo6dttEqQx7pdKHRFx3vpwnnOixWYhnHjqNrkx2n0NjwKb0t5X77iRmTAajnlbckOfyb7+CxDZgNYbn26PwH5sUn4wFEWguGQicKhcSbzznAIGQB4xy81z2B+F9XYR19VSeJdEU1AU+K3tzt+DZxFS6FLPCHTVGNArRK1diT3UNhr5EzS7w76XLJ8Uw5IRMI7Pu9g5HGOuZGxpO+qW1y4uzh7wAGRh2bP/MeM0JwzYXBP9Gz3KcJygynkxlaMrXcDq8t3sjOFxct721LNi5dMEXsus4ry1NzANNXVvLr7Xw7Cmt32WMsjSKa3HJYsrhfNxAvtoHsjUTivQpryLjrwIy3xKIKyOpg0o3UEUiz7sGsXVuWDH9uxIxFl7ECFQZJTB0N99cq87mjtqN+I X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR0P264MB2741.FRAP264.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(8936002)(966005)(86362001)(31696002)(5660300002)(6486002)(6512007)(2616005)(82960400001)(508600001)(38100700002)(316002)(2906002)(6506007)(186003)(83380400001)(66556008)(66476007)(66946007)(8676002)(4326008)(6862004)(36756003)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UC9zUDFvc3l5OFdiTHUwOFgvOUJzbXV3VVVxN2J5bUhvTmIzaFJNVUM0TUZQ?= =?utf-8?B?QVVLV2dhVkJ0aUdsbEJ5ZXJHUElqL2pjVzdaY0hDTUZuUWtzckd1VFBsbEgv?= =?utf-8?B?V295UjUvZGdKVnQzVGRpWHhLWVVJUG14eGg0eWt6eFlldU5iUkpXano3S2N4?= =?utf-8?B?aUJEUitIY1Awa2hpNDVxRHQ5aldGZ25hbTBiKzM0TnljZlFuRXhJa3NVbXNw?= =?utf-8?B?emIyc0REbGc2VUhSYUZSTTNzNWxFK3ArOXZraTd1bEMrVmN0WW9heUNtYm5R?= =?utf-8?B?WjVFS21FVVh6MkswSVlhTTUyS0p1aWl2NlZrOE1CVTMyUno0eiszYmVMSGRi?= =?utf-8?B?elM3YmxULzZ2VGxWVzJWdkdYaUdMSWhtQzNUTmFDSE0rWS8xVGloZWh3a3Iv?= =?utf-8?B?bHUrTSs5U2VoMVlSZE10QVYwdjRkcjRlMmZ5WVVvQnBiaHkxOEU4ak41R0FP?= =?utf-8?B?NjBReHdEZFB6WEhQRHRDQ0FEZjI3UldQNFplMFdaYjBlakU0b2I3U09ENUli?= =?utf-8?B?NFZ5aFFGNzFQN0R3eWl0SGlIK3RZZHh0M1E0UEVmaDNkR0NXMEZVc1FUV1VG?= =?utf-8?B?KzZodS9Ram1yV0pnMnJqNUluZ3NVY3N6dkxSWTYzeHpsYzluQ1BQekc1U0Jk?= =?utf-8?B?TnpwZ2h0ZFBRdXJEZ2I2d0xYT0Y5aUNKc3FpaW5IK0NZdzd2VGJhOVdwcFZZ?= =?utf-8?B?YWlzd3RkMGJZR3BELzRDbDZ6dCs3amxsT2NoRUdvU2UwYm9jcm5FM0N5RGxK?= =?utf-8?B?NzRkendLSGg4OVVCMlBOVWlXdTZKRTgyZnAyY1F3NVFQOTJPSGxtRngvMkM4?= =?utf-8?B?ektqZnlTd2g0aXIvZlFGVkdLRElEZE9yTFVJV2FuS0VzZHl0WFpNaVBGTGNX?= =?utf-8?B?Yzh3Qm1hMGUrV3AyYTU1ZEQxaEJYUVZIMWM1bXd4TkRScTZUS09OcURDSW1t?= =?utf-8?B?QmZaOEZnTUtISGsrNEJEZFJKMEVqZ1BjYUJubVZOWDhsU2lJeFdObWNaTTE5?= =?utf-8?B?MDZ6MDQvZmVvMERzT2hwMVhFTmFlejUrZU5YZ2VMTVRRRDgwQ3p1UDVmRnBs?= =?utf-8?B?bEF2elhEVEN3M01SMnNwcE1pL2g1OXhzVjJ0ek1EYWdFVGdINUlobmNmZThv?= =?utf-8?B?Smk5NkVYbjRFVzM3OTd5TnlZV3RzUnB3NXNORm1GOEozRnNJb0g2OEQ2SXls?= =?utf-8?B?Z1IzQnlpck56TmRqa0I1U2kwZWozQ1VFenlyWVhiZzV4VVFTMTVpSFNUMndG?= =?utf-8?B?b0RuSTNXQVozRXpPYmtEanVSVHNBY2FlQUpBb29QRnJjdHNEbDZ1S1pkaHZ0?= =?utf-8?B?Tk5KdWs3U0tVamxDdDVpWGo4R0RMSjg1SFlEUDk3R3pvLzdTM3N2Zi9RYlBn?= =?utf-8?B?eXFwVjg5Y2tTcDMyaDJPVDFxRUVSeWxhSlducytlQ20wMDVoVU5pTHNQdmVh?= =?utf-8?B?dXNtZzQrMXdNMGZ5RXZJc0Fpd2VsVEVIWEphVlZpVjRBdTRFYWtjU1Z3bG54?= =?utf-8?B?K2NMVG00L3JEeEhmazJUZ3hIcGhScU0zaEdOaVVIc3M0V1grMHErQ0dNcXZH?= =?utf-8?B?a2Y5eG1QaExVV2t3MWQyem5aUElXYkFyQUhhNGh5dHlKOHdkb2dPc0YzRmk2?= =?utf-8?B?SDhRWWZhcnhOR00vQlRaUjdqZnpzcHR3eTBDbjg0UzU3R2VLTGtCV3JSc2pS?= =?utf-8?B?djdGekZZSDlqN2pUZEpyUldJRWtkL0FyNnlWeGJ1UmlMejhzc2N0TUpwNEhL?= =?utf-8?B?U3lzaWJGU04zREFrVGt4RWVmd0lTajZscUFyWTNEOUp1NmN5M2YyeUsxSUpC?= =?utf-8?B?NEpKcXZmMTJDMWtDZVBxdHFmOFl6SENhWURnL3RoQW0xRitoNVBwcit0MHdQ?= =?utf-8?B?VHYzUkFkWHdYRU9RTWRyb0JWS29uakFFSEhxS0ZhTDJxRzhBc1FKNTNOdkZs?= =?utf-8?B?USsyRlk1ZmpnbGEvUDdYR0RrVVdrVlNDS0s2Uzd4cElRUmU2bWZDSnB3OE5m?= =?utf-8?B?L3o2dzdkaXpscW01QUttTnd6bDF5c04vREhaTG8wUTZVWUd0aC9hVXMvU05X?= =?utf-8?B?cFpidElEYmlRTWlxNHM0SFBjbkFsZ3Y2OVdyVWRhMktNaEN4SFRCT1BQRDlW?= =?utf-8?B?V3FUTjhGOUtuUGZtaXdhRnd4OTZRRnhiem5MVGR4aUxMUTc5TENpVEdUOGZj?= =?utf-8?B?aVJvWmFqbk56b2VZemxmM1o4c1VsQUloKzllSDNNbE4vUEZJbnF0RzVMVyts?= =?utf-8?B?VjE2T0xvVjR4TWxUZmtGRnQ5T2JlV3QrYm9naWw0Rk9DQkRyK0xmcUdkWjRz?= =?utf-8?B?YWxTeG9sYUxwdkNDVi9ObmM1VUFueG5oQjRhVFNuczBLcHpKQUNqM3UrTkJW?= =?utf-8?Q?LT8/WBTC3COxigDAReN66oWzsYG8BAKDQpC5UA4+hC72g?= X-MS-Exchange-AntiSpam-MessageData-1: kAhz1BunMY2ByD0951pLq8izHREF5BHL9W1NCpjOOn5qVaG2rmf/S/vE X-OriginatorOrg: softathome.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6ae210c-7bf8-4247-d8cf-08da10fdc425 X-MS-Exchange-CrossTenant-AuthSource: PR0P264MB2741.FRAP264.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2022 20:58:53.1649 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: aa10e044-e405-4c10-8353-36b4d0cce511 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iK5mL/prZ4bH914GmC4AY9xCVxbhIfsddwwdqc/rUw2tzr+6g/oYQP9+zR6wxv/dnuP/9novOIjhamgmREDZGTUy8JrGEKZHc/80gy6tTdU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR0P264MB1819 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hi Tom, Le 26/03/2022 à 00:02, Tom Rini a écrit : > On Fri, Mar 25, 2022 at 11:54:18PM +0100, Philippe REYNES wrote: >> Hi Tom, >> >> >> Le 25/03/2022 à 18:11, Tom Rini a écrit : >>> On Mon, Mar 14, 2022 at 03:57:43PM +0100, Philippe Reynes wrote: >>> >>>> Adds test units for the pre-load header signature. >>>> >>>> Signed-off-by: Philippe Reynes >>>> --- >>>> test/py/tests/test_vboot.py | 145 ++++++++++++++++-- >>>> test/py/tests/vboot/sandbox-binman-pss.dts | 25 +++ >>>> test/py/tests/vboot/sandbox-binman.dts | 24 +++ >>>> .../tests/vboot/sandbox-u-boot-global-pss.dts | 28 ++++ >>>> test/py/tests/vboot/sandbox-u-boot-global.dts | 27 ++++ >>>> test/py/tests/vboot/simple-images.its | 36 +++++ >>>> 6 files changed, 269 insertions(+), 16 deletions(-) >>>> create mode 100644 test/py/tests/vboot/sandbox-binman-pss.dts >>>> create mode 100644 test/py/tests/vboot/sandbox-binman.dts >>>> create mode 100644 test/py/tests/vboot/sandbox-u-boot-global-pss.dts >>>> create mode 100644 test/py/tests/vboot/sandbox-u-boot-global.dts >>>> create mode 100644 test/py/tests/vboot/simple-images.its >>> This leads to CI failures such as: >>> https://source.denx.de/u-boot/u-boot/-/jobs/412046 >>> and I guess maybe we need something new in test/py/requirements.txt >>> maybe? >> I think that this issue should be fixed with this patch : >> >> https://patchwork.ozlabs.org/project/uboot/patch/20220127140314.10264-2-philippe.reynes@softathome.com/ > OK, but that's a rather specific hard-coded path to add, and won't work > in my setup for example since I use mktemp to make the base dir for all > my tests. I have sent a v8 with a change in test_vboot to use PYTHONPATH, so the CI should be fixed. And this patch is no longer needed. Regards, Philippe