From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752545AbdAZBWq (ORCPT ); Wed, 25 Jan 2017 20:22:46 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:33729 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752470AbdAZBWn (ORCPT ); Wed, 25 Jan 2017 20:22:43 -0500 Subject: Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver To: Javier Martinez Canillas References: <1483755102-24785-1-git-send-email-steve_longerbeam@mentor.com> <1483755102-24785-14-git-send-email-steve_longerbeam@mentor.com> Cc: Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Fabio Estevam , Russell King , Mauro Carvalho Chehab , Hans Verkuil , nick@shmanahar.org, Markus Heiser , Philipp Zabel , Laurent Pinchart , Benoit Parrot , Geert Uytterhoeven , Arnd Bergmann , sudipm.mukherjee@gmail.com, minghsiu.tsai@mediatek.com, tiffany.lin@mediatek.com, Jean-Christophe Trotin , horms+renesas@verge.net.au, niklas.soderlund+renesas@ragnatech.se, robert.jarzmik@free.fr, songjun.wu@microchip.com, andrew-ct.chen@mediatek.com, Greg Kroah-Hartman , devel@driverdev.osuosl.org, "devicetree@vger.kernel.org" , Steve Longerbeam , Sascha Hauer , Linux Kernel , "linux-arm-kernel@lists.infradead.org" , Linux Media Mailing List From: Steve Longerbeam Message-ID: <05f38c1c-bf6a-3be0-9aa9-c23a4ca24cdd@gmail.com> Date: Wed, 25 Jan 2017 17:22:34 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/24/2017 04:44 AM, Javier Martinez Canillas wrote: > Hello Steve, > > On Fri, Jan 6, 2017 at 11:11 PM, Steve Longerbeam wrote: >> From: Philipp Zabel > [snip] > >> +config VIDEO_MULTIPLEXER >> + tristate "Video Multiplexer" >> + depends on VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER > The driver can be build as a module... > >> + >> +static const struct of_device_id vidsw_dt_ids[] = { >> + { .compatible = "video-multiplexer", }, >> + { /* sentinel */ } >> +}; >> + > ... so you need a MODULE_DEVICE_TABLE(of, vidsw_dt_ids) here or > otherwise module autoloading won't work. Hi Javier, thanks for catching, done. Steve From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Longerbeam Subject: Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver Date: Wed, 25 Jan 2017 17:22:34 -0800 Message-ID: <05f38c1c-bf6a-3be0-9aa9-c23a4ca24cdd@gmail.com> References: <1483755102-24785-1-git-send-email-steve_longerbeam@mentor.com> <1483755102-24785-14-git-send-email-steve_longerbeam@mentor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Javier Martinez Canillas Cc: Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Fabio Estevam , Russell King , Mauro Carvalho Chehab , Hans Verkuil , nick-gcszYUEDH4VrovVCs/uTlw@public.gmane.org, Markus Heiser , Philipp Zabel , Laurent Pinchart , Benoit Parrot , Geert Uytterhoeven , Arnd Bergmann , sudipm.mukherjee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, minghsiu.tsai-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, tiffany.lin-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Jean-Christophe Trotin , horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org, niklas.soderlund+renesas@ragnatec List-Id: devicetree@vger.kernel.org On 01/24/2017 04:44 AM, Javier Martinez Canillas wrote: > Hello Steve, > > On Fri, Jan 6, 2017 at 11:11 PM, Steve Longerbeam wrote: >> From: Philipp Zabel > [snip] > >> +config VIDEO_MULTIPLEXER >> + tristate "Video Multiplexer" >> + depends on VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER > The driver can be build as a module... > >> + >> +static const struct of_device_id vidsw_dt_ids[] = { >> + { .compatible = "video-multiplexer", }, >> + { /* sentinel */ } >> +}; >> + > ... so you need a MODULE_DEVICE_TABLE(of, vidsw_dt_ids) here or > otherwise module autoloading won't work. Hi Javier, thanks for catching, done. Steve -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pf0-f195.google.com ([209.85.192.195]:33729 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752470AbdAZBWn (ORCPT ); Wed, 25 Jan 2017 20:22:43 -0500 Subject: Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver To: Javier Martinez Canillas References: <1483755102-24785-1-git-send-email-steve_longerbeam@mentor.com> <1483755102-24785-14-git-send-email-steve_longerbeam@mentor.com> Cc: Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Fabio Estevam , Russell King , Mauro Carvalho Chehab , Hans Verkuil , nick@shmanahar.org, Markus Heiser , Philipp Zabel , Laurent Pinchart , Benoit Parrot , Geert Uytterhoeven , Arnd Bergmann , sudipm.mukherjee@gmail.com, minghsiu.tsai@mediatek.com, tiffany.lin@mediatek.com, Jean-Christophe Trotin , horms+renesas@verge.net.au, niklas.soderlund+renesas@ragnatech.se, robert.jarzmik@free.fr, songjun.wu@microchip.com, andrew-ct.chen@mediatek.com, Greg Kroah-Hartman , devel@driverdev.osuosl.org, "devicetree@vger.kernel.org" , Steve Longerbeam , Sascha Hauer , Linux Kernel , "linux-arm-kernel@lists.infradead.org" , Linux Media Mailing List From: Steve Longerbeam Message-ID: <05f38c1c-bf6a-3be0-9aa9-c23a4ca24cdd@gmail.com> Date: Wed, 25 Jan 2017 17:22:34 -0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 01/24/2017 04:44 AM, Javier Martinez Canillas wrote: > Hello Steve, > > On Fri, Jan 6, 2017 at 11:11 PM, Steve Longerbeam wrote: >> From: Philipp Zabel > [snip] > >> +config VIDEO_MULTIPLEXER >> + tristate "Video Multiplexer" >> + depends on VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER > The driver can be build as a module... > >> + >> +static const struct of_device_id vidsw_dt_ids[] = { >> + { .compatible = "video-multiplexer", }, >> + { /* sentinel */ } >> +}; >> + > ... so you need a MODULE_DEVICE_TABLE(of, vidsw_dt_ids) here or > otherwise module autoloading won't work. Hi Javier, thanks for catching, done. Steve From mboxrd@z Thu Jan 1 00:00:00 1970 From: slongerbeam@gmail.com (Steve Longerbeam) Date: Wed, 25 Jan 2017 17:22:34 -0800 Subject: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver In-Reply-To: References: <1483755102-24785-1-git-send-email-steve_longerbeam@mentor.com> <1483755102-24785-14-git-send-email-steve_longerbeam@mentor.com> Message-ID: <05f38c1c-bf6a-3be0-9aa9-c23a4ca24cdd@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/24/2017 04:44 AM, Javier Martinez Canillas wrote: > Hello Steve, > > On Fri, Jan 6, 2017 at 11:11 PM, Steve Longerbeam wrote: >> From: Philipp Zabel > [snip] > >> +config VIDEO_MULTIPLEXER >> + tristate "Video Multiplexer" >> + depends on VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER > The driver can be build as a module... > >> + >> +static const struct of_device_id vidsw_dt_ids[] = { >> + { .compatible = "video-multiplexer", }, >> + { /* sentinel */ } >> +}; >> + > ... so you need a MODULE_DEVICE_TABLE(of, vidsw_dt_ids) here or > otherwise module autoloading won't work. Hi Javier, thanks for catching, done. Steve