From: Oliver Hartkopp <socketcan@hartkopp.net>
To: mkl@pengutronix.de, mailhol.vincent@wanadoo.fr
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH v3 0/4] Introduce optional DLC element for Classic CAN
Date: Tue, 3 Nov 2020 11:33:02 +0100 [thread overview]
Message-ID: <05f5257e-2ece-d9d4-2481-57b05b961d10@hartkopp.net> (raw)
In-Reply-To: <20201029083218.41505-1-socketcan@hartkopp.net>
Hello Marc,
I did some more testing with different CAN-USB adapters and feel pretty
comfortable on the below patch set now.
Would you think this is something for can-next?
If so, I would also start to extend the can-gw.
On 29.10.20 09:32, Oliver Hartkopp wrote:
> Introduce improved DLC handling for Classic CAN with introduces a new
> element 'len8_dlc' to the struct can_frame and additionally rename
> the 'can_dlc' element to 'len' as it represents a plain payload length.
>
> Before implementing the CAN_CTRLMODE_CC_LEN8_DLC handling on driver level
> this patch set cleans up and renames the relevant code.
>
> No functional changes.
>
> This patch set is based on mkl/linux-can.git (testing branch).
Btw. here are still some patches that haven't been pushed upstream.
Best,
Oliver
>
> Changes in v2:
> - rephrase commit message of patch 4 about can_dlc replacement
>
> Changes in v3:
> - remove unnecessarily introduced u8 cast in flexcan.c
>
> Oliver Hartkopp (4):
> can: add optional DLC element to Classical CAN frame structure
> can: rename get_can_dlc() macro with can_get_cc_len()
> can: remove obsolete get_canfd_dlc() macro
> can: replace can_dlc as variable/element for payload length
>
> Documentation/networking/can.rst | 6 ++--
> drivers/net/can/at91_can.c | 14 ++++----
> drivers/net/can/c_can/c_can.c | 20 +++++------
> drivers/net/can/cc770/cc770.c | 14 ++++----
> drivers/net/can/dev.c | 10 +++---
> drivers/net/can/flexcan.c | 4 +--
> drivers/net/can/grcan.c | 10 +++---
> drivers/net/can/ifi_canfd/ifi_canfd.c | 6 ++--
> drivers/net/can/janz-ican3.c | 20 +++++------
> drivers/net/can/kvaser_pciefd.c | 4 +--
> drivers/net/can/m_can/m_can.c | 6 ++--
> drivers/net/can/mscan/mscan.c | 20 +++++------
> drivers/net/can/pch_can.c | 14 ++++----
> drivers/net/can/peak_canfd/peak_canfd.c | 16 ++++-----
> drivers/net/can/rcar/rcar_can.c | 14 ++++----
> drivers/net/can/rcar/rcar_canfd.c | 8 ++---
> drivers/net/can/rx-offload.c | 2 +-
> drivers/net/can/sja1000/sja1000.c | 10 +++---
> drivers/net/can/slcan.c | 32 ++++++++---------
> drivers/net/can/softing/softing_fw.c | 2 +-
> drivers/net/can/softing/softing_main.c | 14 ++++----
> drivers/net/can/spi/hi311x.c | 20 +++++------
> drivers/net/can/spi/mcp251x.c | 20 +++++------
> .../net/can/spi/mcp251xfd/mcp251xfd-core.c | 4 +--
> drivers/net/can/sun4i_can.c | 10 +++---
> drivers/net/can/ti_hecc.c | 8 ++---
> drivers/net/can/usb/ems_usb.c | 16 ++++-----
> drivers/net/can/usb/esd_usb2.c | 16 ++++-----
> drivers/net/can/usb/gs_usb.c | 14 ++++----
> .../net/can/usb/kvaser_usb/kvaser_usb_core.c | 2 +-
> .../net/can/usb/kvaser_usb/kvaser_usb_hydra.c | 20 +++++------
> .../net/can/usb/kvaser_usb/kvaser_usb_leaf.c | 22 ++++++------
> drivers/net/can/usb/mcba_usb.c | 10 +++---
> drivers/net/can/usb/peak_usb/pcan_usb.c | 14 ++++----
> drivers/net/can/usb/peak_usb/pcan_usb_fd.c | 14 ++++----
> drivers/net/can/usb/peak_usb/pcan_usb_pro.c | 14 ++++----
> drivers/net/can/usb/ucan.c | 20 +++++------
> drivers/net/can/usb/usb_8dev.c | 14 ++++----
> drivers/net/can/xilinx_can.c | 12 +++----
> include/linux/can/dev.h | 9 +++--
> include/linux/can/dev/peak_canfd.h | 2 +-
> include/uapi/linux/can.h | 36 ++++++++++++-------
> include/uapi/linux/can/netlink.h | 1 +
> net/can/af_can.c | 2 +-
> net/can/gw.c | 2 +-
> net/can/j1939/main.c | 4 +--
> 46 files changed, 281 insertions(+), 271 deletions(-)
>
next prev parent reply other threads:[~2020-11-03 10:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 8:32 [PATCH v3 0/4] Introduce optional DLC element for Classic CAN Oliver Hartkopp
2020-10-29 8:32 ` [PATCH v3 1/4] can: add optional DLC element to Classical CAN frame structure Oliver Hartkopp
2020-11-03 15:03 ` Vincent MAILHOL
2020-10-29 8:32 ` [PATCH v3 2/4] can: rename get_can_dlc() macro with can_get_cc_len() Oliver Hartkopp
2020-11-03 15:17 ` Vincent MAILHOL
2020-11-03 18:45 ` Oliver Hartkopp
2020-10-29 8:32 ` [PATCH v3 3/4] can: remove obsolete get_canfd_dlc() macro Oliver Hartkopp
2020-10-29 8:32 ` [PATCH v3 4/4] can: replace can_dlc as variable/element for payload length Oliver Hartkopp
2020-11-03 10:33 ` Oliver Hartkopp [this message]
2020-11-03 22:26 ` [PATCH v3 0/4] Introduce optional DLC element for Classic CAN Marc Kleine-Budde
2020-11-03 22:27 ` Marc Kleine-Budde
2020-11-04 15:08 ` Oliver Hartkopp
2020-11-04 15:15 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05f5257e-2ece-d9d4-2481-57b05b961d10@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=linux-can@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.