* [PATCH] ath6kl: mark expected switch fall-throughs
@ 2018-05-24 23:13 Gustavo A. R. Silva
2018-05-25 11:27 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo A. R. Silva @ 2018-05-24 23:13 UTC (permalink / raw)
To: Kalle Valo, David S. Miller
Cc: linux-wireless, netdev, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index 2ba8cf3..29e32cd 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -3898,17 +3898,17 @@ int ath6kl_cfg80211_init(struct ath6kl *ar)
wiphy->max_scan_ie_len = 1000; /* FIX: what is correct limit? */
switch (ar->hw.cap) {
case WMI_11AN_CAP:
- ht = true;
+ ht = true; /* fall through */
case WMI_11A_CAP:
band_5gig = true;
break;
case WMI_11GN_CAP:
- ht = true;
+ ht = true; /* fall through */
case WMI_11G_CAP:
band_2gig = true;
break;
case WMI_11AGN_CAP:
- ht = true;
+ ht = true; /* fall through */
case WMI_11AG_CAP:
band_2gig = true;
band_5gig = true;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ath6kl: mark expected switch fall-throughs
2018-05-24 23:13 [PATCH] ath6kl: mark expected switch fall-throughs Gustavo A. R. Silva
@ 2018-05-25 11:27 ` Sergei Shtylyov
2018-05-25 13:30 ` Kalle Valo
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2018-05-25 11:27 UTC (permalink / raw)
To: Gustavo A. R. Silva, Kalle Valo, David S. Miller
Cc: linux-wireless, netdev, linux-kernel
Hello!
On 5/25/2018 2:13 AM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> index 2ba8cf3..29e32cd 100644
> --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
> +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> @@ -3898,17 +3898,17 @@ int ath6kl_cfg80211_init(struct ath6kl *ar)
> wiphy->max_scan_ie_len = 1000; /* FIX: what is correct limit? */
> switch (ar->hw.cap) {
> case WMI_11AN_CAP:
> - ht = true;
> + ht = true; /* fall through */
> case WMI_11A_CAP:
> band_5gig = true;
> break;
> case WMI_11GN_CAP:
> - ht = true;
> + ht = true; /* fall through */
> case WMI_11G_CAP:
> band_2gig = true;
> break;
> case WMI_11AGN_CAP:
> - ht = true;
> + ht = true; /* fall through */
> case WMI_11AG_CAP:
> band_2gig = true;
> band_5gig = true;
Hm, typically such comments are done on a line of their own, have never
seen this style...
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath6kl: mark expected switch fall-throughs
2018-05-25 11:27 ` Sergei Shtylyov
@ 2018-05-25 13:30 ` Kalle Valo
2018-05-25 17:50 ` Gustavo A. R. Silva
0 siblings, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2018-05-25 13:30 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Gustavo A. R. Silva, David S. Miller, linux-wireless, netdev,
linux-kernel
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> writes:
> On 5/25/2018 2:13 AM, Gustavo A. R. Silva wrote:
>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
>> index 2ba8cf3..29e32cd 100644
>> --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
>> +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
>> @@ -3898,17 +3898,17 @@ int ath6kl_cfg80211_init(struct ath6kl *ar)
>> wiphy->max_scan_ie_len = 1000; /* FIX: what is correct limit? */
>> switch (ar->hw.cap) {
>> case WMI_11AN_CAP:
>> - ht = true;
>> + ht = true; /* fall through */
>> case WMI_11A_CAP:
>> band_5gig = true;
>> break;
>> case WMI_11GN_CAP:
>> - ht = true;
>> + ht = true; /* fall through */
>> case WMI_11G_CAP:
>> band_2gig = true;
>> break;
>> case WMI_11AGN_CAP:
>> - ht = true;
>> + ht = true; /* fall through */
>> case WMI_11AG_CAP:
>> band_2gig = true;
>> band_5gig = true;
>
> Hm, typically such comments are done on a line of their own, have
> never seen this style...
Yeah, I was wondering the same. Was there a particular reason for this?
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath6kl: mark expected switch fall-throughs
2018-05-25 13:30 ` Kalle Valo
@ 2018-05-25 17:50 ` Gustavo A. R. Silva
2018-05-25 18:10 ` Kalle Valo
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo A. R. Silva @ 2018-05-25 17:50 UTC (permalink / raw)
To: Kalle Valo, Sergei Shtylyov
Cc: David S. Miller, linux-wireless, netdev, linux-kernel
On 05/25/2018 08:30 AM, Kalle Valo wrote:
> Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> writes:
>
>> On 5/25/2018 2:13 AM, Gustavo A. R. Silva wrote:
>>
>>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>>> where we are expecting to fall through.
>>>
>>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>> ---
>>> drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
>>> index 2ba8cf3..29e32cd 100644
>>> --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
>>> +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
>>> @@ -3898,17 +3898,17 @@ int ath6kl_cfg80211_init(struct ath6kl *ar)
>>> wiphy->max_scan_ie_len = 1000; /* FIX: what is correct limit? */
>>> switch (ar->hw.cap) {
>>> case WMI_11AN_CAP:
>>> - ht = true;
>>> + ht = true; /* fall through */
>>> case WMI_11A_CAP:
>>> band_5gig = true;
>>> break;
>>> case WMI_11GN_CAP:
>>> - ht = true;
>>> + ht = true; /* fall through */
>>> case WMI_11G_CAP:
>>> band_2gig = true;
>>> break;
>>> case WMI_11AGN_CAP:
>>> - ht = true;
>>> + ht = true; /* fall through */
>>> case WMI_11AG_CAP:
>>> band_2gig = true;
>>> band_5gig = true;
>>
>> Hm, typically such comments are done on a line of their own, have
>> never seen this style...
>
> Yeah, I was wondering the same. Was there a particular reason for this?
>
Sometimes people use this style for a one-line code block.
I can change it to the traditional style. No problem.
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath6kl: mark expected switch fall-throughs
2018-05-25 17:50 ` Gustavo A. R. Silva
@ 2018-05-25 18:10 ` Kalle Valo
2018-05-25 18:14 ` Gustavo A. R. Silva
0 siblings, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2018-05-25 18:10 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Sergei Shtylyov, David S. Miller, linux-wireless, netdev, linux-kernel
"Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
> On 05/25/2018 08:30 AM, Kalle Valo wrote:
>> Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> writes:
>>
>>> On 5/25/2018 2:13 AM, Gustavo A. R. Silva wrote:
>>>
>>>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>>>> where we are expecting to fall through.
>>>>
>>>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>>> ---
>>>> drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++---
>>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
>>>> index 2ba8cf3..29e32cd 100644
>>>> --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
>>>> +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
>>>> @@ -3898,17 +3898,17 @@ int ath6kl_cfg80211_init(struct ath6kl *ar)
>>>> wiphy->max_scan_ie_len = 1000; /* FIX: what is correct limit? */
>>>> switch (ar->hw.cap) {
>>>> case WMI_11AN_CAP:
>>>> - ht = true;
>>>> + ht = true; /* fall through */
>>>> case WMI_11A_CAP:
>>>> band_5gig = true;
>>>> break;
>>>> case WMI_11GN_CAP:
>>>> - ht = true;
>>>> + ht = true; /* fall through */
>>>> case WMI_11G_CAP:
>>>> band_2gig = true;
>>>> break;
>>>> case WMI_11AGN_CAP:
>>>> - ht = true;
>>>> + ht = true; /* fall through */
>>>> case WMI_11AG_CAP:
>>>> band_2gig = true;
>>>> band_5gig = true;
>>>
>>> Hm, typically such comments are done on a line of their own, have
>>> never seen this style...
>>
>> Yeah, I was wondering the same. Was there a particular reason for this?
>>
>
> Sometimes people use this style for a one-line code block.
>
> I can change it to the traditional style. No problem.
I would prefer that. So if you can send v2 that would be great.
--
Kalle Valo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath6kl: mark expected switch fall-throughs
2018-05-25 18:10 ` Kalle Valo
@ 2018-05-25 18:14 ` Gustavo A. R. Silva
0 siblings, 0 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2018-05-25 18:14 UTC (permalink / raw)
To: Kalle Valo
Cc: Sergei Shtylyov, David S. Miller, linux-wireless, netdev, linux-kernel
On 05/25/2018 01:10 PM, Kalle Valo wrote:
>>> Yeah, I was wondering the same. Was there a particular reason for this?
>>>
>>
>> Sometimes people use this style for a one-line code block.
>>
>> I can change it to the traditional style. No problem.
>
> I would prefer that. So if you can send v2 that would be great.
>
Yep. No problem. I'll send it shortly.
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-05-25 18:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-24 23:13 [PATCH] ath6kl: mark expected switch fall-throughs Gustavo A. R. Silva
2018-05-25 11:27 ` Sergei Shtylyov
2018-05-25 13:30 ` Kalle Valo
2018-05-25 17:50 ` Gustavo A. R. Silva
2018-05-25 18:10 ` Kalle Valo
2018-05-25 18:14 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.