From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2AEEC4743C for ; Fri, 4 Jun 2021 17:00:12 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C20E9613E3 for ; Fri, 4 Jun 2021 17:00:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C20E9613E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7644D82E56; Fri, 4 Jun 2021 19:00:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.b="E7p8ySV9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3C9D982E56; Fri, 4 Jun 2021 19:00:07 +0200 (CEST) Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AE08282EE2 for ; Fri, 4 Jun 2021 19:00:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=prvs=07892f41cf=patrick.delaunay@foss.st.com Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 154GvZC8030150; Fri, 4 Jun 2021 18:59:59 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=/ZaXZ6mcEk7JDUDLhMWBJgxs2pBbDMvvq0nc+Npqn7g=; b=E7p8ySV91RaDd+EdQvg1wooOHWPwg9uWdqom1H/SQHyc9wP7owUDjc2BlAEqDyfNFx3w Xt1r6GY9ekJ46Pps+Ns8Q2fwo8kXlyuCyZ36QTGzPTITDxkRq5sGGeAeFCOjosnWiu5J FmLoBOBDfAcJkPky1gm/FOmVvFIDvIRnccpbDsyxd7oWa7NKxQHNBo/TCFV9DZNF0OAy 85obzVv2mGPuzW4MR+vqy9FZsQgqlNrop8pjWnhdk22vxjvOAIcFIt8c7j6BWtlFyxox eBNWMTzChjWYfuZKXubG1inlsFgNWEXUcA4B2UI1+KxAJYxtPqEdAeGlnEPZdpVUn2sj VQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 38yea1km7k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 04 Jun 2021 18:59:59 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 4E5CE10002A; Fri, 4 Jun 2021 18:59:59 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 3A5F2248EEB; Fri, 4 Jun 2021 18:59:59 +0200 (CEST) Received: from lmecxl0994.lme.st.com (10.75.127.45) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 4 Jun 2021 18:59:58 +0200 Subject: Re: [Uboot-stm32] [PATCH] dfu: dfu_mtd: set max_buf_size to erasesize also for NOR devices To: Patrice CHOTARD , , Lukasz Majewski CC: U-Boot STM32 , Marek Vasut References: <20210304174748.1.I1d824180669d63e22275f082e7ac0fe50c2b8646@changeid> <48f7454f-6bae-224c-bba3-4b24e81e800b@foss.st.com> From: Patrick DELAUNAY Message-ID: <0616d868-1939-e0dc-3d3a-8e4b150a95e9@foss.st.com> Date: Fri, 4 Jun 2021 18:59:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <48f7454f-6bae-224c-bba3-4b24e81e800b@foss.st.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.75.127.45] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-06-04_11:2021-06-04, 2021-06-04 signatures=0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Thanks Patrice, On 4/20/21 12:24 PM, Patrice CHOTARD wrote: > Hi Patrick > > On 3/4/21 5:47 PM, Patrick Delaunay wrote: >> For NOR devices the logical DFU buffer size is the sector_size, >> as it is done in dfu_sf.c or in spi/sf_mtd.c >> (sf_mtd_info.erasesize = flash->sector_size) >> >> For NAND the DFU size was already limited to erasesize as >> has_pages = true. >> >> So the mtd dfu backend can use this erasesize for all the MTD devices, >> NOR and NAND with dfu->max_buf_size = mtd->erasesize >> >> This difference was initially copied from MTD command, where >> data is fully available in RAM without size limitation. >> >> This patch avoids to have many sector write in dfu_mtd.c at the end >> of the DFU transfer and avoids issues with USB timeout or WATCHDOG. >> >> Signed-off-by: Patrick Delaunay >> --- >> >> drivers/dfu/dfu_mtd.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/drivers/dfu/dfu_mtd.c b/drivers/dfu/dfu_mtd.c >> index ca67585a7e..7efb3cbd79 100644 >> --- a/drivers/dfu/dfu_mtd.c >> +++ b/drivers/dfu/dfu_mtd.c >> @@ -252,7 +252,6 @@ int dfu_fill_entity_mtd(struct dfu_entity *dfu, char *devstr, char *s) >> { >> char *st; >> struct mtd_info *mtd; >> - bool has_pages; >> int ret, part; >> >> mtd = get_mtd_device_nm(devstr); >> @@ -262,9 +261,7 @@ int dfu_fill_entity_mtd(struct dfu_entity *dfu, char *devstr, char *s) >> >> dfu->dev_type = DFU_DEV_MTD; >> dfu->data.mtd.info = mtd; >> - >> - has_pages = mtd->type == MTD_NANDFLASH || mtd->type == MTD_MLCNANDFLASH; >> - dfu->max_buf_size = has_pages ? mtd->erasesize : 0; >> + dfu->max_buf_size = mtd->erasesize; >> >> st = strsep(&s, " "); >> if (!strcmp(st, "raw")) { >> > Reviewed-by: Patrice Chotard > > Thanks > > Patrice Lukasz, any remarks on your side? Can I take this patch in my first STM32 pull request for v2020.10 ? or a PR is already planed on your side ? http://patchwork.ozlabs.org/project/uboot/patch/20210304174748.1.I1d824180669d63e22275f082e7ac0fe50c2b8646@changeid/ Regards Patrick