From: "Dave, Tushar N" <tushar.n.dave@intel.com>
To: Michal Kubecek <mkubecek@suse.cz>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"gospo@redhat.com" <gospo@redhat.com>,
"sassmann@redhat.com" <sassmann@redhat.com>,
"jbeulich@suse.com" <jbeulich@suse.com>
Subject: RE: [net-next 02/11] e1000: Adding e1000_dump function
Date: Wed, 8 Feb 2012 18:39:30 +0000 [thread overview]
Message-ID: <061C8A8601E8EE4CA8D8FD6990CEA89123BDE6@ORSMSX102.amr.corp.intel.com> (raw)
In-Reply-To: <1782836.alj52xdzPl@alaris>
>-----Original Message-----
>From: Michal Kubeček [mailto:mkubecek@suse.cz]
>Sent: Tuesday, February 07, 2012 9:38 AM
>To: netdev@vger.kernel.org
>Cc: Kirsher, Jeffrey T; davem@davemloft.net; Dave, Tushar N;
>gospo@redhat.com; sassmann@redhat.com; jbeulich@suse.com
>Subject: Re: [net-next 02/11] e1000: Adding e1000_dump function
>
>On Tuesday 07 of February 2012 04:33EN, Jeff Kirsher wrote:
>> + if (netif_msg_pktdata(adapter) && buffer_info->dma != 0)
>> + print_hex_dump(KERN_INFO, "", DUMP_PREFIX_ADDRESS,
>> + 16, 1, phys_to_virt(buffer_info->dma),
>> + buffer_info->length, true);
>
>This might cause problems in Xen environment, we encountered a crash in
>e1000e where phys_to_virt() is used the same way. I'm not familiar with
>the details but this is what Jan Beulich wrote about it:
How did you fix the problem in e1000e then? I don't see bus_to_virt used in any of our Ethernet drivers.
Also when running in Xen which arch are you running on?
-Tushar
next prev parent reply other threads:[~2012-02-08 18:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 12:33 [net-next 00/11][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2012-02-07 12:33 ` [net-next 01/11] igbvf: refactor Interrupt Throttle Rate code Jeff Kirsher
2012-02-07 12:33 ` [net-next 02/11] e1000: Adding e1000_dump function Jeff Kirsher
2012-02-07 15:40 ` Joe Perches
2012-02-07 18:19 ` [PATCH net-next] e1000: Neaten " Joe Perches
2012-02-07 19:09 ` Dave, Tushar N
2012-02-07 17:38 ` [net-next 02/11] e1000: Adding " Michal Kubeček
2012-02-08 18:39 ` Dave, Tushar N [this message]
2012-02-09 9:08 ` Jan Beulich
2012-02-13 8:24 ` Michal Kubeček
2012-02-07 12:33 ` [net-next 03/11] e1000e: add missing initializers reported when compiling with W=1 Jeff Kirsher
2012-02-07 12:33 ` [net-next 04/11] e1000e: cleanup - check return values consistently Jeff Kirsher
2012-02-07 12:33 ` [net-next 05/11] e1000e: cleanup e1000_init_mac_params_80003es2lan() Jeff Kirsher
2012-02-07 12:33 ` [net-next 06/11] e1000e: cleanup e1000_init_mac_params_82571() Jeff Kirsher
2012-02-07 12:33 ` [net-next 07/11] e1000e: cleanup e1000_set_phys_id Jeff Kirsher
2012-02-07 12:33 ` [net-next 08/11] e1000e: cleanup - use braces in both branches of a conditional statement Jeff Kirsher
2012-02-07 12:33 ` [net-next 09/11] e1000e: fix checkpatch warning from MINMAX test Jeff Kirsher
2012-02-07 12:33 ` [net-next 10/11] e1000e: fix sparse warnings with -D__CHECK_ENDIAN__ Jeff Kirsher
2012-02-07 12:58 ` David Laight
2012-02-07 17:16 ` David Miller
2012-02-07 12:33 ` [net-next 11/11] e1000e: minor whitespace and indentation cleanup Jeff Kirsher
2012-02-07 17:27 ` [net-next 00/11][pull request] Intel Wired LAN Driver Updates David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=061C8A8601E8EE4CA8D8FD6990CEA89123BDE6@ORSMSX102.amr.corp.intel.com \
--to=tushar.n.dave@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jbeulich@suse.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.