From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94AFFC48BC2 for ; Wed, 23 Jun 2021 21:33:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CC9E613AD for ; Wed, 23 Jun 2021 21:33:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229940AbhFWVfi (ORCPT ); Wed, 23 Jun 2021 17:35:38 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:43878 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229800AbhFWVff (ORCPT ); Wed, 23 Jun 2021 17:35:35 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1624483997; h=Message-ID: References: In-Reply-To: Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=tOGyNtlccrkAAMmGN0pd+swv2Kj8HU9UzZuPW5E+0JQ=; b=sPvfstCo/u1uXQTOCw0MOb3RzrFAun9YNNS7geyCoEz/HXJUcXss4eivmAzfKizJPBWqgv20 JFyiJC4U9VPOUlC9V+/k816i2F5bvsWBoaiII/CBQqhmoK+ui1gDKb/RePpLc2nr6W4E2SHb c1kj9EZT5qdoJd1lc3ixAZ6nDTg= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 60d3a8905e3e57240b57b622 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 23 Jun 2021 21:33:04 GMT Sender: bbhatt=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id ECB60C4338A; Wed, 23 Jun 2021 21:33:03 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: bbhatt) by smtp.codeaurora.org (Postfix) with ESMTPSA id EE634C433D3; Wed, 23 Jun 2021 21:33:02 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 23 Jun 2021 14:33:02 -0700 From: Bhaumik Bhatt To: Kalle Valo Cc: Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org, loic.poulain@linaro.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Subject: Re: [PATCH v4 4/6] ath11k: set register access length for MHI driver Organization: Qualcomm Innovation Center, Inc. Reply-To: bbhatt@codeaurora.org Mail-Reply-To: bbhatt@codeaurora.org In-Reply-To: <87fsx8h4dx.fsf@codeaurora.org> References: <1620330705-40192-1-git-send-email-bbhatt@codeaurora.org> <1620330705-40192-5-git-send-email-bbhatt@codeaurora.org> <20210521135152.GL70095@thinkpad> <87h7i0juxt.fsf@codeaurora.org> <37184e28dcc952ba9ad5ed0dc2c1a6da@codeaurora.org> <87fsx8h4dx.fsf@codeaurora.org> Message-ID: <061e797fedbd1bc3dd7b86a087f6c69f@codeaurora.org> X-Sender: bbhatt@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021-06-23 10:34 AM, Kalle Valo wrote: > Bhaumik Bhatt writes: > >> Hi Kalle, >> >> On 2021-06-14 09:02 AM, Kalle Valo wrote: >>> Manivannan Sadhasivam writes: >>> >>>> On Thu, May 06, 2021 at 12:51:43PM -0700, Bhaumik Bhatt wrote: >>>>> MHI driver requires register space length to add range checks and >>>>> prevent memory region accesses outside of that for MMIO space. >>>>> Set it before registering the MHI controller. >>>>> >>>>> Signed-off-by: Bhaumik Bhatt >>>>> Reviewed-by: Hemant Kumar >>>> >>>> Reviewed-by: Manivannan Sadhasivam >>>> >>>> >>>> Kalle, should we do immutable branch for this patch or I can pick >>>> it up via MHI >>>> tree (if there are no other patches expected from ath11k for this >>>> controller)? >>> >>> I'm not expecting any conflicts with this, and if there are, they >>> should >>> be easy for Stephen or Linus to fix. So it's easiest to route this >>> via >>> your tree. But I'm not giving my ack yet, see below. >>> >>> I'm worried that this patchset breaks bisect. Every patch in the >>> patchset should not break existing functionality, what if only >>> patches >>> 1-3 are included in the tree but not patch 4? Wouldn't ath11k be >>> broken >>> then? I didn't review the whole patchset, but I suspect the fix is to >>> include the ath11k change in the actual mhi patch which changes the >>> functionality. So that way we would not have a separate ath11k patch >>> at >>> all. >>> >>> Also I'm not able to test this patchset at the moment. Can someone >>> else >>> help and do a quick test with QCA6390 to verify these doesn't break >>> ath11k? >> >> I have requested someone to try and test this patch series with >> QCA6390. >> >> I or the testers will get back to you with the test results when they >> are available. >> >> As far as your concerns go, you can choose to pick patches 1-3 and >> that would be just fine. >> >> Things will break if patchset 4 is _not_ in place with patchset 6 >> being part of the tree. >> >> It would, however, be nice to pick the whole series instead and ensure >> that the functionality MHI introduces for boot-up sanity is in place >> for any controllers such as ath11k. > > Just to be clear, this is not about me picking up any patches > separately. I was instead making sure git-bisect works correctly, as it > can randomly choose to test any commit in the tree. But based on your > description everything seems to be in order in this patchset and bisect > will work correctly. > > git-bisect is an important tool for me when I'm searching the root > cause > for ath11k regressions, that's why I'm so careful to make sure it > works. OK. Understood. Thanks, Bhaumik --- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B8C3C48BC2 for ; Wed, 23 Jun 2021 21:34:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F204161220 for ; Wed, 23 Jun 2021 21:34:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F204161220 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:Reply-To:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To: Subject:Cc:To:From:Date:MIME-Version:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z+XhorCQLdtv8wjcZOsCygjistv7DdBeVzFeEVmn3Q8=; b=OlKSqyPwZe57Sc CafSglO+BiyIzFhMhY6iAwxelXmTsEJfrnR9bAhKrFSzVDY3PcEjt4yyp54s6w4xMo6aho0mgiHb7 VfnnaxULnRubjigemIkNgyPffPwS5VP63wCjOP3NR0jM/fjzDSktYkvAbcCxDNTFW1wjJVEKY4JQO Oq9V2NwM+0VENB1nToLCGjd2KJXKXvU6i6UMV99aELtQVUgg1vDVToZ+o9u+GqfCwB0clNRpUD8mR Xl/ZnBTUnb3dPYyG2rSscdTftXKQt6YAHOu0PAzjW0eA4qeTGDChRZNd/DYeT05NwxWA+GweNn2sl rPMwIn7FSn+Pt2A+eBRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwAVb-00C0tP-RK; Wed, 23 Jun 2021 21:34:07 +0000 Received: from so254-9.mailgun.net ([198.61.254.9]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwAVV-00C0sP-Jr for ath11k@lists.infradead.org; Wed, 23 Jun 2021 21:34:05 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1624484044; h=Message-ID: References: In-Reply-To: Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=tOGyNtlccrkAAMmGN0pd+swv2Kj8HU9UzZuPW5E+0JQ=; b=LVuiYnMVOdHdcuGJye7CckK48yGxF2WJ2zg7iPDHqpBG48KfnpQ44TFVLRHFD3QPtgZEVote OA16lNhd356f/bKcUaHHRGlu5E8GFWszSHdx1cvtkGxPxF8LisHY7TkWfWyCwjn7I4T8oiYy QdbPDai18mk1kWdLH+RuaAhY5ok= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyJmOGQ2ZiIsICJhdGgxMWtAbGlzdHMuaW5mcmFkZWFkLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-east-1.postgun.com with SMTP id 60d3a8900090905e16bef834 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 23 Jun 2021 21:33:04 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1A107C43217; Wed, 23 Jun 2021 21:33:03 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: bbhatt) by smtp.codeaurora.org (Postfix) with ESMTPSA id EE634C433D3; Wed, 23 Jun 2021 21:33:02 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 23 Jun 2021 14:33:02 -0700 From: Bhaumik Bhatt To: Kalle Valo Cc: Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org, loic.poulain@linaro.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Subject: Re: [PATCH v4 4/6] ath11k: set register access length for MHI driver Organization: Qualcomm Innovation Center, Inc. Mail-Reply-To: bbhatt@codeaurora.org In-Reply-To: <87fsx8h4dx.fsf@codeaurora.org> References: <1620330705-40192-1-git-send-email-bbhatt@codeaurora.org> <1620330705-40192-5-git-send-email-bbhatt@codeaurora.org> <20210521135152.GL70095@thinkpad> <87h7i0juxt.fsf@codeaurora.org> <37184e28dcc952ba9ad5ed0dc2c1a6da@codeaurora.org> <87fsx8h4dx.fsf@codeaurora.org> Message-ID: <061e797fedbd1bc3dd7b86a087f6c69f@codeaurora.org> X-Sender: bbhatt@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210623_143404_441284_71253641 X-CRM114-Status: GOOD ( 27.69 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: bbhatt@codeaurora.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+ath11k=archiver.kernel.org@lists.infradead.org On 2021-06-23 10:34 AM, Kalle Valo wrote: > Bhaumik Bhatt writes: > >> Hi Kalle, >> >> On 2021-06-14 09:02 AM, Kalle Valo wrote: >>> Manivannan Sadhasivam writes: >>> >>>> On Thu, May 06, 2021 at 12:51:43PM -0700, Bhaumik Bhatt wrote: >>>>> MHI driver requires register space length to add range checks and >>>>> prevent memory region accesses outside of that for MMIO space. >>>>> Set it before registering the MHI controller. >>>>> >>>>> Signed-off-by: Bhaumik Bhatt >>>>> Reviewed-by: Hemant Kumar >>>> >>>> Reviewed-by: Manivannan Sadhasivam >>>> >>>> >>>> Kalle, should we do immutable branch for this patch or I can pick >>>> it up via MHI >>>> tree (if there are no other patches expected from ath11k for this >>>> controller)? >>> >>> I'm not expecting any conflicts with this, and if there are, they >>> should >>> be easy for Stephen or Linus to fix. So it's easiest to route this >>> via >>> your tree. But I'm not giving my ack yet, see below. >>> >>> I'm worried that this patchset breaks bisect. Every patch in the >>> patchset should not break existing functionality, what if only >>> patches >>> 1-3 are included in the tree but not patch 4? Wouldn't ath11k be >>> broken >>> then? I didn't review the whole patchset, but I suspect the fix is to >>> include the ath11k change in the actual mhi patch which changes the >>> functionality. So that way we would not have a separate ath11k patch >>> at >>> all. >>> >>> Also I'm not able to test this patchset at the moment. Can someone >>> else >>> help and do a quick test with QCA6390 to verify these doesn't break >>> ath11k? >> >> I have requested someone to try and test this patch series with >> QCA6390. >> >> I or the testers will get back to you with the test results when they >> are available. >> >> As far as your concerns go, you can choose to pick patches 1-3 and >> that would be just fine. >> >> Things will break if patchset 4 is _not_ in place with patchset 6 >> being part of the tree. >> >> It would, however, be nice to pick the whole series instead and ensure >> that the functionality MHI introduces for boot-up sanity is in place >> for any controllers such as ath11k. > > Just to be clear, this is not about me picking up any patches > separately. I was instead making sure git-bisect works correctly, as it > can randomly choose to test any commit in the tree. But based on your > description everything seems to be in order in this patchset and bisect > will work correctly. > > git-bisect is an important tool for me when I'm searching the root > cause > for ath11k regressions, that's why I'm so careful to make sure it > works. OK. Understood. Thanks, Bhaumik --- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k