From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72BAFC32771 for ; Wed, 28 Sep 2022 18:03:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234459AbiI1SDw (ORCPT ); Wed, 28 Sep 2022 14:03:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234482AbiI1SDu (ORCPT ); Wed, 28 Sep 2022 14:03:50 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E44F100ABD for ; Wed, 28 Sep 2022 11:03:49 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id s6so21521857lfo.7 for ; Wed, 28 Sep 2022 11:03:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=HXE9oeDQQV+iTI2ox/bIzi3jVXRhY6aBz1RqBKzY3QY=; b=Z3OhQW19A9BvFqqeeIvsTAbFQpLLBUrCM1V8Y6PI9Q7V94Pi0X+PZCXWN0Nhhre8bU hz7uzP3jWC6bSxtfSeuseK0g39FKCat0IIMZJYNrLnJljEu96rAS0+dnraeTATVLPZGA EareENKypzkQC6aS3KVjBWqBM1Pll8x1c2htmVzuv54xb64kgsmTnB+Hgxe0uAu8D7vx uPc7BcgpRxoRVHM/Le2C0NmD56f/rrSLRC8UUDWNmUMlhCy/YvJkQ08kcz2FoZoPZFcl 3WdOm5uVBMGZvcrhEp9bWq8bWDd/H28qnD7V5GyPybYYW13j0DIs4cWrerF9eSrkDhxP o2Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=HXE9oeDQQV+iTI2ox/bIzi3jVXRhY6aBz1RqBKzY3QY=; b=GzTP88m+x2XH1yVQU8AAosvpKIN9EjyIBIaEE5fok0E/vFKcFta+FTW3HZ39Q7fD/p m8BYEBNopJMLtBy9l4cbv0SiQtFXKDrH9h0ghKIdh3rwP1OCNh4olEsnEYdMvJ9FnZo8 66Lyn1oeFzl+pgGe0PeSkCCcGquWsFt++m6U++rm7jLWGrzNpxQgtNHgG5iiTxpR4Dnx qV3a8rYHDk3Anu5Td1qYQB0xtVWVVKrdIZAVjF5a8JuEJXlZDJ5t8itnfDcxV3BM8qyP j2rVJQ4Z5b3QlB3DBFfWUfc4Tj3QqOdKTOe+L+gLMsaTmCdkx+PpQTuOoKDcg7YkYgba mG6Q== X-Gm-Message-State: ACrzQf2RlX/6ZNmg3gFC4uJop5utmsZhtG7Bm+3hlIepLFdWCPlau94a DSJWYMjkbpj6d1cTAOmRYaOZQQ== X-Google-Smtp-Source: AMsMyM5LFG5uTcG/mvcymrW1/P8HiYSn5bhpc/dM9E4AjvP9rptnd1GgJLYkj2f14njBNO+kHWPlKA== X-Received: by 2002:a05:6512:1305:b0:4a1:d80d:95d with SMTP id x5-20020a056512130500b004a1d80d095dmr6564493lfu.324.1664388227440; Wed, 28 Sep 2022 11:03:47 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id s10-20020a056512214a00b00497c3fdf995sm535795lfr.152.2022.09.28.11.03.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 11:03:47 -0700 (PDT) Message-ID: <0636d53f-508f-8a86-0973-2641c9020622@linaro.org> Date: Wed, 28 Sep 2022 20:03:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 5/7] arm: dts: qcom: mdm9615: remove invalid pmic subnodes compatibles Content-Language: en-US To: Neil Armstrong , Andy Gross , Krzysztof Kozlowski , Bjorn Andersson , Rob Herring , Konrad Dybcio Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20220928-mdm9615-dt-schema-fixes-v1-0-b6e63a7df1e8@linaro.org> <20220928-mdm9615-dt-schema-fixes-v1-5-b6e63a7df1e8@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220928-mdm9615-dt-schema-fixes-v1-5-b6e63a7df1e8@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 28/09/2022 11:14, Neil Armstrong wrote: > The PMIC is an PM8018, but was compatible with the PM8921. Both compatibles > was left but it makes no sense anymore the leave both. Why? It makes sense for backwards compatibility. If you think it does not make sense, please say why. > > The pwrkey compatible is left to PM8921, unlike the others because > the interface is stricly compatible with the PM9821 pwrkey. typo: strictly typo: PM8921 Again, why? The old code looked correct. In all three places. > > Signed-off-by: Neil Armstrong > Best regards, Krzysztof