From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ola Liljedahl Subject: Re: [PATCH v3 1/3] ring: read tail using atomic load Date: Mon, 8 Oct 2018 09:22:05 +0000 Message-ID: <063A95EC-CFC1-42F7-B864-DFB9C6718AC8@arm.com> References: <20181005170725.GA18671@jerin> <1555626C-F2B8-44EB-98A3-79B1F7002587@arm.com> <60055965-A7C8-4E9F-8668-0AE1DCE57515@arm.com> <20181006074126.GA16715@jerin> <20181007040243.GA1850@jerin> <7A156041-23EC-4CCB-B129-3607AF34A992@arm.com> <20181008060629.GA5228@jerin> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "dev@dpdk.org" , Honnappa Nagarahalli , "Ananyev, Konstantin" , "Gavin Hu (Arm Technology China)" , Steve Capper , nd , "stable@dpdk.org" To: Jerin Jacob Return-path: In-Reply-To: <20181008060629.GA5228@jerin> Content-Language: en-US Content-ID: <4C36FF6D7E39E2448BDB92DA5EF8EB66@eurprd08.prod.outlook.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" T24gMDgvMTAvMjAxOCwgMDg6MDYsICJKZXJpbiBKYWNvYiIgPGplcmluLmphY29iQGNhdml1bW5l dHdvcmtzLmNvbT4gd3JvdGU6DQoNCiAgICAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KICAg ID4gRGF0ZTogU3VuLCA3IE9jdCAyMDE4IDIwOjQ0OjU0ICswMDAwDQogICAgPiBGcm9tOiBPbGEg TGlsamVkYWhsIDxPbGEuTGlsamVkYWhsQGFybS5jb20+DQogICAgPiBUbzogSmVyaW4gSmFjb2Ig PGplcmluLmphY29iQGNhdml1bW5ldHdvcmtzLmNvbT4NCiAgICA+IENDOiAiZGV2QGRwZGsub3Jn IiA8ZGV2QGRwZGsub3JnPiwgSG9ubmFwcGEgTmFnYXJhaGFsbGkNCiAgICA+ICA8SG9ubmFwcGEu TmFnYXJhaGFsbGlAYXJtLmNvbT4sICJBbmFueWV2LCBLb25zdGFudGluIg0KICAgID4gIDxrb25z dGFudGluLmFuYW55ZXZAaW50ZWwuY29tPiwgIkdhdmluIEh1IChBcm0gVGVjaG5vbG9neSBDaGlu YSkiDQogICAgPiAgPEdhdmluLkh1QGFybS5jb20+LCBTdGV2ZSBDYXBwZXIgPFN0ZXZlLkNhcHBl ckBhcm0uY29tPiwgbmQgPG5kQGFybS5jb20+LA0KICAgID4gICJzdGFibGVAZHBkay5vcmciIDxz dGFibGVAZHBkay5vcmc+DQogICAgPiBTdWJqZWN0OiBSZTogW1BBVENIIHYzIDEvM10gcmluZzog cmVhZCB0YWlsIHVzaW5nIGF0b21pYyBsb2FkDQogICAgPiB1c2VyLWFnZW50OiBNaWNyb3NvZnQt TWFjT3V0bG9vay8xMC4xMS4wLjE4MDkwOQ0KICAgID4gDQogICAgDQogICAgDQogICAgQ291bGQg eW91IHBsZWFzZSBmaXggdGhlIGVtYWlsIGNsaWVudCBmb3IgaW5saW5lIHJlcGx5Lg0KU29ycnkg dGhhdCBkb2Vzbid0IHNlZW0gdG8gYmUgcG9zc2libGUgd2l0aCBPdXRsb29rIGZvciBNYWMgMTYg b3IgT2ZmaWNlMzY1LiBUaGUgb2ZmaWNpYWwgT2ZmaWNlMzY1L091dGxvb2sNCmRvY3VtZW50YXRp b24gZG9lc24ndCBtYXRjaCB0aGUgYWN0dWFsIHVzZXIgaW50ZXJmYWNlLi4uDQoNCg0KICAgIA0K ICAgIGh0dHBzOi8vd3d3Lmtlcm5lbC5vcmcvZG9jL2h0bWwvdjQuMTktcmM3L3Byb2Nlc3MvZW1h aWwtY2xpZW50cy5odG1sDQogICAgDQogICAgDQogICAgPiANCiAgICA+IE9uIDA3LzEwLzIwMTgs IDA2OjAzLCAiSmVyaW4gSmFjb2IiIDxqZXJpbi5qYWNvYkBjYXZpdW1uZXR3b3Jrcy5jb20+IHdy b3RlOg0KICAgID4gDQogICAgPiAgICAgSW4gYXJtNjQgY2FzZSwgaXQgd2lsbCBoYXZlIEFUT01J Q19SRUxBWEVEIGZvbGxvd2VkIGJ5IGFzbSB2b2xhdGlsZSAoIiI6OjoibWVtb3J5Iikgb2YgcnRl X3BhdXNlKCkuDQogICAgPiAgICAgSSB3b3VsZCBuJ3QgaGF2ZSBhbnkgaXNzdWUsIGlmIHRoZSBn ZW5lcmF0ZWQgY29kZSBjb2RlIGlzIHNhbWUgb3IgYmV0dGVyIHRoYW4gdGhlIGV4aXRpbmcgY2Fz ZS4gYnV0IGl0IG5vdCB0aGUgY2FzZSwgUmlnaHQ/DQogICAgPiBUaGUgZXhpc3RpbmcgY2FzZSBp cyBhY3R1YWxseSBub3QgaW50ZXJlc3RpbmcgKElNTykgYXMgaXQgZXhwb3NlcyB1bmRlZmluZWQg YmVoYXZpb3VyIHdoaWNoIGFsbG93cyB0aGUgY29tcGlsZXIgdG8gZG8gYW55dGhpbmcuIEJ1dCB5 b3Ugc2VlbSB0byBiZSBzYXRpc2ZpZWQgd2l0aCAid29ya3MgZm9yIG1lLCByaWdodCBoZXJlIHJp Z2h0IG5vdyIuIEkgdGhpbmsgdGhlIGNvc3Qgb2YgYXZvaWRpbmcgdW5kZWZpbmVkIGJlaGF2aW91 ciBpcyBhY2NlcHRhYmxlIChhY3R1YWxseSBJIGRvbid0IHRoaW5rIGl0IGV2ZW4gd2lsbCBiZSBu b3RpY2VhYmxlKS4NCiAgICANCiAgICBJIGFtIG5vdCBjb252aW5jZWQgYmVjYXVzZSBvZiB1c2Ug b2Ygdm9sYXRpbGUgaW4gaGVhZCBhbmQgdGFpbCBpbmRleGVzLg0KICAgIEZvciBtZSB0aGF0IGJy aW5ncyB0aGUgZGVmaW5lZCBiZWhhdmlvci4NCkFzIGxvbmcgYXMgeW91IGRvbid0IG1peCBpbiBD MTEgYXRvbWljIGFjY2Vzc2VzIChqdXN0IHVzZSAicGxhaW4iIGFjY2Vzc2VzIHRvIHZvbGF0aWxl IG9iamVjdHMpLA0KaXQgaXMgQUZBSUsgZGVmaW5lZCBiZWhhdmlvdXIgKGJ1dCBub3QgbmVjZXNz YXJpbHkgdXNpbmcgYXRvbWljIGxvYWRzIGFuZCBzdG9yZXMpLiBCdXQgSSBxdW90ZWQNCnRoZSBD MTEgc3BlYyB3aGVyZSBpdCBleHBsaWNpdGx5IG1lbnRpb25zIHRoYXQgbWl4aW5nIGF0b21pYyBh bmQgbm9uLWF0b21pYyBhY2Nlc3NlcyB0byB0aGUgc2FtZQ0Kb2JqZWN0IGlzIHVuZGVmaW5lZCBi ZWhhdmlvdXIuIERvbid0IGFyZ3VlIHdpdGggbWUsIGFyZ3VlIHdpdGggdGhlIEMxMSBzcGVjLg0K SWYgeW91IHdhbnQgdG8gZGlzb2JleSB0aGUgc3BlYywgdGhpcyBzaG91bGQgYXQgbGVhc3QgYmUg Y2FsbGVkIG91dCBmb3IgaW4gdGhlIGNvZGUgd2l0aCBhIGNvbW1lbnQuDQoNCg0KICAgIFRoYXQg dGhlIHJlYXNvbiB3aHkgSSBzaGFyZWQNCiAgICB0aGUgZ2VuZXJhdGVkIGFzc2VtYmx5IGNvZGUu IElmIHlvdSB0aGluayBvdGhlciB3YXksIFBpY2sgYW55IGNvbXBpbGVyDQogICAgYW5kIHNlZSBn ZW5lcmF0ZWQgb3V0cHV0Lg0KVGhpcyBpcyB3aGF0IG9uZSBjb21waWxlciBmb3Igb25lIGFyY2hp dGVjdHVyZSBnZW5lcmF0ZXMgdG9kYXkuIFRoZXNlIHRoaW5ncyBjaGFuZ2UuIE90aGVyIHRoaW5n cw0KdGhhdCB1c2VkIHRvIHdvcmsgb3Igd29ya2VkIGZvciBzb21lIHNwZWNpZmljIGFyY2hpdGVj dHVyZSBoYXMgc3RvcHBlZCB3b3JraW5nIGluIG5ld2VyIHZlcnNpb25zIG9mDQp0aGUgY29tcGls ZXIuDQoNCiAgICANCiAgICBBbmQNCiAgICANCiAgICBGcmVlYnNkIGltcGxlbWVudGF0aW9uIG9m IHJpbmcgYnVmZmVyKFdoaWNoIERQREsgZGVyaXZlZCBmcm9tKSwgRG9uJ3QgaGF2ZQ0KICAgIHN1 Y2ggbG9naWMsIFNlZSBodHRwczovL2dpdGh1Yi5jb20vZnJlZWJzZC9mcmVlYnNkL2Jsb2IvbWFz dGVyL3N5cy9zeXMvYnVmX3JpbmcuaCNMMTA4DQpJdCBsb29rcyBsaWtlIEZyZWVCU0QgdXNlcyBz b21lIGtpbmQgb2YgQzExIGF0b21pYyBtZW1vcnkgbW9kZWwtaW5zcGlyZWQgQVBJIGFsdGhvdWdo IEkgZG9uJ3Qgc2VlDQpleGFjdGx5IGhvdyBlLmcuIGF0b21pY19zdG9yZV9yZWxfaW50KCkgaXMg aW1wbGVtZW50ZWQuIFRoZSBjb2RlIGFsc28gbWl4ZXMgaW4gZXhwbGljaXQgYmFycmllcnMNCnNv IGRlZmluaXRpdmVseSBub3QgcHVyZSBDMTEgbWVtb3J5IG1vZGVsIHVzYWdlLiBBbmQgZmluYWxs eSwgaXQgZG9lc24ndCBlc3RhYmxpc2ggdGhlIHByb3Blcg0KbG9hZC1hY3F1aXJlL3N0b3JlLXJl bGVhc2UgcmVsYXRpb25zaGlwcyAoZS5nLiBzdG9yZS1yZWxlYXNlIGNvbnNfdGFpbCByZXF1aXJl cyBhIGxvYWQtYWNxdWlyZSBjb25zX3RhaWwsDQpzYW1lIGZvciBwcm9kX3RhaWwpLg0KDQoiKiBt dWx0aS1wcm9kdWNlciBzYWZlIGxvY2stZnJlZSByaW5nIGJ1ZmZlciBlbnF1ZXVlIg0KVGhlIGNv bW1lbnQgaXMgYWxzbyB3cm9uZy4gVGhpcyBkZXNpZ24gaXMgbm90IGxvY2stZnJlZSwgaG93IGNv dWxkIGl0IGJlIHdoZW4gdGhlcmUgaXMgc3Bpbm5pbmcNCih3YWl0aW5nKSBmb3Igb3RoZXIgdGhy ZWFkcyBpbiB0aGUgY29kZT8gSWYgYSB0aHJlYWQgbXVzdCB3YWl0IGZvciBvdGhlciB0aHJlYWRz LCB0aGVuIGJ5IGRlZmluaXRpb24NCnRoZSBkZXNpZ24gaXMgYmxvY2tpbmcuDQoNClNvIHlvdSBh cmUgc2F5aW5nIHRoYXQgYmVjYXVzZSBGcmVlQlNEIGlzIGRvaW5nIGl0IHdyb25nLCBEUERLIGNh biBhbHNvIGRvIGl0IHdyb25nPw0KDQogICAgDQogICAgU2VlIGJlbG93IHRvby4NCiAgICANCiAg ICA+IA0KICAgID4gU2tpcHBpbmcgdGhlIGNvbXBpbGVyIG1lbW9yeSBiYXJyaWVyIGluIHJ0ZV9w YXVzZSgpIHBvdGVudGlhbGx5IGFsbG93cyBmb3Igb3B0aW1pc2F0aW9ucyB0aGF0IHByb3ZpZGUg bXVjaCBtb3JlIGJlbmVmaXQsIGUuZy4gaGlkaW5nIHNvbWUgY2FjaGUgbWlzcyBsYXRlbmN5IGZv ciBsYXRlciBsb2Fkcy4gVGhlIERQREsgcmluZyBidWZmZXIgaW1wbGVtZW50YXRpb24gaXMgZGVm aW5lZCBzbyB0byBlbmFibGUgaW5saW5pbmcgb2YgZW5xdWV1ZS9kZXF1ZXVlIGZ1bmN0aW9ucyBp bnRvIHRoZSBjYWxsZXIsIGFueSBjb2RlIGNvdWxkIGltbWVkaWF0ZWx5IGZvbGxvdyB0aGVzZSBj YWxscy4NCiAgICA+IA0KICAgID4gRnJvbSBJTlRFUk5BVElPTkFMIFNUQU5EQVJEIMKpSVNPL0lF QyBJU08vSUVDIDk4OTk6MjAxeA0KICAgID4gUHJvZ3JhbW1pbmcgbGFuZ3VhZ2VzIOKAlCBDDQog ICAgPiANCiAgICA+IDUuMS4yLjQNCiAgICA+IDQgVHdvIGV4cHJlc3Npb24gZXZhbHVhdGlvbnMg Y29uZmxpY3QgaWYgb25lIG9mIHRoZW0gbW9kaWZpZXMgYSBtZW1vcnkgbG9jYXRpb24gYW5kIHRo ZSBvdGhlciBvbmUgcmVhZHMgb3IgbW9kaWZpZXMgdGhlIHNhbWUgbWVtb3J5IGxvY2F0aW9uLg0K ICAgID4gDQogICAgPiAyNSBUaGUgZXhlY3V0aW9uIG9mIGEgcHJvZ3JhbSBjb250YWlucyBhIGRh dGEgcmFjZSBpZiBpdCBjb250YWlucyB0d28gY29uZmxpY3RpbmcgYWN0aW9ucyBpbiBkaWZmZXJl bnQgdGhyZWFkcywgYXQgbGVhc3Qgb25lIG9mIHdoaWNoIGlzIG5vdCBhdG9taWMsIGFuZCBuZWl0 aGVyIGhhcHBlbnMgYmVmb3JlIHRoZSBvdGhlci4gQW55IHN1Y2ggZGF0YSByYWNlIHJlc3VsdHMg aW4gdW5kZWZpbmVkIGJlaGF2aW9yLg0KICAgIA0KICAgIElNTywgQm90aCBjb25kaXRpb24gd2ls bCBzYXRpc2Z5IGlmIHRoZSB2YXJpYWJsZSBpcyB2b2xhdGlsZSBhbmQgMzJiaXQgcmVhZCB3aWxs IGF0b21pYw0KICAgIGZvciAzMmIgYW5kIDY0YiBtYWNoaW5lcy4gSWYgbm90LCB0aGUgcHJvYmxl bSBwZXJzaXN0IGZvciBnZW5lcmljIGNhc2UNCiAgICBhcyB3ZWxsKGxpYi9saWJydGVfcmluZy9y dGVfcmluZ19nZW5lcmljLmgpDQpUaGUgcmVhZCBmcm9tIGEgdm9sYXRpbGUgb2JqZWN0IGlzIG5v dCBhbiBhdG9taWMgYWNjZXNzIHBlciB0aGUgQzExIHNwZWMuIEl0IGp1c3QgaGFwcGVucyB0bw0K YmUgdHJhbnNsYXRlZCB0byBhbiBpbnN0cnVjdGlvbiAob24geDg2LTY0IGFuZCBBQXJjaDY0L0E2 NCkgdGhhdCBpbXBsZW1lbnRzIGFuIGF0b21pYyBsb2FkLg0KSSBkb24ndCB0aGluayBhbnkgY29t cGlsZXIgd291bGQgY2hhbmdlIHRoaXMgY29kZSBnZW5lcmF0aW9uIGFuZCBzdWRkZW5seSBnZW5l cmF0ZSBzb21lDQpub24tYXRvbWljIGxvYWQgaW5zdHJ1Y3Rpb24gZm9yIGEgcHJvZ3JhbSB0aGF0 ICpvbmx5KiB1c2VzIHZvbGF0aWxlIHRvIGRvICJhdG9taWMiIGFjY2Vzc2VzLg0KQnV0IGEgZnV0 dXJlIGNvbXBpbGVyIGNvdWxkIGRldGVjdCB0aGUgbWl4IG9mIGF0b21pYyBhbmQgbm9uLWF0b21p YyBhY2Nlc3NlcyBhbmQgbWFyayB0aGlzDQpleHByZXNzaW9uIGFzIGNhdXNpbmcgdW5kZWZpbmVk IGJlaGF2aW91ciBhbmQgdGhhdCB3b3VsZCBoYXZlIGNvbnNlcXVlbmNlcyBmb3IgY29kZSBnZW5l cmF0aW9uLg0KICAgIA0KICAgIA0KICAgIEkgYWdyZWUgd2l0aCB5b3Ugb24gQzExIG1lbW9yeSBt b2RlbCBzZW1hbnRpY3MgdXNhZ2UuIFRoZSByZWFzb24gd2h5IEkNCiAgICBwcm9wb3NlIG5hbWUg Zm9yIHRoZSBmaWxlIGFzIHJ0ZV9yaW5nX2MxMV9tZW0uaCBhcyBEUERLIGl0IHNlbGYgZGlkIG5v dA0KICAgIGhhZCBkZWZpbml0aW9ucyBmb3IgbG9hZCBhY3F1aXJlIGFuZCBzdG9yZSByZWxlYXNl IHNlbWFudGljcy4NCiAgICBJIHdhcyBsb29raW5nIGZvciB0YWtpbmcgbG9hZCBhY3F1aXJlIGFu ZCBzdG9yZSByZWxlYXNlIHNlbWFudGljcw0KICAgIGZyb20gQzExIGluc3RlYWQgb2YgY3JlYXRp bmcgbmV3IEFQSSBsaWtlIExpbnV4IGtlcm5lbCBmb3IgRnJlZUJTRChBUElzDQogICAgbGlrZSAg YXRvbWljX2xvYWRfYWNxXzMyKCksIGF0b21pY19zdG9yZV9yZWxfMzIoKSkuIElmIHRoZSBmaWxl IG5hbWUgaXMgeW91cg0KICAgIGNvbmNlcm4gdGhlbiB3ZSBjb3VsZCBjcmVhdGUgbmV3IGFic3Ry YWN0aW9ucyBhcyB3ZWxsLiBUaGF0IHdvdWxkIGhlbHANCiAgICBleGl0aW5nIEtOSSBwcm9ibGVt IGFzIHdlbGwuDQpJIGFwcHJlY2lhdGUgeW91ciBlbWJyYWNlIG9mIHRoZSBDMTEgbWVtb3J5IG1v ZGVsLiBJIHRoaW5rIGl0IGlzIGJldHRlciBmb3IgZGVzY3JpYmluZw0KKGJvdGggdG8gdGhlIGNv bXBpbGVyIGFuZCB0byBodW1hbnMpIHdoaWNoIGFuZCBob3cgb2JqZWN0cyBhcmUgdXNlZCBmb3Ig c3luY2hyb25pc2F0aW9uLg0KDQpIb3dldmVyLCBJIGRvbid0IHRoaW5rIGFuIEFQSSBhcyB5b3Ug c3VnZ2VzdCAoYW5kIG90aGVycyBoYXZlIHN1Z2dlc3RlZCBiZWZvcmUsIGUuZy4gYXMNCmRvbmUg aW4gT0RQKSBpcyBhIGdvb2QgaWRlYS4gVGhlcmUgaXMgYW4gaW5maW5pdGUgYW1vdW50IG9mIHBv c3NpYmxlIGJhc2UgdHlwZXMsIGFuDQppbmNyZWFzaW5nIG51bWJlciBvZiBvcGVyYXRpb25zIGFu ZCBhIGJ1bmNoIG9mIGRpZmZlcmVudCBtZW1vcnkgb3JkZXJpbmdzLCBhICJjb21wbGV0ZSINCkFQ SSB3b3VsZCBiZSB2ZXJ5IGxhcmdlIGFuZCBkaWZmaWN1bHQgdG8gdGVzdCwgYW5kIG1vc3QgbWVt YmVycyBvZiB0aGUgQVBJIHdvdWxkIG5ldmVyIGJlIHVzZWQuDQoNCkdDQyBhbmQgQ2xhbmcgYm90 aCBzdXBwb3J0IHRoZSBfX2F0b21pYyBpbnRyaW5zaWNzLiBUaGlzIEFQSSBhdm9pZHMgdGhlIHBy b2JsZW1zIEkNCmRlc2NyaWJlZCBhYm92ZS4gT3Igd2UgY291bGQgdXNlIHRoZSBvZmZpY2lhbCBD MTEgc3ludGF4IChzdGRhdG9taWMuaCkuIEJ1dCB0aGVuIHdlDQpoYXZlIHRoZSBwcm9ibGVtIHdp dGggdXNpbmcgcHJlLUMxMSBjb21waWxlcnMuLi4NCg0KDQoNCiAgICANCiAgICBJIHRoaW5rLCBj dXJyZW50bHkgaXQgbWl4ZWQgdXNhZ2UgYmVjYXVzZSwgdGhlIHNhbWUgdmFyaWFibGUgZGVjbGFy YXRpb24NCiAgICB1c2VkIGZvciBDMTEgdnMgbm9uIEMxMSB1c2FnZS5JZGVhbGx5IHdlIHdvbnQg bmVlZCAidm9sYXRpbGUiIGZvciBDMTENCiAgICBjYXNlLiBFaXRoZXIgd2UgbmVlZCB0byBjaGFu Z2Ugb25seSB0byBDMTEgbW9kZSBPUiBoYXZlIEFQSXMgZm9yIA0KICAgIGF0b21pY19sb2FkX2Fj cV8oKSBhbmQgYXRvbWljX3N0b3JlX3JlbF8oKSB0byBhbGxvdyBib3RoIG1vZGVscyBsaWtlDQog ICAgTGludXgga2VybmVsIGFuZCBGcmVlQlNELg0KICAgIA0KICAgID4gDQogICAgPiAtLSBPbGEN CiAgICA+IA0KICAgID4gDQogICAgPiANCiAgICANCg0K