From: David Laight <David.Laight@ACULAB.COM>
To: "'Richard Leitner'" <richard.leitner@skidata.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Felipe Balbi <balbi@ti.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX
Date: Mon, 30 Jun 2014 08:41:18 +0000 [thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1726930B@AcuExch.aculab.com> (raw)
In-Reply-To: <20140630103616.620a13a2@lxbuild.skidata.net>
From: Of Richard Leitner
> Replaces all hardcoded ttyGS strings with the PREFIX macro.
> Due to the fact the strings are spread over different source files the
> PREFIX definition is moved to u_serial.h
Lots of changes like:
> - DBG(cdev, "acm ttyGS%d completion, err %d\n",
> - acm->port_num, req->status);
> + DBG(cdev, "acm %s%d completion, err %d\n",
> + PREFIX, acm->port_num, req->status);
I'm not sure this improves the code.
Do you see a need to ever change PREFIX?
Even if it is a reasonable change, the name PREFIX is hopeless.
It would have to be something like ACM_TTYNAME_PREFIX.
David
next prev parent reply other threads:[~2014-06-30 8:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 11:37 [PATCH] usb: gadget: serial: replace hardcoded ttyGS with PREFIX Richard Leitner
2014-06-27 17:46 ` Greg Kroah-Hartman
2014-06-30 6:32 ` Richard Leitner
2014-06-30 8:36 ` [PATCHv2] " Richard Leitner
2014-06-30 8:41 ` David Laight [this message]
2014-06-30 8:56 ` Richard Leitner
2014-06-30 9:08 ` David Laight
2014-06-30 11:23 ` Richard Leitner
2014-06-30 14:45 ` Greg Kroah-Hartman
2014-07-01 7:31 ` Richard Leitner
2014-07-01 15:39 ` Richard Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063D6719AE5E284EB5DD2968C1650D6D1726930B@AcuExch.aculab.com \
--to=david.laight@aculab.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=richard.leitner@skidata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.