From: David Laight <David.Laight@ACULAB.COM>
To: 'Alan Stern' <stern@rowland.harvard.edu>,
Hans de Goede <hdegoede@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH fix for 3.17] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands
Date: Mon, 15 Sep 2014 08:42:00 +0000 [thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6D17491F5F@AcuExch.aculab.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1409131009530.7476-100000@netrider.rowland.org>
From: Alan Stern
...
> > p = quirks;
> > while (*p) {
> > @@ -543,6 +544,9 @@ void usb_stor_adjust_quirks(struct usb_device *udev, unsigned long *fflags)
> > case 's':
> > f |= US_FL_SINGLE_LUN;
> > break;
> > + case 't':
> > + f |= US_FL_NO_ATA_1X;
> > + break;
> > case 'u':
> > f |= US_FL_IGNORE_UAS;
> > break;
>
> You must not add an aditional value for a module parameter without
> documenting it in Documentation/kernel-parameters.txt.
How can this work as a 'module parameter'?
I might want to use two different usb-scsi devices that have different
requirements.
David
next prev parent reply other threads:[~2014-09-15 8:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-13 10:19 [PATCH fix for 3.17 0/1] uas: Add a quirk for rejecting ATA_12 and ATA_16 Hans de Goede
2014-09-13 10:19 ` [PATCH fix for 3.17] uas: Add a quirk for rejecting ATA_12 and ATA_16 commands Hans de Goede
2014-09-13 14:11 ` Alan Stern
2014-09-15 8:42 ` David Laight [this message]
2014-09-15 11:12 ` Oliver Neukum
2014-09-15 14:56 ` Alan Stern
2014-09-15 13:21 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063D6719AE5E284EB5DD2968C1650D6D17491F5F@AcuExch.aculab.com \
--to=david.laight@aculab.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.