From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754882AbbLJR3c (ORCPT ); Thu, 10 Dec 2015 12:29:32 -0500 Received: from smtp-out6.electric.net ([192.162.217.194]:62613 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753571AbbLJR33 (ORCPT ); Thu, 10 Dec 2015 12:29:29 -0500 From: David Laight To: "'Eric Dumazet'" CC: "'Daniel Borkmann'" , Marcelo Ricardo Leitner , Eric Dumazet , "Dmitry Vyukov" , "David S. Miller" , "Alexey Kuznetsov" , James Morris , "Hideaki YOSHIFUJI" , Patrick McHardy , netdev , LKML , "Vlad Yasevich" , Neil Horman , "linux-sctp@vger.kernel.org" , syzkaller , Kostya Serebryany , "Alexander Potapenko" , Sasha Levin Subject: RE: [PATCH net] ipv6: sctp: clone options to avoid use after free Thread-Topic: [PATCH net] ipv6: sctp: clone options to avoid use after free Thread-Index: AQHRMpWwjulvUpSDiUGGxL2XGNkOVJ7Cy09wgAAEwACAAAg0QIAALy2NgAEcsDCAAD3fgIAAFQIw Date: Thu, 10 Dec 2015 17:27:22 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CBEAB36@AcuExch.aculab.com> References: <20151209145917.GA3884@mrl.redhat.com> <1449674706.9768.5.camel@edumazet-glaptop2.roam.corp.google.com> <063D6719AE5E284EB5DD2968C1650D6D1CBE9A61@AcuExch.aculab.com> <1449676782.9768.9.camel@edumazet-glaptop2.roam.corp.google.com> <063D6719AE5E284EB5DD2968C1650D6D1CBE9B1C@AcuExch.aculab.com> <566860BC.4040604@gmail.com> <56687EBB.5040108@iogearbox.net> <063D6719AE5E284EB5DD2968C1650D6D1CBEA7A3@AcuExch.aculab.com> <1449763097.9768.13.camel@edumazet-glaptop2.roam.corp.google.com> In-Reply-To: <1449763097.9768.13.camel@edumazet-glaptop2.roam.corp.google.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-Outbound-IP: 213.249.233.130 X-Env-From: David.Laight@ACULAB.COM X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tBAHTba0003051 From: Eric Dumazet > Sent: 10 December 2015 15:58 > > BTW, are you even using IPv6 SCTP sessions ? Our M3UA/SCTP protocol stack supports them and defaults to using IPv6 listening sockets for IPv4 connections. I very much doubt than any customers have used them yet. So most of the IPv6 connections will have been to ::1 during internal regression testing. We don't even try to set any IPv6 (or IPv4) options. Just SO_REUSEADDR, TCP/SCTP_NODELAY, SCTP_EVENTS, SCTP_INITMSG, SO_KEEPALIVE (tcp), IPV6_V6ONLY (if binding separate listeners), SCTP_SOCKOPT_BINX_ADD (WTF is this a 'socket option') and SO_LINGER (to get abortive close on SCTP connections on kernels before 3.18). David {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Laight Subject: RE: [PATCH net] ipv6: sctp: clone options to avoid use after free Date: Thu, 10 Dec 2015 17:27:22 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CBEAB36@AcuExch.aculab.com> References: <20151209145917.GA3884@mrl.redhat.com> <1449674706.9768.5.camel@edumazet-glaptop2.roam.corp.google.com> <063D6719AE5E284EB5DD2968C1650D6D1CBE9A61@AcuExch.aculab.com> <1449676782.9768.9.camel@edumazet-glaptop2.roam.corp.google.com> <063D6719AE5E284EB5DD2968C1650D6D1CBE9B1C@AcuExch.aculab.com> <566860BC.4040604@gmail.com> <56687EBB.5040108@iogearbox.net> <063D6719AE5E284EB5DD2968C1650D6D1CBEA7A3@AcuExch.aculab.com> <1449763097.9768.13.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: 'Daniel Borkmann' , Marcelo Ricardo Leitner , Eric Dumazet , "Dmitry Vyukov" , "David S. Miller" , "Alexey Kuznetsov" , James Morris , "Hideaki YOSHIFUJI" , Patrick McHardy , netdev , LKML , "Vlad Yasevich" , Neil Horman , "linux-sctp@vger.kernel.org" , syzkaller , Kostya Serebryany , "Alexander Potapenko" , Sasha Levin To: 'Eric Dumazet' Return-path: In-Reply-To: <1449763097.9768.13.camel@edumazet-glaptop2.roam.corp.google.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org RnJvbTogRXJpYyBEdW1hemV0DQo+IFNlbnQ6IDEwIERlY2VtYmVyIDIwMTUgMTU6NTgNCj4NCj4g QlRXLCBhcmUgeW91IGV2ZW4gdXNpbmcgSVB2NiBTQ1RQIHNlc3Npb25zID8NCg0KT3VyIE0zVUEv U0NUUCBwcm90b2NvbCBzdGFjayBzdXBwb3J0cyB0aGVtIGFuZCBkZWZhdWx0cyB0byB1c2luZw0K SVB2NiBsaXN0ZW5pbmcgc29ja2V0cyBmb3IgSVB2NCBjb25uZWN0aW9ucy4NCg0KSSB2ZXJ5IG11 Y2ggZG91YnQgdGhhbiBhbnkgY3VzdG9tZXJzIGhhdmUgdXNlZCB0aGVtIHlldC4NClNvIG1vc3Qg b2YgdGhlIElQdjYgY29ubmVjdGlvbnMgd2lsbCBoYXZlIGJlZW4gdG8gOjoxDQpkdXJpbmcgaW50 ZXJuYWwgcmVncmVzc2lvbiB0ZXN0aW5nLg0KDQpXZSBkb24ndCBldmVuIHRyeSB0byBzZXQgYW55 IElQdjYgKG9yIElQdjQpIG9wdGlvbnMuDQoNCkp1c3QgU09fUkVVU0VBRERSLCBUQ1AvU0NUUF9O T0RFTEFZLCBTQ1RQX0VWRU5UUywgU0NUUF9JTklUTVNHLA0KU09fS0VFUEFMSVZFICh0Y3ApLCBJ UFY2X1Y2T05MWSAoaWYgYmluZGluZyBzZXBhcmF0ZSBsaXN0ZW5lcnMpLA0KU0NUUF9TT0NLT1BU X0JJTlhfQUREIChXVEYgaXMgdGhpcyBhICdzb2NrZXQgb3B0aW9uJykgYW5kDQpTT19MSU5HRVIg KHRvIGdldCBhYm9ydGl2ZSBjbG9zZSBvbiBTQ1RQIGNvbm5lY3Rpb25zIG9uIGtlcm5lbHMNCmJl Zm9yZSAzLjE4KS4NCg0KCURhdmlkDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Laight Date: Thu, 10 Dec 2015 17:27:22 +0000 Subject: RE: [PATCH net] ipv6: sctp: clone options to avoid use after free Message-Id: <063D6719AE5E284EB5DD2968C1650D6D1CBEAB36@AcuExch.aculab.com> List-Id: References: <20151209145917.GA3884@mrl.redhat.com> <1449674706.9768.5.camel@edumazet-glaptop2.roam.corp.google.com> <063D6719AE5E284EB5DD2968C1650D6D1CBE9A61@AcuExch.aculab.com> <1449676782.9768.9.camel@edumazet-glaptop2.roam.corp.google.com> <063D6719AE5E284EB5DD2968C1650D6D1CBE9B1C@AcuExch.aculab.com> <566860BC.4040604@gmail.com> <56687EBB.5040108@iogearbox.net> <063D6719AE5E284EB5DD2968C1650D6D1CBEA7A3@AcuExch.aculab.com> <1449763097.9768.13.camel@edumazet-glaptop2.roam.corp.google.com> In-Reply-To: <1449763097.9768.13.camel@edumazet-glaptop2.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: 'Eric Dumazet' Cc: 'Daniel Borkmann' , Marcelo Ricardo Leitner , Eric Dumazet , Dmitry Vyukov , "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev , LKML , Vlad Yasevich , Neil Horman , "linux-sctp@vger.kernel.org" , syzkaller , Kostya Serebryany , Alexander Potapenko , Sasha Levin RnJvbTogRXJpYyBEdW1hemV0DQo+IFNlbnQ6IDEwIERlY2VtYmVyIDIwMTUgMTU6NTgNCj4NCj4g QlRXLCBhcmUgeW91IGV2ZW4gdXNpbmcgSVB2NiBTQ1RQIHNlc3Npb25zID8NCg0KT3VyIE0zVUEv U0NUUCBwcm90b2NvbCBzdGFjayBzdXBwb3J0cyB0aGVtIGFuZCBkZWZhdWx0cyB0byB1c2luZw0K SVB2NiBsaXN0ZW5pbmcgc29ja2V0cyBmb3IgSVB2NCBjb25uZWN0aW9ucy4NCg0KSSB2ZXJ5IG11 Y2ggZG91YnQgdGhhbiBhbnkgY3VzdG9tZXJzIGhhdmUgdXNlZCB0aGVtIHlldC4NClNvIG1vc3Qg b2YgdGhlIElQdjYgY29ubmVjdGlvbnMgd2lsbCBoYXZlIGJlZW4gdG8gOjoxDQpkdXJpbmcgaW50 ZXJuYWwgcmVncmVzc2lvbiB0ZXN0aW5nLg0KDQpXZSBkb24ndCBldmVuIHRyeSB0byBzZXQgYW55 IElQdjYgKG9yIElQdjQpIG9wdGlvbnMuDQoNCkp1c3QgU09fUkVVU0VBRERSLCBUQ1AvU0NUUF9O T0RFTEFZLCBTQ1RQX0VWRU5UUywgU0NUUF9JTklUTVNHLA0KU09fS0VFUEFMSVZFICh0Y3ApLCBJ UFY2X1Y2T05MWSAoaWYgYmluZGluZyBzZXBhcmF0ZSBsaXN0ZW5lcnMpLA0KU0NUUF9TT0NLT1BU X0JJTlhfQUREIChXVEYgaXMgdGhpcyBhICdzb2NrZXQgb3B0aW9uJykgYW5kDQpTT19MSU5HRVIg KHRvIGdldCBhYm9ydGl2ZSBjbG9zZSBvbiBTQ1RQIGNvbm5lY3Rpb25zIG9uIGtlcm5lbHMNCmJl Zm9yZSAzLjE4KS4NCg0KCURhdmlkDQoNCg=