From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752124AbaATLWn (ORCPT ); Mon, 20 Jan 2014 06:22:43 -0500 Received: from mx0.aculab.com ([213.249.233.131]:47496 "HELO mx0.aculab.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751853AbaATLWl (ORCPT ); Mon, 20 Jan 2014 06:22:41 -0500 From: David Laight To: "'walt'" , Sarah Sharp CC: Alan Stern , Greg Kroah-Hartman , Linux Kernel , "stable@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-scsi@vger.kernel.org" Subject: RE: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst [NEW HARDWARE] Thread-Topic: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst [NEW HARDWARE] Thread-Index: AQHPELhlWPjDYPI+s0G+DC1zL1oFlJqEeIcAgABE3oCABEGkcIAB9dCAgAKL5bA= Date: Mon, 20 Jan 2014 11:21:14 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D45FF6C@AcuExch.aculab.com> References: <20140109235045.GA17660@xanatos> <52D4791B.3030309@gmail.com> <20140114172056.GB12126@xanatos> <52D5ABBD.7090202@gmail.com> <063D6719AE5E284EB5DD2968C1650D6D45EDA3@AcuExch.aculab.com> <52DAE2BF.7020208@gmail.com> In-Reply-To: <52DAE2BF.7020208@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s0KBMlVC003177 From: walt > On 01/17/2014 06:34 AM, David Laight wrote: > > > Can you try the patch I posted that stops the ownership on LINK TRBs > > being changed before that on the linked-to TRB? > > Please disregard my earlier post about the patch not applying cleanly. > That was the usual html corruption, so I found the original on the usb > list and it was okay. > > Sadly, the patch didn't fix the ASMedia lockup behavior, however :( > > I did notice that the lockup occurred only when copying *to* the usb3 > drive, and not when copying from it. I think that may be new behavior > but I can't swear to it. Consistent with another report that says that ethernet worked provided that TSO was disabled (ie no sg tx). (Without the patch to delay he ownership change on link trbs it didn't work at all.) A guess... In queue_bulk_sg_tx() try calling xhci_v1_0_td_remainder() instead of xhci_td_remainder(). You can try that on top of either of my other patches. David {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: David Laight To: 'walt' , Sarah Sharp CC: Alan Stern , Greg Kroah-Hartman , Linux Kernel , "stable@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-scsi@vger.kernel.org" Subject: RE: [PATCH 3.12 033/118] usb: xhci: Link TRB must not occur within a USB payload burst [NEW HARDWARE] Date: Mon, 20 Jan 2014 11:21:14 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6D45FF6C@AcuExch.aculab.com> References: <20140109235045.GA17660@xanatos> <52D4791B.3030309@gmail.com> <20140114172056.GB12126@xanatos> <52D5ABBD.7090202@gmail.com> <063D6719AE5E284EB5DD2968C1650D6D45EDA3@AcuExch.aculab.com> <52DAE2BF.7020208@gmail.com> In-Reply-To: <52DAE2BF.7020208@gmail.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: RnJvbTogd2FsdCANCj4gT24gMDEvMTcvMjAxNCAwNjozNCBBTSwgRGF2aWQgTGFpZ2h0IHdyb3Rl Og0KPiANCj4gPiBDYW4geW91IHRyeSB0aGUgcGF0Y2ggSSBwb3N0ZWQgdGhhdCBzdG9wcyB0aGUg b3duZXJzaGlwIG9uIExJTksgVFJCcw0KPiA+IGJlaW5nIGNoYW5nZWQgYmVmb3JlIHRoYXQgb24g dGhlIGxpbmtlZC10byBUUkI/DQo+IA0KPiBQbGVhc2UgZGlzcmVnYXJkIG15IGVhcmxpZXIgcG9z dCBhYm91dCB0aGUgcGF0Y2ggbm90IGFwcGx5aW5nIGNsZWFubHkuDQo+IFRoYXQgd2FzIHRoZSB1 c3VhbCBodG1sIGNvcnJ1cHRpb24sIHNvIEkgZm91bmQgdGhlIG9yaWdpbmFsIG9uIHRoZSB1c2IN Cj4gbGlzdCBhbmQgaXQgd2FzIG9rYXkuDQo+IA0KPiBTYWRseSwgdGhlIHBhdGNoIGRpZG4ndCBm aXggdGhlIEFTTWVkaWEgbG9ja3VwIGJlaGF2aW9yLCBob3dldmVyIDooDQo+IA0KPiBJIGRpZCBu b3RpY2UgdGhhdCB0aGUgbG9ja3VwIG9jY3VycmVkIG9ubHkgd2hlbiBjb3B5aW5nICp0byogdGhl IHVzYjMNCj4gZHJpdmUsIGFuZCBub3Qgd2hlbiBjb3B5aW5nIGZyb20gaXQuICBJIHRoaW5rIHRo YXQgbWF5IGJlIG5ldyBiZWhhdmlvcg0KPiBidXQgSSBjYW4ndCBzd2VhciB0byBpdC4NCg0KQ29u c2lzdGVudCB3aXRoIGFub3RoZXIgcmVwb3J0IHRoYXQgc2F5cyB0aGF0IGV0aGVybmV0IHdvcmtl ZCBwcm92aWRlZA0KdGhhdCBUU08gd2FzIGRpc2FibGVkIChpZSBubyBzZyB0eCkuDQooV2l0aG91 dCB0aGUgcGF0Y2ggdG8gZGVsYXkgaGUgb3duZXJzaGlwIGNoYW5nZSBvbiBsaW5rIHRyYnMgaXQg ZGlkbid0DQp3b3JrIGF0IGFsbC4pDQoNCkEgZ3Vlc3MuLi4NCg0KSW4gcXVldWVfYnVsa19zZ190 eCgpIHRyeSBjYWxsaW5nIHhoY2lfdjFfMF90ZF9yZW1haW5kZXIoKSBpbnN0ZWFkDQpvZiB4aGNp X3RkX3JlbWFpbmRlcigpLg0KDQpZb3UgY2FuIHRyeSB0aGF0IG9uIHRvcCBvZiBlaXRoZXIgb2Yg bXkgb3RoZXIgcGF0Y2hlcy4NCg0KCURhdmlkDQoNCg==