All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Philippe Bergheaud' <felix@linux.vnet.ibm.com>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Cc: "mikey@neuling.org" <mikey@neuling.org>,
	"mrochs@linux.vnet.ibm.com" <mrochs@linux.vnet.ibm.com>,
	"fbarrat@linux.vnet.ibm.com" <fbarrat@linux.vnet.ibm.com>,
	"manoj@linux.vnet.ibm.com" <manoj@linux.vnet.ibm.com>,
	"ukrishn@linux.vnet.ibm.com" <ukrishn@linux.vnet.ibm.com>,
	"imunsie@au1.ibm.com" <imunsie@au1.ibm.com>
Subject: RE: [PATCH] cxl: Use fixed width predefined types in data structure.
Date: Thu, 4 Aug 2016 14:26:26 +0000	[thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6D5F509628@AcuExch.aculab.com> (raw)
In-Reply-To: <1470318964-19995-1-git-send-email-felix@linux.vnet.ibm.com>

From: Philippe Bergheaud
> Sent: 04 August 2016 14:56
> This patch fixes a regression introduced by commit b810253.
> It substitutes the type __u8 to u8 in the uapi header cxl.h,
> because the latter is not always defined in userland build
> environments, in particular when cross-compiling libcxl on
> x86_64 linux machines (RHEL6.7 and Ubuntu 16.04).
>=20
> It also makes the definition of cxl_event_afu_driver_reserved
> more consistent with the other definitions in the header file.
...
> diff --git a/include/uapi/misc/cxl.h b/include/uapi/misc/cxl.h
> index cbae529..180d526 100644
> --- a/include/uapi/misc/cxl.h
> +++ b/include/uapi/misc/cxl.h
> @@ -136,8 +136,8 @@ struct cxl_event_afu_driver_reserved {
>  	 *
>  	 * Of course the contents will be ABI, but that's up the AFU driver.
>  	 */
> -	size_t data_size;
> -	u8 data[];
> +	__u32 data_size;
> +	__u8 data[];
>  };

You've just changed 'data_size' from 64bit to 32bit (on 64bit systems).
This isn't mentioned in the commit message and changes the API.

I've NFI what it need to be...

	David

  reply	other threads:[~2016-08-04 14:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-04 13:56 [PATCH] cxl: Use fixed width predefined types in data structure Philippe Bergheaud
2016-08-04 14:26 ` David Laight [this message]
2016-08-05  7:09   ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=063D6719AE5E284EB5DD2968C1650D6D5F509628@AcuExch.aculab.com \
    --to=david.laight@aculab.com \
    --cc=fbarrat@linux.vnet.ibm.com \
    --cc=felix@linux.vnet.ibm.com \
    --cc=imunsie@au1.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=manoj@linux.vnet.ibm.com \
    --cc=mikey@neuling.org \
    --cc=mrochs@linux.vnet.ibm.com \
    --cc=ukrishn@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.