All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: "'Randy Li'" <ayaka@soulik.info>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Cc: "felipe.balbi@linux.intel.com" <felipe.balbi@linux.intel.com>,
	"John.Youn@synopsys.com" <John.Youn@synopsys.com>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"heiko@sntech.de" <heiko@sntech.de>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-rockchip@lists.infradead.org" 
	<linux-rockchip@lists.infradead.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"kishon@ti.com" <kishon@ti.com>,
	"randy.li@rock-chips.com" <randy.li@rock-chips.com>
Subject: RE: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform
Date: Mon, 5 Sep 2016 13:35:56 +0000	[thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6DB00F483E@AcuExch.aculab.com> (raw)
In-Reply-To: <1472939729-15187-4-git-send-email-ayaka@soulik.info>

From: Randy Li
> Sent: 03 September 2016 22:55
...
> +			if (of_device_is_compatible(np, "rockchip,rk3288-usb")
> +					&& (NULL != hsotg->phy->ops->reset))
> +				hsotg->phy->ops->reset(hsotg->phy);
> +

Is this the only place ops->reset() is called?
Probably much better to check it first.

			if (hsotg->phy->ops->reset
					&& of_device_is_compatible(np, "rockchip,rk3288-usb")
				hsotg->phy->ops->reset(hsotg->phy);

	David

WARNING: multiple messages have this Message-ID
From: David Laight <David.Laight-ZS65k/vG3HxXrIkS9f7CXA@public.gmane.org>
To: 'Randy Li' <ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>,
	"linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: "mark.rutland-5wv7dgnIgG8@public.gmane.org"
	<mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org"
	<heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
	"felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org"
	<felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
	"gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org"
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	"randy.li-TNX95d0MmH7DzftRWevZcw@public.gmane.org"
	<randy.li-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"John.Youn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org"
	<John.Youn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>,
	"linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
	<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"kishon-l0cyMroinI0@public.gmane.org"
	<kishon-l0cyMroinI0@public.gmane.org>
Subject: RE: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform
Date: Mon, 5 Sep 2016 13:35:56 +0000	[thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6DB00F483E@AcuExch.aculab.com> (raw)
In-Reply-To: <1472939729-15187-4-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>

From: Randy Li
> Sent: 03 September 2016 22:55
...
> +			if (of_device_is_compatible(np, "rockchip,rk3288-usb")
> +					&& (NULL != hsotg->phy->ops->reset))
> +				hsotg->phy->ops->reset(hsotg->phy);
> +

Is this the only place ops->reset() is called?
Probably much better to check it first.

			if (hsotg->phy->ops->reset
					&& of_device_is_compatible(np, "rockchip,rk3288-usb")
				hsotg->phy->ops->reset(hsotg->phy);

	David

  parent reply	other threads:[~2016-09-05 13:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-03 21:55 [PATCH v7 0/4] the fix for the USB HOST1 at " Randy Li
2016-09-03 21:55 ` Randy Li
2016-09-03 21:55 ` [PATCH v7 1/4] phy: Add reset callback Randy Li
2016-09-03 21:55   ` Randy Li
2016-09-03 21:55 ` [PATCH v7 2/4] phy: rockchip-usb: use rockchip_usb_phy_reset to reset phy during wakeup Randy Li
2016-09-03 21:55   ` Randy Li
2016-09-03 21:55 ` [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform Randy Li
2016-09-03 21:55   ` Randy Li
2016-09-03 22:08   ` Sergei Shtylyov
2016-09-03 22:08     ` Sergei Shtylyov
2016-09-05 13:35   ` David Laight [this message]
2016-09-05 13:35     ` David Laight
2016-09-05 23:38     ` Ayaka
2016-09-05 23:38       ` Ayaka
2016-09-06  5:14   ` Kishon Vijay Abraham I
2016-09-06  5:14     ` Kishon Vijay Abraham I
2016-09-06 18:54     ` John Youn
2016-09-06 18:54       ` John Youn
2016-09-07  1:19       ` Ayaka
2016-09-07  1:19         ` Ayaka
2016-09-07  2:02         ` John Youn
2016-09-07  2:02           ` John Youn
2016-09-03 21:55 ` [PATCH v7 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset Randy Li
2016-09-03 21:55   ` Randy Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=063D6719AE5E284EB5DD2968C1650D6DB00F483E@AcuExch.aculab.com \
    --to=david.laight@aculab.com \
    --cc=John.Youn@synopsys.com \
    --cc=ayaka@soulik.info \
    --cc=devicetree@vger.kernel.org \
    --cc=felipe.balbi@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heiko@sntech.de \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=randy.li@rock-chips.com \
    --cc=robh+dt@kernel.org \
    --subject='RE: [PATCH v7 3/4] usb: dwc2: assert phy reset when waking up in rk3288 platform' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.