From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751019AbdCNLFL convert rfc822-to-8bit (ORCPT ); Tue, 14 Mar 2017 07:05:11 -0400 Received: from smtp-out6.electric.net ([192.162.217.184]:57740 "EHLO smtp-out6.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbdCNLFH (ORCPT ); Tue, 14 Mar 2017 07:05:07 -0400 From: David Laight To: "'Doug Berger'" , "f.fainelli@gmail.com" CC: "robh+dt@kernel.org" , "mark.rutland@arm.com" , "davem@davemloft.net" , "rafal@milecki.pl" , "xow@google.com" , "joel@jms.id.au" , "jon.mason@broadcom.com" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "pgynther@google.com" , "jaedon.shin@gmail.com" Subject: RE: [PATCH net-next 09/12] net: bcmgenet: return EOPNOTSUPP for unknown ioctl commands Thread-Topic: [PATCH net-next 09/12] net: bcmgenet: return EOPNOTSUPP for unknown ioctl commands Thread-Index: AQHSnFwC/BMw1kvNYEmw2SMdGQx8MaGULB6Q Date: Tue, 14 Mar 2017 11:04:54 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6DCFFB052E@AcuExch.aculab.com> References: <20170314004142.4746-1-opendmb@gmail.com> <20170314004142.4746-10-opendmb@gmail.com> In-Reply-To: <20170314004142.4746-10-opendmb@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Outbound-IP: 213.249.233.130 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuExch.aculab.com X-TLS: TLSv1:AES128-SHA:128 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Doug Berger > Sent: 14 March 2017 00:42 > This commit changes the ioctl handling behavior to return the > EOPNOTSUPP error code instead of the EINVAL error code when an > unknown ioctl command value is detected. > > It also removes some redundant parsing of the ioctl command value > and allows the SIOCSHWTSTAMP value to be handled. A better description would seem to be: Remove checks on ioctl command and just forward all ioctl requests to phy_mii_ioctl(). I also thought the 'generic' response to an unknown ioctl command was ENOTTY. David