From: David Laight <David.Laight@ACULAB.COM>
To: 'Gavin Shan' <gwshan@linux.vnet.ibm.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"joe@perches.com" <joe@perches.com>,
"kubakici@wp.pl" <kubakici@wp.pl>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: RE: [PATCH v4 net-next 04/10] net/ncsi: Ethtool operation to get NCSI topology
Date: Mon, 8 May 2017 12:40:28 +0000 [thread overview]
Message-ID: <063D6719AE5E284EB5DD2968C1650D6DCFFE7192@AcuExch.aculab.com> (raw)
In-Reply-To: <20170508001955.GA5787@gwshan>
From: Gavin Shan
> Sent: 08 May 2017 01:20
...
> >Why 16 bits?
> >You are just making life hard for the compiler and possibly generating
> >random padding.
> >
>
> It's because there are 256 NCSI channels to maximal degree. So 16-bits
> is the minial data width to hold it in signed format. Yes, I think
> __s32 would be better in this case. However, I would like to discard
> the negotiation mechanism in next respin.
Just because the domain of a value fits in 16 bits doesn't mean
that a 16bit type is appropriate.
It is generally much better to use 32 (aka machine word) sized
items unless you have an array or are trying to fit a lot of
items into a small memory area.
David
next prev parent reply other threads:[~2017-05-08 12:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 4:44 [PATCH v4 net-next 00/10] net/ncsi: Add debugging functionality Gavin Shan
2017-05-03 4:44 ` [PATCH v4 net-next 01/10] net/ncsi: Disable HWA mode when no channels are found Gavin Shan
2017-05-03 4:44 ` [PATCH v4 net-next 02/10] net/ncsi: Properly track channel monitor timer state Gavin Shan
2017-05-03 4:44 ` [PATCH v4 net-next 03/10] net/ncsi: Enforce failover on link monitor timeout Gavin Shan
2017-05-03 4:44 ` [PATCH v4 net-next 04/10] net/ncsi: Ethtool operation to get NCSI topology Gavin Shan
2017-05-04 0:49 ` Andrew Lunn
2017-05-04 1:36 ` Gavin Shan
2017-05-04 5:19 ` Stephen Hemminger
2017-05-04 6:15 ` Gavin Shan
2017-05-04 9:31 ` David Laight
2017-05-08 0:19 ` Gavin Shan
2017-05-08 12:40 ` David Laight [this message]
2017-05-04 5:21 ` Stephen Hemminger
2017-05-04 6:17 ` Gavin Shan
2017-05-03 4:44 ` [PATCH v4 net-next 05/10] net/ncsi: Ethtool operation to get NCSI channel info Gavin Shan
2017-05-03 20:53 ` kbuild test robot
2017-05-03 4:44 ` [PATCH v4 net-next 06/10] net/ncsi: Ethtool operation to get NCSI hw statistics Gavin Shan
2017-05-03 12:47 ` Andrew Lunn
2017-05-03 13:18 ` David Miller
2017-05-04 0:05 ` Gavin Shan
2017-05-04 0:16 ` David Miller
2017-05-04 0:38 ` Gavin Shan
2017-05-04 0:34 ` Andrew Lunn
2017-05-04 0:55 ` Gavin Shan
2017-05-03 4:44 ` [PATCH v4 net-next 07/10] net/ncsi: Ethtool operation to get NCSI sw statistics Gavin Shan
2017-05-03 4:44 ` [PATCH v4 net-next 08/10] net/ncsi: Support NCSI packet generation Gavin Shan
2017-05-03 12:52 ` Andrew Lunn
2017-05-04 6:31 ` Gavin Shan
2017-05-04 12:00 ` Andrew Lunn
2017-05-08 0:25 ` Gavin Shan
2017-05-08 0:56 ` Andrew Lunn
2017-05-08 6:27 ` Gavin Shan
2017-05-03 4:44 ` [PATCH v4 net-next 09/10] net/ncsi: No error report on DP response to non-existing package Gavin Shan
2017-05-03 4:44 ` [PATCH v4 net-next 10/10] net/ncsi: Fix length of GVI response packet Gavin Shan
2017-05-03 5:25 ` [PATCH v4 net-next 00/10] net/ncsi: Add debugging functionality David Miller
2017-05-04 0:06 ` Gavin Shan
2017-05-03 12:58 ` Andrew Lunn
2017-05-04 0:09 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=063D6719AE5E284EB5DD2968C1650D6DCFFE7192@AcuExch.aculab.com \
--to=david.laight@aculab.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=joe@perches.com \
--cc=kubakici@wp.pl \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.