From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dhinakaran Pandiyan Subject: Re: [PATCH] drm/framebuffer: Expose only modifiers that support at least a format Date: Tue, 06 Nov 2018 11:54:45 -0800 Message-ID: <0671193e8b85311bec4b2738d28d132e0cf01838.camel@intel.com> References: <20181106024434.12322-1-dhinakaran.pandiyan@intel.com> <20181106141325.GU9144@intel.com> Reply-To: dhinakaran.pandiyan@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181106141325.GU9144@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAyMDE4LTExLTA2IGF0IDE2OjEzICswMjAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6 Cj4gT24gTW9uLCBOb3YgMDUsIDIwMTggYXQgMDY6NDQ6MzRQTSAtMDgwMCwgRGhpbmFrYXJhbiBQ YW5kaXlhbiB3cm90ZToKPiA+IEFsbG93cyBkcml2ZXJzIHRvIHBhc3MgYSBsYXJnZXIgbW9kaWZp ZXIgYXJyYXksIHRoZXJlYnkgYXZvaWRpbmcKPiA+IGRlY2xhcmF0aW9ucyBvZiBzdGF0aWMgbW9k aWZpZXIgYXJyYXlzIHRoYXQgYXJlIG9ubHkgc2xpZ2h0Cj4gPiBkaWZmZXJlbnQKPiA+IGZvciBl YWNoIHBsYW5lLgo+ID4gCj4gPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ ID4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g PiBTdWdnZXN0ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFu LnBhbmRpeWFuQGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fcGxh bmUuYyB8IDM1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0KPiA+IC0tLS0KPiA+ICAx IGZpbGUgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiA+IAo+ID4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcGxhbmUuYwo+ID4gYi9kcml2ZXJzL2dw dS9kcm0vZHJtX3BsYW5lLmMKPiA+IGluZGV4IDFmYTk4YmQxMjAwMy4uMTU0NmZmYmY4ZTM2IDEw MDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZS5jCj4gPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMKPiA+IEBAIC0xNzksOCArMTc5LDggQEAgaW50IGRybV91 bml2ZXJzYWxfcGxhbmVfaW5pdChzdHJ1Y3QgZHJtX2RldmljZQo+ID4gKmRldiwgc3RydWN0IGRy bV9wbGFuZSAqcGxhbmUsCj4gPiAgCQkJICAgICBjb25zdCBjaGFyICpuYW1lLCAuLi4pCj4gPiAg ewo+ID4gIAlzdHJ1Y3QgZHJtX21vZGVfY29uZmlnICpjb25maWcgPSAmZGV2LT5tb2RlX2NvbmZp ZzsKPiA+IC0JdW5zaWduZWQgaW50IGZvcm1hdF9tb2RpZmllcl9jb3VudCA9IDA7Cj4gPiAtCWlu dCByZXQ7Cj4gPiArCXVuc2lnbmVkIGludCBmb3JtYXRfbW9kaWZpZXJfY291bnQsIGluX21vZGlm aWVyX2NvdW50ID0gMDsKPiA+ICsJaW50IHJldCwgaTsKPiA+ICAKPiA+ICAJLyogcGxhbmUgaW5k ZXggaXMgdXNlZCB3aXRoIDMyYml0IGJpdG1hc2tzICovCj4gPiAgCWlmIChXQVJOX09OKGNvbmZp Zy0+bnVtX3RvdGFsX3BsYW5lID49IDMyKSkKPiA+IEBAIC0yMTYsMjIgKzIxNiw0MyBAQCBpbnQg ZHJtX3VuaXZlcnNhbF9wbGFuZV9pbml0KHN0cnVjdAo+ID4gZHJtX2RldmljZSAqZGV2LCBzdHJ1 Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiA+ICAKPiA+ICAJaWYgKGZvcm1hdF9tb2RpZmllcnMpIHsK PiA+ICAJCWNvbnN0IHVpbnQ2NF90ICp0ZW1wX21vZGlmaWVycyA9IGZvcm1hdF9tb2RpZmllcnM7 Cj4gPiArCj4gPiAgCQl3aGlsZSAoKnRlbXBfbW9kaWZpZXJzKysgIT0gRFJNX0ZPUk1BVF9NT0Rf SU5WQUxJRCkKPiA+IC0JCQlmb3JtYXRfbW9kaWZpZXJfY291bnQrKzsKPiA+ICsJCQlpbl9tb2Rp Zmllcl9jb3VudCsrOwo+ID4gIAl9Cj4gPiAgCj4gPiAtCXBsYW5lLT5tb2RpZmllcl9jb3VudCA9 IGZvcm1hdF9tb2RpZmllcl9jb3VudDsKPiA+IC0JcGxhbmUtPm1vZGlmaWVycyA9IGttYWxsb2Nf YXJyYXkoZm9ybWF0X21vZGlmaWVyX2NvdW50LAo+ID4gKwlwbGFuZS0+bW9kaWZpZXJzID0ga21h bGxvY19hcnJheShpbl9tb2RpZmllcl9jb3VudCwKPiA+ICAJCQkJCSBzaXplb2YoZm9ybWF0X21v ZGlmaWVyc1swXSksCj4gPiAgCQkJCQkgR0ZQX0tFUk5FTCk7Cj4gPiAgCj4gPiAtCWlmIChmb3Jt YXRfbW9kaWZpZXJfY291bnQgJiYgIXBsYW5lLT5tb2RpZmllcnMpIHsKPiA+ICsJaWYgKGluX21v ZGlmaWVyX2NvdW50ICYmICFwbGFuZS0+bW9kaWZpZXJzKSB7Cj4gPiAgCQlEUk1fREVCVUdfS01T KCJvdXQgb2YgbWVtb3J5IHdoZW4gYWxsb2NhdGluZyBwbGFuZVxuIik7Cj4gPiAgCQlrZnJlZShw bGFuZS0+Zm9ybWF0X3R5cGVzKTsKPiA+ICAJCWRybV9tb2RlX29iamVjdF91bnJlZ2lzdGVyKGRl diwgJnBsYW5lLT5iYXNlKTsKPiA+ICAJCXJldHVybiAtRU5PTUVNOwo+ID4gIAl9Cj4gPiAgCj4g PiArCWZvciAoaSA9IDAsIGZvcm1hdF9tb2RpZmllcl9jb3VudCA9IDA7IGkgPCBpbl9tb2RpZmll cl9jb3VudDsKPiA+IGkrKykgewo+ID4gKwkJaW50IGo7Cj4gPiArCj4gPiArCQlmb3IgKGogPSAw OyBmdW5jcy0+Zm9ybWF0X21vZF9zdXBwb3J0ZWQgJiYgaiA8Cj4gPiBmb3JtYXRfY291bnQ7IGor KykKPiA+ICsJCQlpZiAoZnVuY3MtPmZvcm1hdF9tb2Rfc3VwcG9ydGVkKHBsYW5lLAo+ID4gZm9y bWF0c1tqXSwKPiA+ICsJCQkJCQkJZm9ybWF0X21vZGlmaWVyCj4gPiBzW2ldKSkKPiA+ICsJCQkJ YnJlYWs7Cj4gPiArCj4gPiArCQlpZiAoaiA8IGZvcm1hdF9jb3VudCkKPiA+ICsJCQlwbGFuZS0+ bW9kaWZpZXJzW2Zvcm1hdF9tb2RpZmllcl9jb3VudCsrXSA9Cj4gPiArCQkJCWZvcm1hdF9tb2Rp ZmllcnNbaV07Cj4gPiArCX0KPiA+ICsKPiA+ICsJaWYgKGZvcm1hdF9tb2RpZmllcl9jb3VudCA8 IGluX21vZGlmaWVyX2NvdW50KSB7Cj4gPiArCQlzaXplX3Qgc2l6ZTsKPiA+ICsKPiA+ICsJCXNp emUgPSBmb3JtYXRfbW9kaWZpZXJfY291bnQgKgo+ID4gc2l6ZW9mKGZvcm1hdF9tb2RpZmllcnNb MF0pOwo+ID4gKwkJcGxhbmUtPm1vZGlmaWVycyA9IGtyZWFsbG9jKHBsYW5lLT5tb2RpZmllcnMs IHNpemUsCj4gPiBHRlBfS0VSTkVMKTsKPiAKPiBTaG91bGQgY2hlY2sgdGhhdCB0aGUgcmVhbGxv YyBhY3R1YWxseSBzdWNjZWVkZWQuCkRpZG4ndCBzZWUgYSBmYWlsdXJlIHBhdGggZm9yIG5ldyBz aXplIHNtYWxsZXIgdGhhbiBvbGQsIHRoZSByZXR1cm4gaXMKdGhlIHNhbWUgcG9pbnRlciBwYXNz ZWQgdG8ga3JlYWxsb2MoKS4KCj4gCj4gQW5kIEkgdGhpbmsgd2UgbWlnaHQgd2FudCB0byBnaXZl IHRoaXMgc2FtZSB0cmVhdG1lbnQgdG8gcGxhbmUtCj4gPmZvcm1hdHNbXQo+IGFzIHdlbGwuCj4g Cj4gQW5kIHBlcmhhcHMgd2UgY291bGQgZXZlbiB0aHJvdyBvdXQgcGxhbmUtPm1vZGlmaWVyc1td IGFuZCBqdXN0IHJlbHkKPiBvbgo+IHRoZSBJTl9GT1JNQVRTIGJsb2IgZXhjbHVzaXZlbHk/IEht bS4gTG9va3MgbGlrZSB0aGF0IGlzIG5vdCBnZXR0aW5nCj4gZnVsbHkKPiBwb3B1bGF0ZWQgdW5s ZXNzIHRoZSBkcml2ZXIgaGFzIHByb3ZpZGVkIC5mb3JtYXRfbW9kX3N1cHBvcnRlZCgpLiBOb3QK PiBzdXJlIHdoeSB0aGF0IGlzLCBhbmQgbm90IHN1cmUgd2hhdCB1c2Vyc3BhY2UgaXMgc3VwcG9z ZWQgdG8gZG8gd2l0aAo+IGEKPiBwYXJ0aWFsbHkgZmlsbGVkIGJsb2IgbGlrZSB0aGF0LiBJJ20g dGhpbmtpbmcgd2Ugc2hvdWxkbid0IGV2ZW4KPiBhdHRhY2gKPiB0aGUgcHJvcGVydHkgdG8gdGhl IHBsYW5lIGluIHRoYXQgY2FzZS4KClNob3VsZG4ndCBpdCBjb3B5IHRoZSBtb2RpZmllciBhcnJh eSBpbnRvIHRoZSBibG9iIGFuZCBtYXJrIGFsbCBmb3JtYXRzCmFzIHN1cHBvcnRlZD8gZHJtX3Bs YW5lX2NoZWNrX3BpeGVsX2Zvcm1hdCgpIHNlZW1zIHRvIGFsbG93IGFueSB2YWxpZApmb3JtYXQg Zm9yIGEgbW9kaWZpZXIgaW4gdGhpcyBjYXNlLgoKCi1ESwoKPiAKPiA+ICsJfQo+ID4gKwlwbGFu ZS0+bW9kaWZpZXJfY291bnQgPSBmb3JtYXRfbW9kaWZpZXJfY291bnQ7Cj4gPiArCj4gPiAgCWlm IChuYW1lKSB7Cj4gPiAgCQl2YV9saXN0IGFwOwo+ID4gIAo+ID4gQEAgLTI1MSw4ICsyNzIsNiBA QCBpbnQgZHJtX3VuaXZlcnNhbF9wbGFuZV9pbml0KHN0cnVjdCBkcm1fZGV2aWNlCj4gPiAqZGV2 LCBzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiA+ICAKPiA+ICAJbWVtY3B5KHBsYW5lLT5mb3Jt YXRfdHlwZXMsIGZvcm1hdHMsIGZvcm1hdF9jb3VudCAqCj4gPiBzaXplb2YodWludDMyX3QpKTsK PiA+ICAJcGxhbmUtPmZvcm1hdF9jb3VudCA9IGZvcm1hdF9jb3VudDsKPiA+IC0JbWVtY3B5KHBs YW5lLT5tb2RpZmllcnMsIGZvcm1hdF9tb2RpZmllcnMsCj4gPiAtCSAgICAgICBmb3JtYXRfbW9k aWZpZXJfY291bnQgKiBzaXplb2YoZm9ybWF0X21vZGlmaWVyc1swXSkpOwo+ID4gIAlwbGFuZS0+ cG9zc2libGVfY3J0Y3MgPSBwb3NzaWJsZV9jcnRjczsKPiA+ICAJcGxhbmUtPnR5cGUgPSB0eXBl Owo+ID4gIAo+ID4gLS0gCj4gPiAyLjE0LjEKPiAKPiAKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=