From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2NYW-00051p-PB for qemu-devel@nongnu.org; Thu, 03 Nov 2016 15:20:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2NYT-0000qc-IA for qemu-devel@nongnu.org; Thu, 03 Nov 2016 15:20:08 -0400 Received: from mail-oi0-x234.google.com ([2607:f8b0:4003:c06::234]:33920) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c2NYT-0000qG-D4 for qemu-devel@nongnu.org; Thu, 03 Nov 2016 15:20:05 -0400 Received: by mail-oi0-x234.google.com with SMTP id 62so105907583oif.1 for ; Thu, 03 Nov 2016 12:20:05 -0700 (PDT) Sender: Richard Henderson References: <1478121319-31986-1-git-send-email-laurent@vivier.eu> <1478121319-31986-4-git-send-email-laurent@vivier.eu> <5d3713b1-c98e-d165-35b7-44b5ec616ec5@twiddle.net> From: Richard Henderson Message-ID: <06734d89-0bb5-c8eb-02e8-07acbb129185@twiddle.net> Date: Thu, 3 Nov 2016 13:20:02 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/3] target-m68k: add cas/cas2 ops List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier , qemu-devel@nongnu.org Cc: schwab@linux-m68k.org, agraf@suse.de, gerg@uclinux.org On 11/03/2016 12:03 PM, Laurent Vivier wrote: >> CC_OP_CMPW for cas2w. > > It was working because I have used helper_be_ldsw_mmu() to load values, > is it better to use helper_be_lduw_mmu with CC_OP_CMPW? IIRC, one needs the extra sign-extension here: case CC_OP_CMPB: \ case CC_OP_CMPW: \ case CC_OP_CMPL: \ src1 = n; \ src2 = v; \ res = EXTSIGN(src1 - src2, op - CC_OP_CMPB); \ to get all of the flags correct, even though just Z would be correct without. r~