From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54623C4363D for ; Fri, 2 Oct 2020 11:05:41 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9BDF20708 for ; Fri, 2 Oct 2020 11:05:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="FRJUVZqM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9BDF20708 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.1911.5758 (Exim 4.92) (envelope-from ) id 1kOIsS-0000fE-Mi; Fri, 02 Oct 2020 11:05:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1911.5758; Fri, 02 Oct 2020 11:05:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kOIsS-0000f7-JV; Fri, 02 Oct 2020 11:05:28 +0000 Received: by outflank-mailman (input) for mailman id 1911; Fri, 02 Oct 2020 11:05:27 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kOIsR-0000f1-8T for xen-devel@lists.xenproject.org; Fri, 02 Oct 2020 11:05:27 +0000 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bf28328b-1d65-45d5-a35b-fd764b9abca8; Fri, 02 Oct 2020 11:05:26 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kOIsR-0000f1-8T for xen-devel@lists.xenproject.org; Fri, 02 Oct 2020 11:05:27 +0000 X-Inumbo-ID: bf28328b-1d65-45d5-a35b-fd764b9abca8 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bf28328b-1d65-45d5-a35b-fd764b9abca8; Fri, 02 Oct 2020 11:05:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1601636726; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=LlGMt2gR70LijQzCMasO19ZCOl1CsAHLpIhOPQuW0eM=; b=FRJUVZqMI1DccePmoMYy0qUx2/CsuAaswHaUeT7sDz3QUntYri+2u6cp jLEPGW13ojGVdDQuVI7wFq9H2w9pGoe93rvc8pr2HCpaAXiS1CWGt5nPS PhiLtxShW60aynAC0k2SYS4IDIyePDiBnswx9TniZK7WaXdg6SYWc/kK8 k=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: ZzOvdlpDCPo1BFRgQe3Ch+tkC/gsBLxEDueoj12E3vfP/UWVt7mBYJZsdn+w92KwRnW9eq+7TW NYZTNTkR3H5W1lA1voZwKdTBNVKOEVTfB+zQfw5FCewF5Oul66e6iCZsNBrrCjYAt02jKkHfBJ nGdGgh5pV4Ving88bGNxtSTrfHuKGeGft3jk6j5uh3b20m+kL50bgJIL0aTUzJ9S0wnAOoHADJ Yxo1zRgs9fTaxjZaylrs61LMSu5xq2PxeZgJTgfz3Lms4WPBYBCpj6Kp1aqYExfZN68XhOHbXP 0Ew= X-SBRS: None X-MesageID: 28240433 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.77,327,1596513600"; d="scan'208";a="28240433" Subject: Re: [PATCH v3] tools/libs/stat: fix broken build To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Bertrand Marquis CC: "open list:X86" , Ian Jackson , Wei Liu References: <20200912130836.11024-1-jgross@suse.com> <5232FD74-9636-4EF4-81F8-2EF7EE21D326@arm.com> <87CA2B55-B372-458C-82CC-2423B8AC3EEE@arm.com> From: Andrew Cooper Message-ID: <06775f15-da14-c4eb-7076-8ebe8d964339@citrix.com> Date: Fri, 2 Oct 2020 12:05:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Language: en-GB X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To FTLPEX02CL05.citrite.net (10.13.108.178) On 02/10/2020 05:50, Jürgen Groß wrote: > On 01.10.20 18:38, Bertrand Marquis wrote: >> Hi Juergen, >> >>> On 14 Sep 2020, at 11:58, Bertrand Marquis >>> wrote: >>> >>> >>> >>>> On 12 Sep 2020, at 14:08, Juergen Gross wrote: >>>> >>>> Making getBridge() static triggered a build error with some gcc >>>> versions: >>>> >>>> error: 'strncpy' output may be truncated copying 15 bytes from a >>>> string of >>>> length 255 [-Werror=stringop-truncation] >>>> >>>> Fix that by using a buffer with 256 bytes instead. >>>> >>>> Fixes: 6d0ec053907794 ("tools: split libxenstat into new >>>> tools/libs/stat directory") >>>> Signed-off-by: Juergen Gross >>> Reviewed-by: Bertrand Marquis >> >> Sorry i have to come back on this one. >> >> I still see an error compiling with Yocto on this one: >> |     inlined from 'xenstat_collect_networks' at xenstat_linux.c:306:2: >> | xenstat_linux.c:81:6: error: 'strncpy' output may be truncated >> copying 255 bytes from a string of length 255 >> [-Werror=stringop-truncation] >> |    81 |      strncpy(result, de->d_name, resultLen); >> |       |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> To solve it, I need to define devBridge[257] as devNoBrideg. > > IMHO this is a real compiler error. > > de->d_name is an array of 256 bytes, so doing strncpy() from that to > another array of 256 bytes with a length of 256 won't truncate anything. > > Making devBridge one byte longer would be dangerous, as this would do > a strncpy with length of 257 from a source with a length of 256 bytes > only. > > BTW, I think Andrew? has tested my patch with a recent gcc which threw > the original error without my patch, and it was fine with the patch. > Either your compiler (assuming you are using gcc) has gained that error > or you are missing an update fixing it. All I was doing was using the gitlab CI, and reporting the failing tests. ~Andrew