From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAEDBC432BE for ; Tue, 31 Aug 2021 21:35:35 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A00566101B for ; Tue, 31 Aug 2021 21:35:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A00566101B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3033E82F4D; Tue, 31 Aug 2021 23:35:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=walle.cc header.i=@walle.cc header.b="fdyFH+x9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 26EF9831C7; Tue, 31 Aug 2021 23:35:30 +0200 (CEST) Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C79F382F34 for ; Tue, 31 Aug 2021 23:35:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=walle.cc Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@walle.cc Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 275F122234; Tue, 31 Aug 2021 23:35:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1630445725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=liL1XteB0YXAu2roo934dTlbV4WGBI4VPTr8uhTsoNc=; b=fdyFH+x9nShdKb58AYDM3Z7wgURFbg+TDnLioICv8aK5g7N/Ps5tWWiMJdr5t8VT6fkigV 604qmfn3m6hIg3ulQWcwaV7JpHjGSQQD6X6lb/6WvTjH0XlIYhxe8T1cTHlgmzNsm3Z6gX 7ErC3OxmljLA/F7Xm1tOJsHu/uJCdAI= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 31 Aug 2021 23:35:25 +0200 From: Michael Walle To: Vladimir Oltean Cc: u-boot@lists.denx.de, Jagan Teki , Priyanka Jain , Tom Rini , Peter Griffin , Manivannan Sadhasivam Subject: Re: [PATCH 6/9] spi: fsl_dspi: add new compatible fsl,ls1021a-v1.0-dspi In-Reply-To: <20210831183255.uilwjpci63nv7znw@skbuf> References: <20210831154028.1649864-1-michael@walle.cc> <20210831154028.1649864-7-michael@walle.cc> <20210831183255.uilwjpci63nv7znw@skbuf> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <068143935074f09ce366cc1b760e6b57@walle.cc> X-Sender: michael@walle.cc X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Am 2021-08-31 20:32, schrieb Vladimir Oltean: > On Tue, Aug 31, 2021 at 05:40:25PM +0200, Michael Walle wrote: >> The offical ls1028a binding of the driver uses the following as > > Same typo as before. > >> compatibles: >> compatible = "fsl,ls1028a-dspi", "fsl,ls1021a-v1.0-dspi"; >> >> Add the missing compatible to the driver and update the device tree. >> >> Signed-off-by: Michael Walle >> --- >> diff --git a/drivers/spi/fsl_dspi.c b/drivers/spi/fsl_dspi.c >> index 8fe3508c64..23d812f476 100644 >> --- a/drivers/spi/fsl_dspi.c >> +++ b/drivers/spi/fsl_dspi.c >> @@ -654,6 +654,7 @@ static const struct dm_spi_ops fsl_dspi_ops = { >> >> static const struct udevice_id fsl_dspi_ids[] = { >> { .compatible = "fsl,vf610-dspi" }, >> + { .compatible = "fsl,ls1021a-v1.0-dspi" }, > > Okay, so you say it is pointless to add the "fsl,ls1028a-dspi" > compatible string as well, since the U-Boot driver will match on the > fallback compatible, and that is absolutely sufficient, since U-Boot > will never implement any of the LS1028A specifics (DMA) anyway. > I'm fine with that. I'll add that to the commit message in the next version. > > Reviewed-by: Vladimir Oltean -michael