All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: iii@linux.ibm.com
Subject: Re: [PATCH 3/4] accel/tcg: Handle false negative lookup in page_check_range
Date: Wed, 28 Dec 2022 19:53:52 +0100	[thread overview]
Message-ID: <069fff0e-cece-d403-1a89-c2082b8d86ef@linaro.org> (raw)
In-Reply-To: <cfbbcf46-7e3c-5f52-390e-ea5f39829716@linaro.org>

On 28/12/22 19:30, Richard Henderson wrote:
> On 12/28/22 10:27, Philippe Mathieu-Daudé wrote:
>> Oh, so you are using this variable as tri-state?
> 
> Yes.  Perhaps a comment on the -1?

Or name the variable tristate_lock? And a comment :)
(No need to respin, you can keep my R-b).



  reply	other threads:[~2022-12-28 18:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-24 15:18 [PATCH 0/4] accel/tcg: Fixes for user-only page tracking Richard Henderson
2022-12-24 15:18 ` [PATCH 1/4] accel/tcg: Fix tb_invalidate_phys_page_unwind Richard Henderson
2022-12-28 12:49   ` [PATCH 1a/4] " Philippe Mathieu-Daudé
2022-12-28 12:49     ` [PATCH 1b/4] accel/tcg: Unindent tb_invalidate_phys_page_unwind Philippe Mathieu-Daudé
2022-12-28 12:52       ` Philippe Mathieu-Daudé
2022-12-28 12:52     ` [PATCH 1a/4] accel/tcg: Fix tb_invalidate_phys_page_unwind Philippe Mathieu-Daudé
2022-12-24 15:18 ` [PATCH 2/4] accel/tcg: Use g_free_rcu for user-exec interval trees Richard Henderson
2022-12-28  7:19   ` Philippe Mathieu-Daudé
2022-12-24 15:18 ` [PATCH 3/4] accel/tcg: Handle false negative lookup in page_check_range Richard Henderson
2022-12-28  7:24   ` Philippe Mathieu-Daudé
2022-12-28 12:53     ` Philippe Mathieu-Daudé
2022-12-28 17:36     ` Richard Henderson
2022-12-28 18:27       ` Philippe Mathieu-Daudé
2022-12-28 18:30         ` Richard Henderson
2022-12-28 18:53           ` Philippe Mathieu-Daudé [this message]
2022-12-24 15:18 ` [PATCH 4/4] tests/tcg/multiarch: add vma-pthread.c Richard Henderson
2022-12-27 17:23   ` Alex Bennée
2023-01-13 15:17   ` Peter Maydell
2023-01-13 17:10     ` Alex Bennée
2023-01-16 12:40       ` Philippe Mathieu-Daudé
2023-01-16 15:07         ` Peter Maydell
2023-01-16 16:27           ` Alex Bennée
2023-01-16 16:48             ` Peter Maydell
2023-01-16 17:09               ` Alex Bennée
2023-01-16 19:21             ` Richard Henderson
2023-01-20 14:58       ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=069fff0e-cece-d403-1a89-c2082b8d86ef@linaro.org \
    --to=philmd@linaro.org \
    --cc=iii@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.