From: Konrad Dybcio <konradybcio@gmail.com>
To: Dang Huynh <danct12@riseup.net>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, martin.botka@somainline.org,
marijn.suijten@somainline.org, paul.bouchara@somainline.org,
angelogioacchino.delregno@somainline.org,
Caleb Connolly <caleb@connolly.tech>
Subject: Re: [PATCH v2 6/7] arm64: dts: qcom: sdm660-xiaomi-lavender: Enable Simple Framebuffer
Date: Mon, 8 Nov 2021 13:56:07 +0100 [thread overview]
Message-ID: <06a286d6-b675-3322-79f2-1127935794b9@gmail.com> (raw)
In-Reply-To: <20211108050336.3404559-7-danct12@riseup.net>
On 08/11/2021 06:03, Dang Huynh wrote:
> This lets the user sees the framebuffer console.
>
> Reviewed-by: Caleb Connolly <caleb@connolly.tech>
> Reviewed-by: Martin Botka <martin.botka@somainline.org>
> Signed-off-by: Dang Huynh <danct12@riseup.net>
> ---
> .../boot/dts/qcom/sdm660-xiaomi-lavender.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts b/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
> index 8fd4d1732d94..122b487f197b 100644
> --- a/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm660-xiaomi-lavender.dts
> @@ -23,7 +23,21 @@ aliases {
> };
>
> chosen {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> stdout-path = "serial0:115200n8";
> +
> + framebuffer0: framebuffer@9d400000 {
> + compatible = "simple-framebuffer";
> + reg = <0 0x9d400000 0 (1080 * 2340 * 4)>;
> + width = <1080>;
> + height = <2340>;
> + stride = <(1080 * 4)>;
> + format = "a8r8g8b8";
> + status= "okay";
This line is redundant.
Konrad
next prev parent reply other threads:[~2021-11-08 12:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 5:03 [PATCH v2 0/7] Improve support for Xiaomi Redmi Note 7 Dang Huynh
2021-11-08 5:03 ` [PATCH v2 1/7] arm64: dts: qcom: sdm630: Assign numbers to eMMC and SD Dang Huynh
2021-11-11 17:56 ` AngeloGioacchino Del Regno
2021-11-08 5:03 ` [PATCH v2 2/7] arm64: dts: qcom: sdm660-xiaomi-lavender: Add RPM and fixed regulators Dang Huynh
2021-11-08 12:48 ` Konrad Dybcio
2021-11-08 5:03 ` [PATCH v2 3/7] arm64: dts: qcom: sdm660-xiaomi-lavender: Add volume down button Dang Huynh
2021-11-08 12:51 ` Konrad Dybcio
2021-11-08 5:03 ` [PATCH v2 4/7] arm64: dts: qcom: sdm660-xiaomi-lavender: Add volume up button Dang Huynh
2021-11-08 12:54 ` Konrad Dybcio
2021-11-08 5:03 ` [PATCH v2 5/7] arm64: dts: qcom: sdm660-xiaomi-lavender: Add eMMC and SD Dang Huynh
2021-11-08 5:03 ` [PATCH v2 6/7] arm64: dts: qcom: sdm660-xiaomi-lavender: Enable Simple Framebuffer Dang Huynh
2021-11-08 12:56 ` Konrad Dybcio [this message]
2021-11-08 5:03 ` [PATCH v2 7/7] arm64: dts: qcom: sdm660-xiaomi-lavender: Add USB Dang Huynh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06a286d6-b675-3322-79f2-1127935794b9@gmail.com \
--to=konradybcio@gmail.com \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=caleb@connolly.tech \
--cc=danct12@riseup.net \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=paul.bouchara@somainline.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.