All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sørensen, Stefan" <Stefan.Sorensen@spectralink.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] dropbear: Do not build static binary
Date: Fri, 4 May 2018 06:27:02 +0000	[thread overview]
Message-ID: <06a47e87f804576dc13ab3c33a8f9239cc318d9e.camel@spectralink.com> (raw)
In-Reply-To: <20180503180853.2473u472dvxhvwkn@tarshish>

On Thu, 2018-05-03 at 21:08 +0300, Baruch Siach wrote:
> > -ifeq ($(BR2_STATIC_LIBS),y)
> > -DROPBEAR_CONF_OPTS += --enable-static
> > -endif
> > +# The generic --enable-static flags is only intended for use when
> > building
> > +# libraries, but dropbear will be built as a static executeable
> > with this
> > +# flag, so we overide it here
> > +DROPBEAR_CONF_OPTS += --disable-static
> 
> You add --disable-static unconditionally, but we do want to build
> statically 
> when BR2_STATIC_LIBS=y. So maybe add --disable-static only for 
> BR2_SHARED_STATIC_LIBS=y to counter the effect of --enable-static
> that Buildroot adds automatically. Would that work for you?

The --disable-static causes dropbear to do nothing, i.e. just do a
normal link, so that will also work with BR2_STATIC_LIBS=y.

Stefan

  reply	other threads:[~2018-05-04  6:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 11:46 [Buildroot] [PATCH] dropbear: Fix host key loading with 521 bit ecdsa keys Stefan Sørensen
2018-05-03 11:47 ` [Buildroot] [PATCH] dropbear: Do not build static binary Stefan Sørensen
2018-05-03 18:08   ` Baruch Siach
2018-05-04  6:27     ` Sørensen, Stefan [this message]
2018-05-06 18:39       ` Baruch Siach
2018-05-03 11:47 ` [Buildroot] [PATCH v2] dropbear: Disable legacy/insecure options Stefan Sørensen
2018-05-03 21:04   ` Peter Korsgaard
2018-05-05  7:14 ` [Buildroot] [PATCH] dropbear: Fix host key loading with 521 bit ecdsa keys Peter Korsgaard
2018-08-27  9:36 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06a47e87f804576dc13ab3c33a8f9239cc318d9e.camel@spectralink.com \
    --to=stefan.sorensen@spectralink.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.