From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Lechner Subject: Re: [PATCH 3/3] ARM: dts: da850: Add node for pullup/pulldown pinconf Date: Wed, 23 Nov 2016 10:24:06 -0600 Message-ID: <06bc8517-8c33-85a1-9d5a-29042c7281db@lechnology.com> References: <1479871767-20160-1-git-send-email-david@lechnology.com> <1479871767-20160-4-git-send-email-david@lechnology.com> <8c3e6535-4b79-9731-f801-c13f007e48ab@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <8c3e6535-4b79-9731-f801-c13f007e48ab@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sekhar Nori , Linus Walleij , Rob Herring , Mark Rutland , Kevin Hilman Cc: devicetree@vger.kernel.org, Axel Haslam , =?UTF-8?Q?Bartosz_Go=c5=82aszewski?= , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Alexandre Bailon , linux-arm-kernel@lists.infradead.org List-Id: linux-gpio@vger.kernel.org On 11/23/2016 05:12 AM, Sekhar Nori wrote: > On Wednesday 23 November 2016 08:59 AM, David Lechner wrote: >> This SoC has a separate pin controller for configuring pullup/pulldown >> bias on groups of pins. >> >> Signed-off-by: David Lechner >> --- >> arch/arm/boot/dts/da850.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi >> index 8945815..1c0224c 100644 >> --- a/arch/arm/boot/dts/da850.dtsi >> +++ b/arch/arm/boot/dts/da850.dtsi >> @@ -210,6 +210,11 @@ >> }; >> >> }; >> + pinconf: pin-controller@22c00c { >> + compatible = "ti,da850-pupd"; >> + reg = <0x22c00c 0x8>; >> + status = "disabled"; >> + }; > > Can you please place this below the i2c1 node. I am trying to keep the > nodes sorted by unit address. I know thats broken in many places today, > but lets add the new ones where they should eventually end up. I can do this, but it seems that the predominant sorting pattern here is to keep subsystems together (e.g. all i2c are together, all uart are together, etc.) Would a separate patch to sort everything by unit address to get this cleaned up be acceptable? > > Thanks, > Sekhar > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933144AbcKWQZH (ORCPT ); Wed, 23 Nov 2016 11:25:07 -0500 Received: from vern.gendns.com ([206.190.152.46]:51606 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754406AbcKWQYu (ORCPT ); Wed, 23 Nov 2016 11:24:50 -0500 Subject: Re: [PATCH 3/3] ARM: dts: da850: Add node for pullup/pulldown pinconf To: Sekhar Nori , Linus Walleij , Rob Herring , Mark Rutland , Kevin Hilman References: <1479871767-20160-1-git-send-email-david@lechnology.com> <1479871767-20160-4-git-send-email-david@lechnology.com> <8c3e6535-4b79-9731-f801-c13f007e48ab@ti.com> Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Axel Haslam , Alexandre Bailon , =?UTF-8?Q?Bartosz_Go=c5=82aszewski?= From: David Lechner Message-ID: <06bc8517-8c33-85a1-9d5a-29042c7281db@lechnology.com> Date: Wed, 23 Nov 2016 10:24:06 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <8c3e6535-4b79-9731-f801-c13f007e48ab@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/23/2016 05:12 AM, Sekhar Nori wrote: > On Wednesday 23 November 2016 08:59 AM, David Lechner wrote: >> This SoC has a separate pin controller for configuring pullup/pulldown >> bias on groups of pins. >> >> Signed-off-by: David Lechner >> --- >> arch/arm/boot/dts/da850.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi >> index 8945815..1c0224c 100644 >> --- a/arch/arm/boot/dts/da850.dtsi >> +++ b/arch/arm/boot/dts/da850.dtsi >> @@ -210,6 +210,11 @@ >> }; >> >> }; >> + pinconf: pin-controller@22c00c { >> + compatible = "ti,da850-pupd"; >> + reg = <0x22c00c 0x8>; >> + status = "disabled"; >> + }; > > Can you please place this below the i2c1 node. I am trying to keep the > nodes sorted by unit address. I know thats broken in many places today, > but lets add the new ones where they should eventually end up. I can do this, but it seems that the predominant sorting pattern here is to keep subsystems together (e.g. all i2c are together, all uart are together, etc.) Would a separate patch to sort everything by unit address to get this cleaned up be acceptable? > > Thanks, > Sekhar > From mboxrd@z Thu Jan 1 00:00:00 1970 From: david@lechnology.com (David Lechner) Date: Wed, 23 Nov 2016 10:24:06 -0600 Subject: [PATCH 3/3] ARM: dts: da850: Add node for pullup/pulldown pinconf In-Reply-To: <8c3e6535-4b79-9731-f801-c13f007e48ab@ti.com> References: <1479871767-20160-1-git-send-email-david@lechnology.com> <1479871767-20160-4-git-send-email-david@lechnology.com> <8c3e6535-4b79-9731-f801-c13f007e48ab@ti.com> Message-ID: <06bc8517-8c33-85a1-9d5a-29042c7281db@lechnology.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/23/2016 05:12 AM, Sekhar Nori wrote: > On Wednesday 23 November 2016 08:59 AM, David Lechner wrote: >> This SoC has a separate pin controller for configuring pullup/pulldown >> bias on groups of pins. >> >> Signed-off-by: David Lechner >> --- >> arch/arm/boot/dts/da850.dtsi | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi >> index 8945815..1c0224c 100644 >> --- a/arch/arm/boot/dts/da850.dtsi >> +++ b/arch/arm/boot/dts/da850.dtsi >> @@ -210,6 +210,11 @@ >> }; >> >> }; >> + pinconf: pin-controller at 22c00c { >> + compatible = "ti,da850-pupd"; >> + reg = <0x22c00c 0x8>; >> + status = "disabled"; >> + }; > > Can you please place this below the i2c1 node. I am trying to keep the > nodes sorted by unit address. I know thats broken in many places today, > but lets add the new ones where they should eventually end up. I can do this, but it seems that the predominant sorting pattern here is to keep subsystems together (e.g. all i2c are together, all uart are together, etc.) Would a separate patch to sort everything by unit address to get this cleaned up be acceptable? > > Thanks, > Sekhar >