Re: [Qemu-devel] [PATCH v2 2/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

[Viktor VM Mihajlovski <mihajlov@linux.vnet.ibm.com>]

On 23.04.2018 09:58, Thomas Huth wrote:
> Since it is quite cumbersome to manually create a combined kernel with
> initrd image for network booting, we now support loading via pxelinux
> configuration files, too. In these files, the kernel, initrd and command
> line parameters can be specified seperately, and the firmware then takes
> care of glueing everything together in memory after the files have been
> downloaded.
> 
> The user can either specify a config file directly as bootfile via DHCP
> (but in this case, the file has to start either with "default" or a "#"
> comment so we can distinguish it from binary kernels), or a folder (i.e.
> the bootfile name must end with "/") where the firmware should look for
> the typical pxelinux.cfg file names based on MAC or IP address. If no
> direct file or folder has been specified, we still look for certain
> files in the default "pxelinux.cfg/" folder, but omit some of the file
> names to avoid to download x86 config files here by mistake.
I don't think this is necessary, since the DHCP server configuration
SHOULD take into consideration the processor architecture. In fact it is
even annoying and hard to understand that an attempt is made to load the
uuid, mac and "full ip" based config files but not the "abbreviated ip"
or default file. After all, even if the config file for x86 was loaded,
the effect will be that the network boot fails (as it does now).
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  pc-bios/s390-ccw/netboot.mak |   5 +-
>  pc-bios/s390-ccw/netmain.c   | 225 +++++++++++++++++++++++++++++++++++++++++--
>  2 files changed, 222 insertions(+), 8 deletions(-)
> 
[...]
-- 
Regards,
  Viktor Mihajlovski