From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BEB6C2D0E4 for ; Mon, 23 Nov 2020 16:22:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 171502080A for ; Mon, 23 Nov 2020 16:22:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OszQORYm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 171502080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:41422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1khEby-0000QR-I5 for qemu-devel@archiver.kernel.org; Mon, 23 Nov 2020 11:22:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1khEaA-0007vQ-2c for qemu-devel@nongnu.org; Mon, 23 Nov 2020 11:20:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22254) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1khEa4-0003l8-G4 for qemu-devel@nongnu.org; Mon, 23 Nov 2020 11:20:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606148441; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d96BieSpbYYLUvI015Uw7YfJKlGTJuHqmqaAjZ7UocA=; b=OszQORYmz+t0kOI5ZuLEmbtdMS/jAwPuZn0x7A5iVXjlhmXpcZfPTGoDFqB9ySL+4xlLQ9 +tFJsSW1GjajVLYyJs9cWaqo2qhJ7dC6Wgp6r0ILq18XPEvuHULR2olKJe4QSwMZeevCya byfYM9MrN+0LSPxWlIA+e0tnZevZ54Y= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-319-6WArALCZN5K5oMheMN6-yw-1; Mon, 23 Nov 2020 11:20:38 -0500 X-MC-Unique: 6WArALCZN5K5oMheMN6-yw-1 Received: by mail-ed1-f69.google.com with SMTP id p24so6750864eds.7 for ; Mon, 23 Nov 2020 08:20:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=d96BieSpbYYLUvI015Uw7YfJKlGTJuHqmqaAjZ7UocA=; b=lID8CgZV76+X4ZYI52KSQFZljLeAuktyQBRN0zzxWumcNS107IaRhDxQIiFRhsOuBq BZfGl63cPZDfiz6VszXMvtGiEdKXzrr0Zfw4xHSfwfTdF01zQM5a51WlVgYzMTZga2xo puLBWsf5rcS84edUaserexihg9Y+tfgwZhTu3tKD9iPeMe0n9aRvexnnqNMbZ56J6I1g rfMZ1q9PmQvBaIzN5/KtsvKlKnRJbcN+il/oixO1gr6kgs210ni2/grgHZJ1QdrZFnM1 3ZoKihNm0EaJvz1v6YIsH8YqUItOXzhaH0SY2NypI7LQH1f4V6sxJx7RQ6/QbCa3lz5o m4NA== X-Gm-Message-State: AOAM530017gTqGXL7qopQxNVvRpScNBqddOFSsPfNsfm6wj1YRyrD6hB nU3z4WTtkpjwGrHSi76yzTlIJEr0aUp8sDKmzVfqeeqkRgvu3HO+StQHoyrNIy5ReOQ6Jm+xmj1 xaQKpILyZkAerPlU= X-Received: by 2002:a17:907:3da3:: with SMTP id he35mr333350ejc.9.1606148436064; Mon, 23 Nov 2020 08:20:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJyfcX5DXlQ4WedLkkMAigVgs+iYfLRVlDTUG78qh/gmGUIxTzpui5YlMOKqLcmZDbDubX2npw== X-Received: by 2002:a17:907:3da3:: with SMTP id he35mr333321ejc.9.1606148435829; Mon, 23 Nov 2020 08:20:35 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id cw15sm5226938ejb.64.2020.11.23.08.20.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Nov 2020 08:20:35 -0800 (PST) Subject: Re: Regressions in build process introduced since August To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Stefan Weil References: <97b04446-ca94-cebd-2d8d-4c2013521208@weilnetz.de> <20201117175030.eqz5run2m7qmx5qt@steredhat> <53da03f4-f044-fb1d-9a1a-a793077cccc3@redhat.com> <496e409e-533a-74fb-c4f7-8b394452d0be@weilnetz.de> <20201123152839.GJ987095@redhat.com> <20201123154106.GK987095@redhat.com> From: Paolo Bonzini Message-ID: <06cdb8fb-7218-c197-30fa-261db68f5e2e@redhat.com> Date: Mon, 23 Nov 2020 17:20:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201123154106.GK987095@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-devel , Stefano Garzarella Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 23/11/20 16:41, Daniel P. Berrangé wrote: > On Mon, Nov 23, 2020 at 03:28:39PM +0000, Daniel P. Berrangé wrote: >> On Mon, Nov 23, 2020 at 03:40:48PM +0100, Stefan Weil wrote: >>> Am 23.11.20 um 14:55 schrieb Paolo Bonzini: >>> >>>> On 21/11/20 12:09, Stefan Weil wrote: >>>>> --- a/meson.build >>>>> +++ b/meson.build >>>>> @@ -649,9 +649,8 @@ if get_option('vnc').enabled() >>>>>     vnc = declare_dependency() # dummy dependency >>>>>     png = dependency('libpng', required: get_option('vnc_png'), >>>>>                      method: 'pkg-config', static: enable_static) >>>>> -  jpeg = cc.find_library('jpeg', has_headers: ['jpeglib.h'], >>>>> -                         required: get_option('vnc_jpeg'), >>>>> -                         static: enable_static) >>>> >>>> Does it work if you just remove "static: enable_static"?  That asks >>>> Meson to look explicitly for a ".a" file instead of just adding a >>>> "-ljpeg" flag.  However it is not what configure used to do so it >>>> shouldn't be necessary. >>> >>> >>> No, that does not help. Neither header file nor library will be found in my >>> cross environment without using the provided --extra-cflags and >>> --extra-ldflags, because all those files are installed below >>> /usr/i686-w64-mingw32/sys-root/mingw or >>> /usr/x86_64-w64-mingw32/sys-root/mingw which is not searched by the default >>> compiler settings. The Meson checks obviously don't use those flags. >>> >>> pkg-config provides the right paths and works therefore. >> >> Relying on pkg-config should be our strong preference. I expect we're doing >> the old fashioned library check just for historical reasons, but even RHEL-7 >> supports pkg-config for libjpeg. So I think we're safe to just unconditionally >> rely on pkg-config these days and thus have it "just work" for cross compiles >> too. > > For that matter I think we can also rely on pkg-config for sasl too, as > again all our supported platforms have a new enough cyrus-sasl to have > a pkg-config file present these days. Yes, I agree. However we have at least -lmpathpersist that does not have a pkg-config file. In the meanwhile I'll integrate Stefan's patch. Stefan, is libjpeg the only one that is affected in your build environment? Paolo