From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net] ipv6: Revert "ipv6: Allow non-gateway ECMP for IPv6" Date: Wed, 2 May 2018 12:50:18 -0700 Message-ID: <06ce7e15-92f3-116a-21d0-5090f33ce845@gmail.com> References: <20180502194156.9275-1-idosch@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, dsahern@gmail.com, eric.dumazet@gmail.com, Thomas.Winter@alliedtelesis.co.nz, mlxsw@mellanox.com To: Ido Schimmel , netdev@vger.kernel.org Return-path: Received: from mail-pf0-f193.google.com ([209.85.192.193]:33110 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbeEBTuV (ORCPT ); Wed, 2 May 2018 15:50:21 -0400 Received: by mail-pf0-f193.google.com with SMTP id f20so3881347pfn.0 for ; Wed, 02 May 2018 12:50:21 -0700 (PDT) In-Reply-To: <20180502194156.9275-1-idosch@mellanox.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/02/2018 12:41 PM, Ido Schimmel wrote: > This reverts commit edd7ceb78296 ("ipv6: Allow non-gateway ECMP for > IPv6"). > > Eric reported a division by zero in rt6_multipath_rebalance() which is > caused by above commit that considers identical local routes to be > siblings. The division by zero happens because a nexthop weight is not > set for local routes. > > Revert the commit as it does not fix a bug and has side effects. > > To reproduce: > > # ip -6 address add 2001:db8::1/64 dev dummy0 > # ip -6 address add 2001:db8::1/64 dev dummy1 > > Fixes: edd7ceb78296 ("ipv6: Allow non-gateway ECMP for IPv6") > Signed-off-by: Ido Schimmel > Reported-by: Eric Dumazet > --- Tested-by: Eric Dumazet Thanks for fixing this !