From: David Ahern <dsahern@gmail.com>
To: Florian Westphal <fw@strlen.de>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 v3] libgenl: make genl_add_mcast_grp set errno on error
Date: Mon, 17 May 2021 08:44:07 -0600 [thread overview]
Message-ID: <06d411ad-9b64-dd58-bc13-9888af9edb22@gmail.com> (raw)
In-Reply-To: <20210517051010.1355-1-fw@strlen.de>
On 5/16/21 11:10 PM, Florian Westphal wrote:
> genl_add_mcast_grp doesn't set errno in all cases.
>
> On kernels that support mptcp but lack event support (all kernels <= 5.11)
> MPTCP_PM_EV_GRP_NAME won't be found and ip will exit with
>
> "can't subscribe to mptcp events: Success"
>
> Set errno to a meaningful value (ENOENT) when the group name isn't found
> and also cover other spots where it returns nonzero with errno unset.
>
> Fixes: ff619e4fd370 ("mptcp: add support for event monitoring")
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> Change since v2: include errno.h
> Change since v1: fix libgenl instead of setting errno in the caller.
> lib/libgenl.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
It is assigned to Stephen for main branch.
prev parent reply other threads:[~2021-05-17 16:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 5:10 [PATCH iproute2 v3] libgenl: make genl_add_mcast_grp set errno on error Florian Westphal
2021-05-17 14:44 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06d411ad-9b64-dd58-bc13-9888af9edb22@gmail.com \
--to=dsahern@gmail.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.