From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752593AbcL2H5p (ORCPT ); Thu, 29 Dec 2016 02:57:45 -0500 Received: from out0-143.mail.aliyun.com ([140.205.0.143]:52237 "EHLO out0-143.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752450AbcL2H5n (ORCPT ); Thu, 29 Dec 2016 02:57:43 -0500 X-Greylist: delayed 414 seconds by postgrey-1.27 at vger.kernel.org; Thu, 29 Dec 2016 02:57:43 EST X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e02c03292;MF=hillf.zj@alibaba-inc.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---.7MZvKO-_1482997785; Reply-To: "Hillf Danton" From: "Hillf Danton" To: "'Michal Hocko'" , Cc: "'Andrew Morton'" , "'Mel Gorman'" , "'Johannes Weiner'" , "'Vlastimil Babka'" , "'Rik van Riel'" , "'LKML'" , "'Michal Hocko'" References: <20161228153032.10821-1-mhocko@kernel.org> <20161228153032.10821-4-mhocko@kernel.org> In-Reply-To: <20161228153032.10821-4-mhocko@kernel.org> Subject: Re: [PATCH 3/7] mm, vmscan: show the number of skipped pages in mm_vmscan_lru_isolate Date: Thu, 29 Dec 2016 15:49:45 +0800 Message-ID: <06d701d261a8$20082390$60186ab0$@alibaba-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQKdd06YOfI90de32HGjIBSPbRj/+wK8wtQvn3J7EKA= Content-Language: zh-cn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, December 28, 2016 11:30 PM Michal Hocko wrote: > From: Michal Hocko > > mm_vmscan_lru_isolate shows the number of requested, scanned and taken > pages. This is mostly OK but on 32b systems the number of scanned pages > is quite misleading because it includes both the scanned and skipped > pages. Moreover the skipped part is scaled based on the number of taken > pages. Let's report the exact numbers without any additional logic and > add the number of skipped pages. This should make the reported data much > more easier to interpret. > > Signed-off-by: Michal Hocko > --- Acked-by: Hillf Danton From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f71.google.com (mail-pg0-f71.google.com [74.125.83.71]) by kanga.kvack.org (Postfix) with ESMTP id 43BFB6B0069 for ; Thu, 29 Dec 2016 02:50:08 -0500 (EST) Received: by mail-pg0-f71.google.com with SMTP id u5so521888583pgi.7 for ; Wed, 28 Dec 2016 23:50:08 -0800 (PST) Received: from out4433.biz.mail.alibaba.com (out4433.biz.mail.alibaba.com. [47.88.44.33]) by mx.google.com with ESMTP id m66si52616348pfc.209.2016.12.28.23.50.06 for ; Wed, 28 Dec 2016 23:50:07 -0800 (PST) Reply-To: "Hillf Danton" From: "Hillf Danton" References: <20161228153032.10821-1-mhocko@kernel.org> <20161228153032.10821-4-mhocko@kernel.org> In-Reply-To: <20161228153032.10821-4-mhocko@kernel.org> Subject: Re: [PATCH 3/7] mm, vmscan: show the number of skipped pages in mm_vmscan_lru_isolate Date: Thu, 29 Dec 2016 15:49:45 +0800 Message-ID: <06d701d261a8$20082390$60186ab0$@alibaba-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Language: zh-cn Sender: owner-linux-mm@kvack.org List-ID: To: 'Michal Hocko' , linux-mm@kvack.org Cc: 'Andrew Morton' , 'Mel Gorman' , 'Johannes Weiner' , 'Vlastimil Babka' , 'Rik van Riel' , 'LKML' , 'Michal Hocko' On Wednesday, December 28, 2016 11:30 PM Michal Hocko wrote: > From: Michal Hocko > > mm_vmscan_lru_isolate shows the number of requested, scanned and taken > pages. This is mostly OK but on 32b systems the number of scanned pages > is quite misleading because it includes both the scanned and skipped > pages. Moreover the skipped part is scaled based on the number of taken > pages. Let's report the exact numbers without any additional logic and > add the number of skipped pages. This should make the reported data much > more easier to interpret. > > Signed-off-by: Michal Hocko > --- Acked-by: Hillf Danton -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org