From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BB3FC433EF for ; Sat, 25 Jun 2022 03:33:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232155AbiFYDdY (ORCPT ); Fri, 24 Jun 2022 23:33:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231758AbiFYDdS (ORCPT ); Fri, 24 Jun 2022 23:33:18 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4C10DF52 for ; Fri, 24 Jun 2022 20:33:16 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4LVKJm2VPcz1KC6N; Sat, 25 Jun 2022 11:31:04 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Sat, 25 Jun 2022 11:33:14 +0800 Subject: Re: [PATCH 03/16] mm/huge_memory: fix comment of __pud_trans_huge_lock To: Zach O'Keefe CC: , , , , References: <20220622170627.19786-1-linmiaohe@huawei.com> <20220622170627.19786-4-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <06e1a03f-8529-b1ec-bdaf-79e67185043d@huawei.com> Date: Sat, 25 Jun 2022 11:33:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/6/25 2:47, Zach O'Keefe wrote: > On 23 Jun 01:06, Miaohe Lin wrote: >> __pud_trans_huge_lock returns page table lock pointer if a given pud maps >> a thp instead of 'true' since introduced. Fix corresponding comments. >> >> Signed-off-by: Miaohe Lin >> --- >> mm/huge_memory.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >> index 83fb6c3442ff..a26580da8011 100644 >> --- a/mm/huge_memory.c >> +++ b/mm/huge_memory.c >> @@ -1903,10 +1903,10 @@ spinlock_t *__pmd_trans_huge_lock(pmd_t *pmd, struct vm_area_struct *vma) >> } >> >> /* >> - * Returns true if a given pud maps a thp, false otherwise. >> + * Returns page table lock pointer if a given pud maps a thp, NULL otherwise. >> * >> - * Note that if it returns true, this routine returns without unlocking page >> - * table lock. So callers must unlock it. >> + * Note that if it returns page table lock pointe, this routine returns without > > s/pointe/pointer Thanks for catching this. > >> + * unlocking page table lock. So callers must unlock it. >> */ >> spinlock_t *__pud_trans_huge_lock(pud_t *pud, struct vm_area_struct *vma) >> { >> -- >> 2.23.0 >> > . >