All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: io-uring@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH for-6.1 1/1] selftests/net: don't tests batched TCP io_uring zc
Date: Wed, 2 Nov 2022 10:42:09 +0000	[thread overview]
Message-ID: <06f60984-151c-61c2-895f-41197271858f@gmail.com> (raw)
In-Reply-To: <b547698d5938b1b1a898af1c260188d8546ded9a.1666700897.git.asml.silence@gmail.com>

On 10/27/22 00:11, Pavel Begunkov wrote:
> It doesn't make sense batch submitting io_uring requests to a single TCP
> socket without linking or some other kind of ordering. Moreover, it
> causes spurious -EINTR fails due to interaction with task_work. Disable
> it for now and keep queue depth=1.

Jens, let's pick it up unless you have objections


> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
> ---
>   tools/testing/selftests/net/io_uring_zerocopy_tx.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/io_uring_zerocopy_tx.sh b/tools/testing/selftests/net/io_uring_zerocopy_tx.sh
> index 32aa6e9dacc2..9ac4456d48fc 100755
> --- a/tools/testing/selftests/net/io_uring_zerocopy_tx.sh
> +++ b/tools/testing/selftests/net/io_uring_zerocopy_tx.sh
> @@ -29,7 +29,7 @@ if [[ "$#" -eq "0" ]]; then
>   	for IP in "${IPs[@]}"; do
>   		for mode in $(seq 1 3); do
>   			$0 "$IP" udp -m "$mode" -t 1 -n 32
> -			$0 "$IP" tcp -m "$mode" -t 1 -n 32
> +			$0 "$IP" tcp -m "$mode" -t 1 -n 1
>   		done
>   	done
>   

-- 
Pavel Begunkov

  reply	other threads:[~2022-11-02 10:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 23:11 [PATCH for-6.1 1/1] selftests/net: don't tests batched TCP io_uring zc Pavel Begunkov
2022-11-02 10:42 ` Pavel Begunkov [this message]
2022-11-02 14:27 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06f60984-151c-61c2-895f-41197271858f@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.