From: Tom Lendacky <thomas.lendacky@amd.com>
To: Peter Gonda <pgonda@google.com>
Cc: David Rientjes <rientjes@google.com>,
Marc Orr <marcorr@google.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Joerg Roedel <jroedel@suse.de>,
Herbert Xu <herbert@gondor.apana.org.au>,
John Allen <john.allen@amd.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Bonzini <pbonzini@redhat.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 4/4] crypto: ccp - Add SEV_INIT_EX support
Date: Tue, 2 Nov 2021 10:38:02 -0500 [thread overview]
Message-ID: <0701eb12-a60e-381f-ddd0-9ee9a0fa3edb@amd.com> (raw)
In-Reply-To: <20211102142331.3753798-5-pgonda@google.com>
On 11/2/21 9:23 AM, Peter Gonda wrote:
> From: David Rientjes <rientjes@google.com>
>
> +
> + nread = kernel_read(fp, sev_init_ex_nv_address, NV_LENGTH, NULL);
Not sure if you missed the previous comment, but kernel_read can return an
error, shouldn't it be checked and fail on error?
Thanks,
Tom
> + dev_dbg(psp_master->dev, "SEV: read %ld bytes from NV file\n", nread);
> + filp_close(fp, NULL);
> +
> + return 0;
> +}
> +
next prev parent reply other threads:[~2021-11-02 15:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 14:23 [PATCH V3 0/4] Add SEV_INIT_EX support Peter Gonda
2021-11-02 14:23 ` [PATCH V3 1/4] crypto: ccp - Fix SEV_INIT error logging on init Peter Gonda
2021-11-09 16:26 ` Sean Christopherson
2021-11-09 16:46 ` Peter Gonda
2021-11-09 19:25 ` Tom Lendacky
2021-11-10 17:29 ` Peter Gonda
2021-11-11 14:10 ` Tom Lendacky
2021-11-02 14:23 ` [PATCH V3 2/4] crypto: ccp - Move SEV_INIT retry for corrupted data Peter Gonda
2021-11-09 16:31 ` Sean Christopherson
2021-11-09 16:56 ` Peter Gonda
2021-11-09 17:30 ` Sean Christopherson
2021-11-09 18:42 ` Peter Gonda
2021-11-02 14:23 ` [PATCH V3 3/4] crypto: ccp - Refactor out sev_fw_alloc() Peter Gonda
2021-11-02 14:23 ` [PATCH V3 4/4] crypto: ccp - Add SEV_INIT_EX support Peter Gonda
2021-11-02 15:38 ` Tom Lendacky [this message]
2021-11-02 16:28 ` Peter Gonda
2021-11-09 17:21 ` Sean Christopherson
2021-11-09 20:09 ` Peter Gonda
2021-11-09 20:26 ` Sean Christopherson
2021-11-09 20:46 ` Peter Gonda
2021-11-09 22:19 ` Brijesh Singh
2021-11-10 15:32 ` Peter Gonda
2021-11-12 16:55 ` Peter Gonda
2021-11-12 17:46 ` Marc Orr
2021-11-12 17:49 ` Peter Gonda
2021-11-12 18:28 ` Marc Orr
2021-11-12 23:39 ` Brijesh Singh
2021-11-12 23:44 ` Peter Gonda
2021-11-12 23:50 ` Brijesh Singh
2021-11-15 17:42 ` Peter Gonda
2021-11-02 16:05 ` [PATCH V3 0/4] " Sean Christopherson
2021-11-02 16:25 ` Peter Gonda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0701eb12-a60e-381f-ddd0-9ee9a0fa3edb@amd.com \
--to=thomas.lendacky@amd.com \
--cc=brijesh.singh@amd.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=john.allen@amd.com \
--cc=jroedel@suse.de \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcorr@google.com \
--cc=pbonzini@redhat.com \
--cc=pgonda@google.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.