From: Javier Martinez Canillas <javierm@redhat.com>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: Nicholas Vinson <nvinson234@gmail.com>,
grub-devel@gnu.org, Peter Jones <pjones@redhat.com>,
Vladimir Serbinenko <phcoder@gmail.com>
Subject: Re: [PATCH v2] Add GRUB_DISABLE_UUID
Date: Tue, 22 Oct 2019 10:06:13 +0200 [thread overview]
Message-ID: <0706fec2-e865-3345-43a2-18a60ad2b2db@redhat.com> (raw)
In-Reply-To: <20191021142657.rvdo5ggx3gtvp6ec@tomti.i.net-space.pl>
Hello Daniel,
On 10/21/19 4:26 PM, Daniel Kiper wrote:
> On Fri, Oct 04, 2019 at 12:57:44PM +0200, Javier Martinez Canillas wrote:
>> Hello Nicolas,
>>
>> Thanks a lot for the feedback.
>>
>> On 10/3/19 4:29 AM, Nicholas Vinson wrote:
>>
>> [snip]
>>
>>>>>
>>>>> +if [ "x${GRUB_DISABLE_UUID}" = "xtrue" ]; then
>>>>> + if [ "x${GRUB_DISABLE_LINUX_UUID}" != "xfalse" ]; then
>>>>> + GRUB_DISABLE_LINUX_UUID="true"
>>>>> + fi
>>>>> + if [ "x${GRUB_DISABLE_LINUX_PARTUUID}" != "xfalse" ]; then
>>>>> + GRUB_DISABLE_LINUX_PARTUUID="true"
>>>>> + fi
>>>>> +fi
>>>
>>> I don't think this logic is exactly consistent with
>>> 51be3372ec8ba07ef68a409956ea0eefa89fe7c5. That commit assumes any value
>>> other than 'true' is false. It also sets the default values for
>>
>> I'm not sure how we could make it more consistent with the mentioned commit
>> while only setting it to 'true' if the user haven't explicitly set the var
>> as Dan asked in the previous version of the patch.
>
> It seems to me that it can be easily fixed, e.g.:
>
> if [ -z "${GRUB_DISABLE_LINUX_UUID}" ]; then
> GRUB_DISABLE_LINUX_UUID="true"
> fi
>
> Same for GRUB_DISABLE_LINUX_PARTUUID.
>
> Does it make sense?
>
Right, that makes sense. Thanks.
> Daniel
>
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat
prev parent reply other threads:[~2019-10-22 8:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 14:59 [PATCH v2] Add GRUB_DISABLE_UUID Javier Martinez Canillas
2019-10-02 12:09 ` Daniel Kiper
2019-10-03 2:29 ` Nicholas Vinson
2019-10-04 10:57 ` Javier Martinez Canillas
2019-10-18 8:02 ` Javier Martinez Canillas
2019-10-21 14:26 ` Daniel Kiper
2019-10-22 8:06 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0706fec2-e865-3345-43a2-18a60ad2b2db@redhat.com \
--to=javierm@redhat.com \
--cc=daniel.kiper@oracle.com \
--cc=grub-devel@gnu.org \
--cc=nvinson234@gmail.com \
--cc=phcoder@gmail.com \
--cc=pjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.