From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BE39C433E0 for ; Sun, 21 Feb 2021 13:44:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D74B464D99 for ; Sun, 21 Feb 2021 13:44:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229970AbhBUNob (ORCPT ); Sun, 21 Feb 2021 08:44:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229871AbhBUNo2 (ORCPT ); Sun, 21 Feb 2021 08:44:28 -0500 Received: from mail.marcansoft.com (marcansoft.com [IPv6:2a01:298:fe:f::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEA51C061574; Sun, 21 Feb 2021 05:43:47 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id B315E425BE; Sun, 21 Feb 2021 13:43:40 +0000 (UTC) Subject: Re: [PATCH v2 19/25] tty: serial: samsung_tty: IRQ rework To: Krzysztof Kozlowski Cc: linux-arm-kernel@lists.infradead.org, Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-20-marcan@marcan.st> <20210215184012.sf6p6dbk5c25phdm@kozik-lap> <31068a51-736b-08f6-6c00-1779734465ea@marcan.st> <20210220191124.wjkkqz2boxsdkf2b@kozik-lap> From: Hector Martin Message-ID: <07135a74-bd94-0c23-786e-7c073229fb32@marcan.st> Date: Sun, 21 Feb 2021 22:43:38 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210220191124.wjkkqz2boxsdkf2b@kozik-lap> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: es-ES Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/02/2021 04.11, Krzysztof Kozlowski wrote: > On Thu, Feb 18, 2021 at 10:53:10PM +0900, Hector Martin wrote: >> This should've gone in the next patch. A previous reviewer told me to put >> declarations at the top of the file, so I put it there and moved this one >> along with it, but I'll keep it to the additon only for v3. > > Maybe I missed something in the context but it looked like > forward declaration s3c24xx_serial_tx_chars() was not needed? In such > case no need to move it. It's needed in patch #22 in this series; having it in this patch was a mistake I made while splitting up the changes. I have moved that line to the Apple support patch for v3. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10DADC433DB for ; Sun, 21 Feb 2021 13:45:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7DE464D9C for ; Sun, 21 Feb 2021 13:45:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7DE464D9C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marcan.st Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CF0zU4QyRoSJIqH7lQdaMjQzYKpWxfyj+9eR4BjuPfg=; b=ezmTcfqYexN8OtOsRfuoqQrgy MvwBbH01PrIudJmczrnIztLcRYBU5o5S9to/+xNCeKFQY+JqcMgmiyEOXUftp0HxUoTC521XzL5qv HZnyKzybkAcxIkOmz/334xOar81xR6jNRPmtnNulufrksxhef9dz47Z+JMju/2D8gWUwY13uQiy0w XQ0q5ksXiUhoGf8iwfYCMHR/+p1kvB6ApUjT906KAtpGD8+/dKtlx9poKYwsG8IJ3/+ELAxr+l4/n ahIerri2cYIPXC2ezVBIWlOxJzcUrXLPAbkSMfavrw9E3VZ7E/v0JOxjzxz2zeZ9K9W5/E3M3iZo3 YGrt9ncGA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDp1d-00024T-Ey; Sun, 21 Feb 2021 13:43:53 +0000 Received: from marcansoft.com ([2a01:298:fe:f::2] helo=mail.marcansoft.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDp1a-00023z-AW for linux-arm-kernel@lists.infradead.org; Sun, 21 Feb 2021 13:43:51 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id B315E425BE; Sun, 21 Feb 2021 13:43:40 +0000 (UTC) Subject: Re: [PATCH v2 19/25] tty: serial: samsung_tty: IRQ rework To: Krzysztof Kozlowski References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-20-marcan@marcan.st> <20210215184012.sf6p6dbk5c25phdm@kozik-lap> <31068a51-736b-08f6-6c00-1779734465ea@marcan.st> <20210220191124.wjkkqz2boxsdkf2b@kozik-lap> From: Hector Martin Message-ID: <07135a74-bd94-0c23-786e-7c073229fb32@marcan.st> Date: Sun, 21 Feb 2021 22:43:38 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210220191124.wjkkqz2boxsdkf2b@kozik-lap> Content-Language: es-ES X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210221_084350_509192_16BF0D5A X-CRM114-Status: GOOD ( 15.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Arnd Bergmann , Rob Herring , Tony Lindgren , Marc Zyngier , Linus Walleij , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Alexander Graf , Olof Johansson , Mohamed Mediouni , Stan Skowronek , Will Deacon , linux-arm-kernel@lists.infradead.org, Mark Kettenis Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/02/2021 04.11, Krzysztof Kozlowski wrote: > On Thu, Feb 18, 2021 at 10:53:10PM +0900, Hector Martin wrote: >> This should've gone in the next patch. A previous reviewer told me to put >> declarations at the top of the file, so I put it there and moved this one >> along with it, but I'll keep it to the additon only for v3. > > Maybe I missed something in the context but it looked like > forward declaration s3c24xx_serial_tx_chars() was not needed? In such > case no need to move it. It's needed in patch #22 in this series; having it in this patch was a mistake I made while splitting up the changes. I have moved that line to the Apple support patch for v3. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel