From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D633FC11F64 for ; Thu, 1 Jul 2021 11:40:20 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94FE861468 for ; Thu, 1 Jul 2021 11:40:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94FE861468 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.148641.274683 (Exim 4.92) (envelope-from ) id 1lyv3F-0002SQ-T4; Thu, 01 Jul 2021 11:40:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 148641.274683; Thu, 01 Jul 2021 11:40:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyv3F-0002SJ-PO; Thu, 01 Jul 2021 11:40:13 +0000 Received: by outflank-mailman (input) for mailman id 148641; Thu, 01 Jul 2021 11:40:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyv3F-0002SD-52 for xen-devel@lists.xenproject.org; Thu, 01 Jul 2021 11:40:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lyv3D-0003nr-Qg; Thu, 01 Jul 2021 11:40:11 +0000 Received: from [54.239.6.188] (helo=a483e7b01a66.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lyv3D-0006D6-KH; Thu, 01 Jul 2021 11:40:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=qrHHKDwLGVAwuZ8YDEmJvO1B5Md1+6hA43DjhdVqj5k=; b=cdVZosP6NNW3LlUp4gI+YlaFds A4msxS1TOnxTapS/qF/mqe6pfUwGxn1UZoqn0IFkRrlisJiGQo6CBUwtUmZqWLXltzWWDpribNapr 8+je9hJkcReo0/3T1RSa423bI9mWRcHH3f01t0keDjeFU+4FAUiOk6QTaZ4Tq+h1oAZ0=; Subject: Re: [PATCH v20210701 08/40] MAINTAINERS: add myself as saverestore maintainer To: Olaf Hering , Jan Beulich Cc: Andrew Cooper , George Dunlap , Ian Jackson , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20210701095635.15648-1-olaf@aepfle.de> <20210701095635.15648-9-olaf@aepfle.de> <13a963c1-639f-5135-734b-9cc1c8d9034e@suse.com> <20210701130143.2b8cfce3.olaf@aepfle.de> From: Julien Grall Message-ID: <07174c4e-cf39-66c2-c3cb-27b728dc5819@xen.org> Date: Thu, 1 Jul 2021 12:40:09 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210701130143.2b8cfce3.olaf@aepfle.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Olaf, On 01/07/2021 12:01, Olaf Hering wrote: > Am Thu, 1 Jul 2021 12:39:06 +0200 > schrieb Jan Beulich : > >> I'm afraid this goes too far: This way you remove all prior >> (direct) maintainers (see "The meaning of nesting" in >> ./MAINTAINERS). And I'm sure Andrew, who has written much of >> this, ought to be considered to become the maintainer of this >> code then as well. > > I think this was copy&paste from some other entry, which would still include the tools/ maintainers when using get_maintainer.pl. I do not remember which one it was. You are mixing CCing and actual maintainers. You can be CCed without maintaining a directory. Jan's point is tools/ maintainers would not be directly maintaining the library. You would be the sole maintainer of the directory and Jan was referring the following paragraph: 1. Under normal circumstances, the Ack of the most specific maintainer is both necessary and sufficient to get a change to a given file committed. So a change to xen/arch/x86/mm/shadow/multi.c requires the the Ack of the xen/arch/x86/mm/shadow maintainer for that part of the patch, but would not require the Ack of the xen/arch/x86 maintainer or the xen/arch/x86/mm maintainer. Regarding your proposal to maintain the directory. I don't follow much the tools side and therefore can't judge the merit of the proposal. However... this is not new code per-se and therefore the fact you touch last is not sufficient (otherwise I could claim the same tomorrow if I send a patch to the directory ;)). For the commit message, I would suggest to provide some information about your contribution (including review) to the area. Also, was this discussed with the tools maintainers? Cheers, -- Julien Grall